- Prevents viewing newsletters if subscriber does not exist and token

does not match
This commit is contained in:
Vlad
2016-12-22 21:13:21 -05:00
parent e5e5e7b426
commit fc54f31d3d
2 changed files with 21 additions and 11 deletions

View File

@@ -39,11 +39,6 @@ class ViewInBrowser {
Newsletter::getByHash($data->newsletter_hash);
if(!$data->newsletter) return false;
// queue is optional; if defined, get it
$data->queue = (!empty($data->queue_id)) ?
SendingQueue::findOne($data->queue_id) :
SendingQueue::where('newsletter_id', $data->newsletter->id)->findOne();
// subscriber is optional; if exists, token must validate
$data->subscriber = (!empty($data->subscriber_id)) ?
Subscriber::findOne($data->subscriber_id) :
@@ -53,6 +48,15 @@ class ViewInBrowser {
!Subscriber::verifyToken($data->subscriber->email, $data->subscriber_token)
) return false;
}
// if newsletter ID is defined then subscriber must exist
if($data->newsletter_id && !$data->subscriber) return false;
// queue is optional; if defined, get it
$data->queue = (!empty($data->queue_id)) ?
SendingQueue::findOne($data->queue_id) :
SendingQueue::where('newsletter_id', $data->newsletter->id)->findOne();
// if queue and subscriber exist and newsletter is not being previewed,
// subscriber must have received the newsletter
if(empty($data->preview) &&