From fd6b49e598223f48b8fbdb813a9ee9a00ee8d957 Mon Sep 17 00:00:00 2001 From: Oluwaseun Olorunsola Date: Thu, 27 Oct 2022 09:06:35 +0100 Subject: [PATCH] Add type TagVariant for variant strings MAILPOET-4688 --- mailpoet/assets/js/src/common/tag/tag.tsx | 18 ++++++++++-------- mailpoet/assets/js/src/common/tag/tags.tsx | 11 ++--------- 2 files changed, 12 insertions(+), 17 deletions(-) diff --git a/mailpoet/assets/js/src/common/tag/tag.tsx b/mailpoet/assets/js/src/common/tag/tag.tsx index aab16a5c8f..824923b2dd 100644 --- a/mailpoet/assets/js/src/common/tag/tag.tsx +++ b/mailpoet/assets/js/src/common/tag/tag.tsx @@ -1,16 +1,18 @@ import { ReactNode } from 'react'; import classnames from 'classnames'; +export type TagVariant = + | 'average' + | 'good' + | 'excellent' + | 'critical' + | 'list' + | 'unknown' + | 'wordpress'; + type Props = { children?: ReactNode; - variant?: - | 'average' - | 'good' - | 'excellent' - | 'critical' - | 'list' - | 'unknown' - | 'wordpress'; + variant?: TagVariant; dimension?: 'large'; isInverted?: boolean; className?: string; diff --git a/mailpoet/assets/js/src/common/tag/tags.tsx b/mailpoet/assets/js/src/common/tag/tags.tsx index 5f28bddff9..17a59ba1f1 100644 --- a/mailpoet/assets/js/src/common/tag/tags.tsx +++ b/mailpoet/assets/js/src/common/tag/tags.tsx @@ -1,5 +1,5 @@ import { ReactNode } from 'react'; -import { Tag } from './tag'; +import { Tag, TagVariant } from './tag'; import { Tooltip } from '../tooltip/tooltip'; import { MailPoet } from '../../mailpoet'; @@ -21,14 +21,7 @@ type Props = { segments?: Segment[]; subscriberTags?: SubscriberTag[]; strings?: string[]; - variant?: - | 'average' - | 'good' - | 'excellent' - | 'critical' - | 'list' - | 'unknown' - | 'wordpress'; + variant?: TagVariant; isInverted?: boolean; };