diff --git a/assets/js/src/newsletter_editor/components/content.js b/assets/js/src/newsletter_editor/components/content.js index 0a300d9f80..44ac22b4b7 100644 --- a/assets/js/src/newsletter_editor/components/content.js +++ b/assets/js/src/newsletter_editor/components/content.js @@ -11,7 +11,7 @@ define([ // Does not hold newsletter content nor newsletter styles, those are // handled by other components. Module.NewsletterModel = SuperModel.extend({ - stale: ['data', 'styles'], + stale: ['content', 'globalStyles'], initialize: function(options) { this.on('change', function() { App.getChannel().trigger('autoSave'); @@ -45,8 +45,8 @@ define([ Module.toJSON = function() { return _.extend({ - data: App._contentContainer.toJSON(), - styles: App.getGlobalStyles().toJSON(), + content: App._contentContainer.toJSON(), + globalStyles: App.getGlobalStyles().toJSON(), }, App.getNewsletter().toJSON()); }; diff --git a/assets/js/src/newsletter_editor/components/sidebar.js b/assets/js/src/newsletter_editor/components/sidebar.js index 30945e4efb..a7a338b550 100644 --- a/assets/js/src/newsletter_editor/components/sidebar.js +++ b/assets/js/src/newsletter_editor/components/sidebar.js @@ -157,8 +157,8 @@ define([ "change #mailpoet_a_font_underline": function(event) { this.model.set('link.textDecoration', (event.target.checked) ? event.target.value : 'none'); }, - "change #mailpoet_newsletter_background_color": _.partial(this.changeColorField, 'newsletter.backgroundColor'), - "change #mailpoet_background_color": _.partial(this.changeColorField, 'background.backgroundColor'), + "change #mailpoet_newsletter_background_color": _.partial(this.changeColorField, 'wrapper.backgroundColor'), + "change #mailpoet_background_color": _.partial(this.changeColorField, 'body.backgroundColor'), }; }, templateHelpers: function() { diff --git a/assets/js/src/newsletter_editor/components/styles.js b/assets/js/src/newsletter_editor/components/styles.js index 7fe14ae22a..2cbe353040 100644 --- a/assets/js/src/newsletter_editor/components/styles.js +++ b/assets/js/src/newsletter_editor/components/styles.js @@ -34,10 +34,10 @@ define([ fontColor: '#21759B', textDecoration: 'underline', }, - newsletter: { + wrapper: { backgroundColor: '#ffffff', }, - background: { + body: { backgroundColor: '#cccccc', }, }, @@ -72,7 +72,7 @@ define([ App.getAvailableStyles = Module.getAvailableStyles; - this.setGlobalStyles(options.newsletter.styles); + this.setGlobalStyles(options.newsletter.globalStyles); }); App.on('start', function(options) { diff --git a/tests/javascript/newsletter_editor/components/content.spec.js b/tests/javascript/newsletter_editor/components/content.spec.js index 5d808014c1..9b86a9de3a 100644 --- a/tests/javascript/newsletter_editor/components/content.spec.js +++ b/tests/javascript/newsletter_editor/components/content.spec.js @@ -9,11 +9,11 @@ define([ beforeEach(function() { model = new (ContentComponent.NewsletterModel)({ - styles: { + globalStyles: { style1: 'style1Value', style2: 'style2Value', }, - data: { + content: { data1: 'data1Value', data2: 'data2Value', }, @@ -79,8 +79,8 @@ define([ }; var json = ContentComponent.toJSON(); expect(json).to.deep.equal(_.extend({ - data: dataField, - styles: stylesField + content: dataField, + globalStyles: stylesField }, newsletterFields)); }); }); diff --git a/tests/javascript/newsletter_editor/components/sidebar.spec.js b/tests/javascript/newsletter_editor/components/sidebar.spec.js index 472a799019..5f834b8bcb 100644 --- a/tests/javascript/newsletter_editor/components/sidebar.spec.js +++ b/tests/javascript/newsletter_editor/components/sidebar.spec.js @@ -67,10 +67,10 @@ define([ fontColor: '#000005', textDecoration: 'none', }, - newsletter: { + wrapper: { backgroundColor: '#090909', }, - background: { + body: { backgroundColor: '#020202', }, }); @@ -118,12 +118,12 @@ define([ it('changes model if newsletter background color field changes', function() { view.$('#mailpoet_newsletter_background_color').val('#636237').change(); - expect(model.get('newsletter.backgroundColor')).to.equal('#636237'); + expect(model.get('wrapper.backgroundColor')).to.equal('#636237'); }); it('changes model if background color field changes', function() { view.$('#mailpoet_background_color').val('#878587').change(); - expect(model.get('background.backgroundColor')).to.equal('#878587'); + expect(model.get('body.backgroundColor')).to.equal('#878587'); }); it('changes model if text font family field changes', function() { diff --git a/views/newsletter/editor.html b/views/newsletter/editor.html index ec86c06500..2af421b4c2 100644 --- a/views/newsletter/editor.html +++ b/views/newsletter/editor.html @@ -245,7 +245,7 @@