Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Extract newsletter validation to a service

Browse Source 
[MAILPOET-4236]
This commit is contained in:
John Oleksowicz
2022-04-13 14:42:23 -05:00
committed by Veljko V
parent f547eea48b
commit fdaf22d46b
4 changed files with 58 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
mailpoet/tests/integration/API/JSON/v1/SendingQueueTest.php
View File

@@ -18,6 +18,7 @@ use MailPoet\Newsletter\Options\NewsletterOptionsRepository;
use MailPoet\Newsletter\Scheduler\Scheduler;
use MailPoet\Newsletter\Sending\ScheduledTasksRepository;
use MailPoet\Newsletter\Sending\SendingQueuesRepository;
use MailPoet\Newsletter\Validator;
use MailPoet\Segments\SubscribersFinder;
use MailPoet\Services\Bridge;
use MailPoet\Settings\SettingsController;
@@ -80,11 +81,11 @@ class SendingQueueTest extends \MailPoetTest {
]),
$this->diContainer->get(NewslettersRepository::class),
$this->diContainer->get(SendingQueuesRepository::class),
$this->diContainer->get(Bridge::class),
$this->diContainer->get(SubscribersFinder::class),
$this->diContainer->get(ScheduledTasksRepository::class),
$this->diContainer->get(MailerFactory::class),
$this->diContainer->get(Scheduler::class)
$this->diContainer->get(Scheduler::class),
$this->diContainer->get(Validator::class)
);
$res = $sendingQueue->add(['newsletter_id' => $this->newsletter->getId()]);
expect($res->status)->equals(APIResponse::STATUS_FORBIDDEN);
@@ -149,13 +150,13 @@ class SendingQueueTest extends \MailPoetTest {
$this->diContainer->get(SubscribersFeature::class),
$this->diContainer->get(NewslettersRepository::class),
$this->diContainer->get(SendingQueuesRepository::class),
Stub::make(Bridge::class, [
'isMailpoetSendingServiceEnabled' => true,
]),
$this->diContainer->get(SubscribersFinder::class),
$this->diContainer->get(ScheduledTasksRepository::class),
$this->diContainer->get(MailerFactory::class),
$this->diContainer->get(Scheduler::class)
$this->diContainer->get(Scheduler::class),
new Validator(Stub::make(Bridge::class, [
'isMailpoetSendingServiceEnabled' => true,
]))
);
$response = $sendingQueue->add(['newsletter_id' => $newsletter->getId()]);
$response = $response->getData();