Refactor MailPoet\Cron to use new settings

[MAILPOET-1757]
This commit is contained in:
Rostislav Wolny
2019-01-30 13:57:18 +01:00
parent 6e79705128
commit ff238bf69a
21 changed files with 174 additions and 86 deletions

View File

@ -7,14 +7,20 @@ use AspectMock\Test as Mock;
use MailPoet\Cron\CronHelper;
use MailPoet\Cron\DaemonHttpRunner;
use MailPoet\Models\Setting;
use MailPoet\Settings\SettingsController;
use MailPoet\WP\Functions as WPFunctions;
class CronHelperTest extends \MailPoetTest {
/** @var SettingsController */
private $settings;
function _before() {
parent::_before();
Setting::setValue('db_version', MAILPOET_VERSION);
$this->settings = new SettingsController();
$this->settings->set('db_version', MAILPOET_VERSION);
// Disable cron trigger to not run tasks like migration when pinging the daemon
Setting::setValue('cron_trigger', array(
$this->settings->set('cron_trigger', array(
'method' => 'none'
));
Setting::setValue('sender', array(
@ -34,7 +40,7 @@ class CronHelperTest extends \MailPoetTest {
$token = 'create_token';
$time = time();
CronHelper::createDaemon($token);
$daemon = Setting::getValue(CronHelper::DAEMON_SETTING);
$daemon = $this->settings->get(CronHelper::DAEMON_SETTING);
expect($daemon)->equals(
array(
'token' => $token,
@ -52,7 +58,7 @@ class CronHelperTest extends \MailPoetTest {
$token = 'restart_token';
$time = time();
CronHelper::restartDaemon($token);
$daemon = Setting::getValue(CronHelper::DAEMON_SETTING);
$daemon = $this->settings->get(CronHelper::DAEMON_SETTING);
expect($daemon)->equals(
array(
'token' => $token,
@ -68,7 +74,7 @@ class CronHelperTest extends \MailPoetTest {
function testItLoadsDaemon() {
$daemon = $this->getDeamonTestData();
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);
@ -78,7 +84,7 @@ class CronHelperTest extends \MailPoetTest {
function testItSavesDaemon() {
// when saving daemon, 'updated_at' value should change
$daemon = $this->getDeamonTestData();
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);
@ -90,7 +96,7 @@ class CronHelperTest extends \MailPoetTest {
function testItUpdatesDaemonAccessedAt() {
$daemon = $this->getDeamonTestData();
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);
@ -118,7 +124,7 @@ class CronHelperTest extends \MailPoetTest {
$daemon = $this->getDeamonTestData();
$daemon['run_accessed_at'] = $time - 10;
$daemon['run_started_at'] = $run_start;
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);
@ -131,7 +137,7 @@ class CronHelperTest extends \MailPoetTest {
$daemon = $this->getDeamonTestData();
$daemon['run_accessed_at'] = $time - 5;
$daemon['run_started_at'] = $time - 4;
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);
@ -159,7 +165,7 @@ class CronHelperTest extends \MailPoetTest {
$daemon = $this->getDeamonTestData();
$daemon['run_accessed_at'] = $test_input['run_access'];
$daemon['run_started_at'] = $test_input['run_start'];
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);
@ -169,7 +175,7 @@ class CronHelperTest extends \MailPoetTest {
function testItDeactivatesDaemon() {
$daemon = $this->getDeamonTestData();
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);
@ -181,7 +187,7 @@ class CronHelperTest extends \MailPoetTest {
function testItSavesLastError() {
$daemon = $this->getDeamonTestData();
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);
@ -194,7 +200,7 @@ class CronHelperTest extends \MailPoetTest {
function testItSavesRunCompletedAt() {
$daemon = $this->getDeamonTestData();
Setting::setValue(
$this->settings->set(
CronHelper::DAEMON_SETTING,
$daemon
);