Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix flaky Import test

Browse Source 
Comparing timestamps with delta parameter allow values that differs by 1 second.
[MAILPOET-3412]
This commit is contained in:
Rostislav Wolny
2021-02-18 16:56:38 +01:00
committed by Veljko V
parent fa2313994d
commit ff284cb12f
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/integration/Subscribers/ImportExport/Import/ImportTest.php
View File

@ -65,8 +65,8 @@ class ImportTest extends \MailPoetTest {
$this->subscriberRepository = $this->diContainer->get(SubscribersRepository::class); $this->subscriberRepository = $this->diContainer->get(SubscribersRepository::class);
$this->subscriberSegmentRepository = $this->diContainer->get(SubscriberSegmentRepository::class); $this->subscriberSegmentRepository = $this->diContainer->get(SubscriberSegmentRepository::class);
$customField = $this->customFieldsRepository->createOrUpdate([ $customField = $this->customFieldsRepository->createOrUpdate([
'name' => 'country', 'name' => 'country',
'type' => CustomFieldEntity::TYPE_TEXT, 'type' => CustomFieldEntity::TYPE_TEXT,
]); ]);
assert($customField instanceof CustomFieldEntity); assert($customField instanceof CustomFieldEntity);
$this->subscribersCustomFields = [$customField->getId()]; $this->subscribersCustomFields = [$customField->getId()];
@ -501,9 +501,12 @@ class ImportTest extends \MailPoetTest {
expect($newSubscribers[1]->getSource())->equals('imported'); expect($newSubscribers[1]->getSource())->equals('imported');
expect(strlen((string)$newSubscribers[0]->getLinkToken()))->equals(SubscriberEntity::LINK_TOKEN_LENGTH); expect(strlen((string)$newSubscribers[0]->getLinkToken()))->equals(SubscriberEntity::LINK_TOKEN_LENGTH);
expect(strlen((string)$newSubscribers[1]->getLinkToken()))->equals(SubscriberEntity::LINK_TOKEN_LENGTH); expect(strlen((string)$newSubscribers[1]->getLinkToken()))->equals(SubscriberEntity::LINK_TOKEN_LENGTH);
$testTime = Carbon::createFromTimestamp($this->testData['timestamp']); $lastSubscribed1 = $newSubscribers[0]->getLastSubscribedAt();
expect($newSubscribers[0]->getLastSubscribedAt())->equals($testTime); $lastSubscribed2 = $newSubscribers[1]->getLastSubscribedAt();
expect($newSubscribers[1]->getLastSubscribedAt())->equals($testTime); assert($lastSubscribed1 instanceof \DateTimeInterface);
assert($lastSubscribed2 instanceof \DateTimeInterface);
expect($lastSubscribed1->getTimestamp())->equals($this->testData['timestamp'], 1);
expect($lastSubscribed2->getTimestamp())->equals($this->testData['timestamp'], 1);
} }
public function testItDoesNotUpdateExistingSubscribersLastSubscribedAtWhenItIsPresent() { public function testItDoesNotUpdateExistingSubscribersLastSubscribedAtWhenItIsPresent() {