diff --git a/lib/Cron/Workers/KeyCheck/KeyCheckWorker.php b/lib/Cron/Workers/KeyCheck/KeyCheckWorker.php index 5febe5657b..53bd98a2a1 100644 --- a/lib/Cron/Workers/KeyCheck/KeyCheckWorker.php +++ b/lib/Cron/Workers/KeyCheck/KeyCheckWorker.php @@ -19,7 +19,7 @@ abstract class KeyCheckWorker extends SimpleWorker { } } - function processQueueLogic(SendingQueue $queue) { + function processQueueStrategy(SendingQueue $queue) { try { $result = $this->checkKey(); } catch (\Exception $e) { diff --git a/lib/Cron/Workers/SimpleWorker.php b/lib/Cron/Workers/SimpleWorker.php index b860f2369f..c0086c9fe8 100644 --- a/lib/Cron/Workers/SimpleWorker.php +++ b/lib/Cron/Workers/SimpleWorker.php @@ -82,7 +82,7 @@ abstract class SimpleWorker { // abort if execution limit is reached CronHelper::enforceExecutionLimit($this->timer); - if($this->processQueueLogic($queue)) { + if($this->processQueueStrategy($queue)) { $this->complete($queue); return true; } @@ -90,7 +90,7 @@ abstract class SimpleWorker { return false; } - function processQueueLogic(SendingQueue $queue) { + function processQueueStrategy(SendingQueue $queue) { return true; } diff --git a/tests/unit/Cron/Workers/KeyCheck/KeyCheckWorkerTest.php b/tests/unit/Cron/Workers/KeyCheck/KeyCheckWorkerTest.php index 325c23de97..ae60e7ec2a 100644 --- a/tests/unit/Cron/Workers/KeyCheck/KeyCheckWorkerTest.php +++ b/tests/unit/Cron/Workers/KeyCheck/KeyCheckWorkerTest.php @@ -21,7 +21,7 @@ class KeyCheckWorkerTest extends MailPoetTest { function testItReturnsTrueOnSuccessfulKeyCheck() { $queue = $this->createRunningQueue(); - $result = $this->worker->processQueueLogic($queue); + $result = $this->worker->processQueueStrategy($queue); expect($result)->true(); } @@ -35,7 +35,7 @@ class KeyCheckWorkerTest extends MailPoetTest { $this ); $queue = $this->createRunningQueue(); - $result = $worker->processQueueLogic($queue); + $result = $worker->processQueueStrategy($queue); expect($result)->false(); } @@ -49,7 +49,7 @@ class KeyCheckWorkerTest extends MailPoetTest { $this ); $queue = $this->createRunningQueue(); - $result = $worker->processQueueLogic($queue); + $result = $worker->processQueueStrategy($queue); expect($result)->false(); } diff --git a/tests/unit/Cron/Workers/SimpleWorkerTest.php b/tests/unit/Cron/Workers/SimpleWorkerTest.php index 9fed1a824e..52df3fba45 100644 --- a/tests/unit/Cron/Workers/SimpleWorkerTest.php +++ b/tests/unit/Cron/Workers/SimpleWorkerTest.php @@ -149,7 +149,7 @@ class SimpleWorkerTest extends MailPoetTest { $worker = Stub::construct( $this->worker, array(), - array('processQueueLogic' => false), + array('processQueueStrategy' => false), $this ); $result = $worker->processQueue($queue);