Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Check data factories with PHPStan, fix discovered problems

Browse Source 
[MAILPOET-2429]
This commit is contained in:
Jan Jakeš
2019-10-16 13:44:04 +02:00
committed by Jack Kitterhing
parent eb02627a98
commit ffc11af689
4 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
RoboFile.php
View File

@@ -476,7 +476,12 @@ class RoboFile extends \Robo\Tasks {
// tests // tests
->taskExec($task) ->taskExec($task)
->rawArg('--configuration=phpstan-tests.neon') ->rawArg('--configuration=phpstan-tests.neon')
->arg("$dir/tests/unit") ->rawArg(
implode(' ', [
"$dir/tests/DataFactories",
"$dir/tests/unit",
])
)
->dir(__DIR__ . '/tasks/phpstan') ->dir(__DIR__ . '/tasks/phpstan')
->taskExec('cd ' . __DIR__ . ' && ./tools/vendor/composer.phar install') ->taskExec('cd ' . __DIR__ . ' && ./tools/vendor/composer.phar install')

1
tasks/phpstan/phpstan-tests.neon
View File

@@ -8,6 +8,7 @@ parameters:
- %mailpoetDir%/vendor/codeception/verify/src/Codeception/function.php - %mailpoetDir%/vendor/codeception/verify/src/Codeception/function.php
- %mailpoetDir%/vendor/codeception/verify/src/Codeception/Verify.php - %mailpoetDir%/vendor/codeception/verify/src/Codeception/Verify.php
autoload_directories: autoload_directories:
- %mailpoetDir%/tests/_support
- %mailpoetDir%/tests/unit - %mailpoetDir%/tests/unit
dynamicConstantNames: dynamicConstantNames:
- WP_DEBUG - WP_DEBUG

3
tests/DataFactories/Newsletter.php
View File

@@ -20,6 +20,9 @@ class Newsletter {
/** @var array */ /** @var array */
private $segments; private $segments;
/** @var array */
private $queue_options;
/** @var array */ /** @var array */
private $task_subscribers; private $task_subscribers;

2
tests/DataFactories/WooCommerceProduct.php
View File

@@ -98,7 +98,7 @@ class WooCommerceProduct {
$ids = array_map(function($id){ $ids = array_map(function($id){
return ['id' => $id]; return ['id' => $id];
}, $ids); }, $ids);
return $this->update('tagIds', $id); return $this->update('tagIds', $ids);
} }
/** /**