Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity
22,617 Commits 3 Branches 547 Tags
246a10f058dfbc58ceb51e43b32f62249c1fb8da
Commit Graph

107 Commits

Author SHA1 Message Date
Sam Najian
fdf0875905 Pause sending queue when encountering a corrupt newsletter 
[MAILPOET-4983]
 2023-03-01 17:46:22 +01:00
Sam Najian
93110826e7 Log when processing the queue for corrupt newsletter 
[MAILPOET-4983]
 2023-03-01 17:46:22 +01:00
John Oleksowicz
8c0854ab47 Consider image src when calculating campaignIds 
MAILPOET-5034
 2023-02-26 15:20:48 +01:00
John Oleksowicz
49c85c05ed Move campaignId generation to more logical place 
MAILPOET-5034
 2023-02-26 15:20:48 +01:00
John Oleksowicz
a6824cce36 Add tests for campaignId generation 
[MAILPOET-5033]
 2023-02-26 15:20:48 +01:00
John Oleksowicz
fc8436ba74 Provide campaignId to sending methods via meta 
[MAILPOET-5033]
 2023-02-26 15:20:48 +01:00
John Oleksowicz
0435c09c53 Calculate and store campaign IDs on sending queues 
[MAILPOET-5033]
 2023-02-26 15:20:48 +01:00
Brezo Cordero
49b2f5528f Remove Migration class 
Remove from container, test factory and PHPStan baselines.

[MAILPOET-4478]
 2023-01-23 15:35:50 +01:00
Rostislav Wolny
78446d174a Fix quotes in a queries processed by $wpdb 
These queries failed when ANSI_QUOTES mode is enabled
[MAILPOET-4887]
 2022-12-12 13:59:09 +01:00
Jan Jakes
926620e8f8 Ignore strict types rule in all existing files that don't have it 
[MAILPOET-2688]
 2022-11-29 15:04:09 +01:00
David Remer
2557171953 Fix assert() in lib 
[MAILPOET-4258]
 2022-11-25 14:32:34 +01:00
Sam Najian
9204f37560 Remove redundant injection 
[MAILPOET-4703]
 2022-11-11 09:21:30 +01:00
Sam Najian
50b613365f Make sure one-click unsubscribe url won't redirect internally 
[MAILPOET-4703]
 2022-11-11 09:21:30 +01:00
David Remer
2298b5b061 Be more restrictive when deleting a queue task 
getNewsletterFromQueue() has too many conditions under which it returns null. Therefore we can not rely on that method when we wont to delete running tasks with no associated newsletter.
[MAILPOET-4708]
 2022-10-10 17:13:17 +02:00
David Remer
307989a0c6 Delete task when no newsletter was found 
When no corresponding newsletter was found the task can be deleted. The behavior
before meant that such a task would remain forever in the database with the
status 'running'.

[MAILPOET-4699]
 2022-10-06 12:06:13 +02:00
Rodrigo Primo
54ea394f82 Deprecate filter as part of a Doctrine refactor 
This commit deprecates the filter
mailpoet_sending_newsletter_render_after and replaces it with
mailpoet_sending_newsletter_render_after_pre_process. This was necessary
because as part of a Doctrine refactor one of the parameters passed to
the old filter changed from a Newsletter model to a Newsletter entity.

[MAILPOET-4680]
 2022-10-04 14:41:00 +02:00
Rodrigo Primo
d39440f1dc Refactor Newsletter::preProcessNewsletter() to use Doctrine 
This commit also removes almost all the usages of the old Newsletter
model from NewsletterTest.

[MAILPOET-4680]
 2022-10-04 14:41:00 +02:00
Rodrigo Primo
095cddc67e Change Posts::getAlcPostsCount() to use Doctine instead of Paris 
[MAILPOET-4680]
 2022-10-04 14:41:00 +02:00
Jan Lysý
58d32a68fb Use processedAt from the correct model 
[MAILPOET-4685]
 2022-09-29 15:19:09 -03:00
Rodrigo Primo
2c159b1694 Document the types of two SendingQueue properties that were undocumented 
It was also necessary to add an if condition to check the type of a
variable before calling one of the methods of one of the documented
properties.

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
f578f3f16a Remove method Tasks\Newsletter\getNewsletterSegments() 
This method was used only once inside SendingQueue and it can be
replaced by NewsletterEntity::getSegmentIds() to simplify the code.

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
d79cecbef2 Replace some of the uses of SendingQueue model with Doctrine 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
ccbdbd3e93 Refactor getNewsletterFromQueue() to use Doctrine instead of Paris 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
4ca656a217 Rename $queue to $sendingTask 
Doing this for consistency and to make it more clear that $sendingTask
contains an instance of \MailPoet\Tasks\Sending and not an instance of
\MailPoet\Models\SendingQueue.

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
a7d0ad6568 Set the type of all the Newsletter parameters that use the Sending class 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
168ce20a40 Use NewsletterEntity instead of Newsletter model in Links 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
9a92068d5b Refactor Newsletter to use Doctrine instead of the Newsletter model 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
f6afe987c8 Add return type declaration for Newsletter::prepareNewsletterForSending() 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
68c3277195 Replace Subscriber model with Doctrine in Tasks\Newsletter 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
fd0acbd6cf Refactor Newsletter to use Doctrine instead of the NewsletterSegment model 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
05664a0c6a Refactor markNewsletterAsSent() to use Doctrine instead of Paris 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
538647946e Refactor GATracking to use Doctrine instead of Paris 
The test class was also refactored.

[MAILPOET-4592]
 2022-09-14 10:38:01 +02:00
Jan Lysý
f9261dbeb4 Use constants from ScheduledTaskEntity 
[MAILPOET-4309]
 2022-08-31 13:42:21 +02:00
Jan Lysý
fecb26b3b5 Replace usage ScheduledTask::touchAllByIds with repository 
[MAILPOET-4309]
 2022-08-31 13:42:21 +02:00
Jan Lysý
5dfda9f3e2 Move task type const from entity to worker 
[MAILPOET-4366]
 2022-08-19 15:11:23 +02:00
Jan Lysý
bf74a506b7 Replace using Sending::getRunningQueues 
[MAILPOET-4366]
 2022-08-19 15:11:23 +02:00
David Remer
97e160bf67 Fix WordPress.WP.I18n.MissingArgDomain 
[MAILPOET-4524]
 2022-08-09 13:23:16 +02:00
David Remer
b05e6d414c Remove WP\Functions::__ and other translate functions 
Under the new sniffer rules, those functions produce errors and, when those methods
are used, the sniffer can not properly be applied.

[MAILPOET-4524]
 2022-08-09 13:23:16 +02:00
Rodrigo Primo
261f2eaa25 Replace Paris models with Doctrine entities in Shortcodes 
[MAILPOET-4364]
 2022-08-04 10:55:03 +02:00
Jan Lysý
155445b313 Remove old model from SendingQueue Migration 
[MAILPOET-4358]
 2022-08-01 13:09:20 +02:00
Rostislav Wolny
8d4799b050 Fix models check conditions in sending queue 
[MAILPOET-4511]
 2022-07-29 10:33:05 +02:00
Rostislav Wolny
5042cdd15e Refactor fetching newsletter options in SendingQueue using doctrine 
[MAILPOET-4511]
 2022-07-29 10:33:05 +02:00
Rodrigo Primo
ae13fcc771 Make sure $metas[] is always set for all subscribers in the foreach loop 
See https://github.com/mailpoet/mailpoet/pull/4247#pullrequestreview-1050167548

[MAILPOET-4379]
 2022-07-27 08:48:15 +02:00
Rodrigo Primo
932512b720 Replace Paris models with Doctrine entities in MetaInfoTest 
In the process it was necessary to change the signature of the method
\MailPoet\Mailer\MetaInfo::getNewsletterMetaInfo() to accept a
SubscriberEntity instead of a Subscriber model and also change
\MailPoet\Cron\Workers\SendingQueue\SendingQueue::processQueue() as it
calls getNewsletterMetaInfo().

Doing this was straightforward, but changing the test class for
SendingQueue was a bit more involved. In particular, the test
SendingQueueTest::testItEnforcesExecutionLimitsAfterQueueProcessing().

This test is a bit brittle and was creating Subscriber models without
saving them to the database with invalid statuses and sources. Switching
getNewsletterMetaInfo() to use entities, while
SendingQueue::processQueue() still uses models, meant that it was
necessary to save the subscribers to the database. Because of this, it
was not possible anymore to use invalid statuses and sources, and
thus, the test changed a bit.

[MAILPOET-4379]
 2022-07-27 08:48:15 +02:00
Sam Najian
fb49ce5ac4 Adjust usage of Renderer::render in SendingQueue\Tasks::Newsletter 
[MAILPOET-4360]
 2022-07-14 13:13:47 +02:00
Jan Lysý
1310e5afec Disable marking subscribers as processed on error 
[MAILPOET-4200]
 2022-04-25 10:58:12 +02:00
Rostislav Wolny
789385b0c4 Refactor mailerInstance property to mailerMethod 
Naming mailerInstance was confusing since
it is not instance of Mailer class but instance of MailerMethod.
[MAILPOET-4115]
 2022-04-11 16:54:38 +02:00
Rostislav Wolny
d4a8315933 Use mailerFactory in SendingQueue Mailer task 
[MAILPOET-4115]
 2022-04-11 16:54:38 +02:00
David Remer
53fc49d1eb Simplify phpcs:disable comments 
Additionally this commit contains a conversion from %d to %s in a query

[MAILPOET-4219]
 2022-04-04 17:12:33 +02:00
David Remer
cb55cae1b2 Escape SQL queries following wp org sniffs 
[MAILPOET-4129]
 2022-04-04 17:12:33 +02:00