Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity
22,617 Commits 3 Branches 547 Tags
246a10f058dfbc58ceb51e43b32f62249c1fb8da
Commit Graph

80 Commits

Author SHA1 Message Date
 Ján Mikláš
d5f1980c63 Update integration tests 
[MAILPOET-6182]
 2024-09-02 12:53:26 +02:00
Rostislav Wolny
5fdba0e170 Replace current_time usage in tests 
[MAILPOET-6142]
 2024-08-19 15:29:42 +02:00
Rostislav Wolny
3214a86ee2 Add empty email check also for multisite registration 
[MAILPOET-6188]
 2024-08-16 09:35:45 +02:00
Rostislav Wolny
08ac80774c Add test for the registration class 
[MAILPOET-6188]
 2024-08-16 09:35:45 +02:00
Jan Jakes
ee6e22efa3 Regenerate CAPTCHA phrase using a custom request with cachebust to avoid caching 
[MAILPOET-6038]
 2024-08-05 13:28:52 +02:00
Jan Jakes
38f7d97283 Compress captcha audio files more aggressively 
This reduces the size of the files combined from 224KB to 64KB.

The command used was:

for f in originals/*.mp3; do ffmpeg -i "$f" -c:a libmp3lame -af "highpass=f=200, lowpass=f=15000, afftdn=nf=-30, anlmdn=s=1, rubberband=pitch=1.05, volume=1.5" -b:a 8k -ac 1 -ar 8000 "${f##*/}"; done

[MAILPOET-6038]
 2024-08-05 13:28:52 +02:00
Jan Jakes
fad5e629af Simplify renderAudio and renderImage 
[MAILPOET-6038]
 2024-08-05 13:28:52 +02:00
Jan Jakes
71d7f46718 Make captcha session stateless 
[MAILPOET-6038]
 2024-08-05 13:28:52 +02:00
Jan Jakes
10ef9ffce5 Initialize CAPTCHA session and phrase on page load 
Previously, a new CAPTCHA phrase was generated when the CAPTCHA image
or audio was requested "again". For that, a counter needed to be stored in the
session, and since image and audio were fetched in parallel, any of them could
initialize the new CAPTCHA phrase. The problem appeared when they both
generated a new phrase at the same time. This resulted in a race condition,
where the image and audio had different CAPTCHA phrases and some users
weren't able to pass the CAPTCHA at all. This was occuring especially in Safari,
(maybe somehow due the type dectection range "preflight" request).

Now, the phrase is initialized on the CAPTCHA page load (and reloaded via AJAX),
so we don't need to store any additional metadata, apart from the phrase itself.

[MAILPOET-6038]x
 2024-08-05 13:28:52 +02:00
Brezo Cordero
eb6cd87133 Add a limit to timeout in throttling function 
to prevent integer overflows

[MAILPOET-6103]
 2024-06-06 09:17:52 +03:00
Mike Jolley
0d6fe6e5eb Apply rules to tests and tasks 2024-03-21 16:57:59 +01:00
Rodrigo Primo
8bc4d78c68 Replace expect()->regExp() with verify()->stringMatchesRegExp() 
codeception/verify 2.1 removed support for expect()->regExp() so we need
to replace it with verify()->stringMatchesRegExp().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
a54e1f3c01 Replace expect()->greaterOrEquals() with verify()->greaterThanOrEqual() 
codeception/verify 2.1 removed support for expect()->greaterOrEquals() so we need
to replace it with verify()->greaterThanOrEqual().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
c1c59fe392 Replace expect()->lessOrEquals() with verify()->lessThanOrEqual() 
codeception/verify 2.1 removed support for expect()->lessOrEquals() so we need
to replace it with verify()->lessThanOrEqual().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
fa9236d8c9 Replace expect()->greaterThan() with verify()->greaterThan() 
codeception/verify 2.1 removed support for expect()->greaterThan() so we need
to replace it with verify()->greaterThan().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
525495409c Replace expect()->notNull() with verify()->notNull() 
codeception/verify 2.1 removed support for expect()->notNull() so we need
to replace it with verify()->notNull().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
9b56fdc688 Replace expect()->count() with verify()->arrayCount() 
codeception/verify 2.1 removed support for expect()->count() so we need
to replace it with verify()->arrayCount().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
e4136fee8c Replace expect()->isEmpty() with verify()->empty() 
codeception/verify 2.1 removed support for expect()->isEmpty() so we need
to replace it with verify()->empty().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
5bc5b5ebd2 Replace expect()->notEmpty() with verify()->notEmpty() 
codeception/verify 2.1 removed support for expect()->notEmpty() so we need
to replace it with verify()->notEmpty().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
00c5250cff Replace expect()->notEquals() with verify()->notEquals() 
codeception/verify 2.1 removed support for expect()->notEquals() so we need
to replace it with verify()->notEquals().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
0d2f6e0776 Replace expect()->stringContainsString() with verify()->stringContainsString() 
codeception/verify 2.1 removed support for expect()->stringContainsString() so we need
to replace it with verify()->stringContainsString().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
709be1d541 Replace expect()->null() with verify()->null() 
codeception/verify 2.1 removed support for expect()->null() so we need
to replace it with verify()->null().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
997f635d4a Replace expect()->false() with verify()->false() 
codeception/verify 2.1 removed support for expect()->false() so we need
to replace it with verify()->false().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
9adbf81a78 Replace expect()->true() with verify()->true() 
codeception/verify 2.1 removed support for expect()->true() so we need
to replace it with verify()->true().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
afe378ba22 Replace expect()->equals() with verify()->equals() 
codeception/verify 2.1 removed support for expect()->equals() so we need
to replace it with verify()->equals().

[MAILPOET-5664]
 2023-10-24 08:58:22 +03:00
Rodrigo Primo
b98a17bc43 Remove remaining uses of Subscriber model from BuiltInCaptchaValidatorTest 
[MAILPOET-5361]
 2023-05-30 11:16:46 -05:00
Jan Lysý
c711eac7f4 Update custom fields on confirmation when are stored in unconfirmed data 
[MAILPOET-5246]
 2023-05-03 11:31:24 +02:00
John Oleksowicz
376dca1098 Remove unnecessary truncating 
MAILPOET-5145
 2023-04-07 12:11:12 -05:00
John Oleksowicz
cd0b795ac8 Extract customer creation/cleanup 
This also ensures that cleanup always runs after all integration tests

MAILPOET-5145
 2023-04-07 12:11:12 -05:00
John Oleksowicz
c75bc388c9 Remove unnecessary cleanup code 
MAILPOET-5145
 2023-04-07 12:11:12 -05:00
John Oleksowicz
57eb438eb8 Don't assume auto increment of 1 
MAILPOET-5145
 2023-04-07 12:11:12 -05:00
David Remer
b17a9cb4ae Add test to ensure HTTP_RANGE headers do not reload captcha 
[MAILPOET-5032]
 2023-02-08 13:08:09 +01:00
Jan Lysý
eb53973799 Remove logEntity cleanup 
[MAILPOET-4639]
 2023-01-09 15:23:48 +01:00
Jan Lysý
e02b631172 Add log entities cleanup 
[MAILPOET-4104]
 2023-01-09 15:23:48 +01:00
Sam Najian
9036b210a0 Add test for click stat recording for 1-click 
[MAILPOET-4862]
 2022-12-07 10:52:07 +01:00
Sam Najian
f337ac388b Fix wrong assertions in PagesTest 
[MAILPOET-4862]
 2022-12-07 10:52:07 +01:00
Jan Jakes
d66fbb1c20 Fix confirmed IP value in tests 
[MAILPOET-2688]
 2022-11-29 15:04:09 +01:00
Jan Jakes
82aeb89854 Use strict types in tests 
[MAILPOET-2688]
 2022-11-29 15:04:09 +01:00
David Remer
7db40b27b5 Fix errors automatically with phpcbf 
[MAILPOET-4850]
 2022-11-28 22:54:13 +03:00
Sam Najian
3e756bfadd Add test to assert correct unsubscription method is saved 
[MAILPOET-4733]
 2022-11-25 14:51:57 +01:00
Sam Najian
735d33d05b Add method of tracking when tracking unsubscriptions 
[MAILPOET-4733]
 2022-11-25 14:51:57 +01:00
David Remer
d2ec7bba42 Replace instance_of asserts in integration tests 
[MAILPOET-4258]
 2022-11-25 14:32:34 +01:00
David Remer
5e0e89408c Test CaptchaFormRenderer 
[MAILPOET-4203]
 2022-11-24 09:20:39 +01:00
David Remer
4832771185 Refactor the captcha system 
The current Captcha class has a lot of responsibilities. It renders the captcha
image, can check if a certain captcha type is a Google captcha, if a captcha is
required for a certain email. The SubscriberSubscribeController is not only in
charge of "controlling" the subscription process but also validates, whether a
captcha is correct or not. This architecture made it difficult to extend the
functionality and introduce the audio captcha feature.

Therefore this commit refactors the captcha architecture and tries to seperate
the different concerns into several classes and objects. Validation is now done
by validators.

The CaptchaPhrase now is in charge of keeping the captcha phrase consistent
between the image and the new audio, so that you can renew the captcha and both
captchas are in sync.

[MAILPOET-4514]
 2022-11-24 09:20:39 +01:00
David Remer
7fb8d64628 Rename CaptchaRenderer to CaptchaFormRenderer 
[MAILPOET-4203]
 2022-11-24 09:20:39 +01:00
Oluwaseun Olorunsola
8b922681b6 Use boolean instead of integer for displayInManageSubscriptionPage column 
MAILPOET-4669
 2022-11-21 15:21:29 +01:00
Oluwaseun Olorunsola
c54a5213b3 Update tests 
MAILPOET-4669
 2022-11-21 15:21:29 +01:00
Jan Jakes
725e0ecb00 Remove automation feature flag 
[MAILPOET-4788]
 2022-11-14 12:35:29 +02:00
David Remer
87ced17813 Use submit button label of form for captcha submit button 
[MAILPOET-4496]
 2022-09-14 11:44:09 +02:00
Jan Lysý
381565fc1f Improve integration ManageTest class 
[MAILPOET-4350]
 2022-08-01 13:28:57 +02:00