Commit Graph

14 Commits

Author SHA1 Message Date
Veljko
58a7c93a52 Add missing step to go to segments page 2024-05-23 11:01:27 +02:00
Veljko
d9df7cc01d Fix flaky acceptance test in segments
[MAILPOET-6076]
2024-05-23 11:01:27 +02:00
John Oleksowicz
28ca417261 Fix link casing and remove no longer needed check
MAILPOET-5395
2024-04-24 12:59:37 +02:00
John Oleksowicz
bcde8bdd51 Fix other selector issues in segment tests
MAILPOET-5395
2024-04-24 12:59:37 +02:00
Rodrigo Primo
f5a0b67e9f Fix message displayed when a new segment is created
There was a bug and the code was displaying `Segment succesfully
updated!` instead of `Segment succesfull added!` when the user created a
new segment.

This commit fixes this problem. The issue was that
Number(match.params.id) returns `NaN` instead of `undefined` when there
is no segment ID. So the check inside handleSave() was always calling
messages.onUpdate().

Since the segment ID was never used. I replaced it with a boolean and
renamed the variable from `segmentId` to `isNewSegment` to better
indicate how it is used.

[MAILPOET-5615]
2023-09-28 22:22:50 +03:00
Rostislav Wolny
d20efc5c16 Update acceptance tests after updating PHPUnit
[PREMIUM-191]
2023-09-22 16:20:11 +02:00
Rodrigo Primo
aecc3440cf Update acceptance tests to consider new segment templates page
[MAILPOET-5394]
2023-09-18 14:43:49 +02:00
Veljko
3c142e6da9 Fix flakiness in CreateSegmentEmailAbsoluteCount
[MAILPOET-5008]
2023-08-24 15:28:46 +03:00
Rodrigo Primo
3782fb4bdd Update acceptance tests to reflect separating segments and lists
Segments and lists were separated into different pages in a previous
commit. This commit updates the acceptance tests to reflect this change.

[MAILPOET-5392]
2023-07-12 18:46:08 +02:00
Veljko
5e016b2b17 Improved the test for segment newsletter stats
[MAILPOET-5328]
2023-07-05 12:22:49 +03:00
 Ján Mikláš
fb340b807c Rename "# of" to "number of" in segments
[MAILPOET-5397]
2023-06-22 10:12:21 +02:00
Jan Jakes
82aeb89854 Use strict types in tests
[MAILPOET-2688]
2022-11-29 15:04:09 +01:00
John Oleksowicz
039ce50237 No waiting for easy-to-miss text in tests
If the segment count calculation is fast, the
text "Calculating segment size…" might only
show for a split second.

This was causing the tests to fail
intermittently because $i->waitForText was
missing the text.

For whatever reason, adding a 2 second delay
between the button clicks and the waiting for
text step apparently made this failure much more
likely, and it was also more likely in CircleCI
than locally.

[MAILPOET-4018]
2022-03-07 16:03:55 +01:00
Jan Jakes
9f790efbf0 Move plugin files to a subfolder
[MAILPOET-3988]
2022-01-18 15:30:22 +01:00