Commit Graph

61 Commits

Author SHA1 Message Date
81e0772459 Refactor MPAPI subscribeToLists to Doctrine
[MAILPOET-3820]
2021-12-15 11:51:12 +01:00
d39d09dd72 Remove calls to Subscriber::setError() from ConfirmationEmailMailer
This commit is part of a task to replace Paris with Doctrine in the
class ConfirmationEmailMailer. Specifically, it removes two calls to
Subscriber::setError() inside ConfirmationEmailMailer::sendConfirmationEmail().

setError() was used to define an error message that was used only in one
of the instances where sendConfirmationEmail() is called
(API::subscribeToLists()). setError() was replaced with code that throws
an exception when there is an error. Thus it was necessary to change all
the places where ConfirmationEmailMailer::sendConfirmationEmail() is
called to handle the exception.

In some cases, there are some oddities as sendConfirmationEmail() can
return false or throw an exception in case of an error and calling code
must account for both. I decided to settle with this approach as
refactoring the rest of this method to use exceptions instead of
returning false seemed outside of the scope of this task.

[MAILPOET-3815]
2021-12-13 16:03:07 +01:00
6c05b3eaf0 Pass SubscriberEntity to sendConfirmationEmail() and sendConfirmationEmailOnce()
This commit changes the methods sendConfirmationEmail() and
sendConfirmationEmailOnce() to accept as the first parameter an instance
of SubscriberEntity instead of the old model Subscriber. It also updates
all the places where those two methods are called.

[MAILPOET-3815]
2021-12-13 16:03:07 +01:00
518c33187f Move custom fields methods to a separate file
[MAILPOET-3628]
2021-10-04 12:37:46 +02:00
bef34484ae Use the shortcut for translation function
[MAILPOET-3628]
2021-10-04 12:37:46 +02:00
349918e45d Allow re-subscribe functionality in third party API
[MAILPOET-3307]
2021-02-03 11:01:38 +01:00
945b46d9d1 Fix double sending notifications
[MAILPOET-2864]
2020-04-30 10:33:58 +02:00
8c848cfa28 Convert property names to camel case
[MAILPOET-1796]
2020-01-14 15:22:42 +01:00
54549ff037 Convert variable names to camel case
[MAILPOET-1796]
2020-01-14 15:22:42 +01:00
43df66d162 Add public keyword to methods
[MAILPOET-2413]
2019-12-26 18:09:45 +03:00
wxa
ac9c250b55 Collect subscriber IPs for 3rd party API subscriptions [MAILPOET-2575] 2019-12-16 18:06:37 +00:00
ade1cc4d8e Autofix alphabetically sorted use statements
[MAILPOET-2409]
2019-10-01 14:29:30 +01:00
1b5b9d89ff Autofix namespace declaration spacing
[MAILPOET-2409]
2019-10-01 14:29:30 +01:00
01a0fe96c4 Remove no longer necessary checks
[MAILPOET-1948]
2019-09-12 13:59:32 +02:00
c90a2e41a1 Use separate scheduler for welcome emails
[MAILPOET-2321]
2019-08-29 13:55:49 -04:00
c5ee2baaa2 Fix missing arguments in addSubscriber API method
[MAILPOET-2226]
2019-07-29 15:51:44 -04:00
b52b943c97 Prevent sending notification twice
[MAILPOET-2131]
2019-06-20 11:01:48 -04:00
f17e7251c3 Use constants for exception codes
[MAILPOET-2107]
2019-06-06 11:22:48 -04:00
f130c8d17b Add new api exception
[MAILPOET-2107]
2019-06-06 11:22:48 -04:00
c15c693507 Add method for creating custom fields in API
[MAILPOET-2041]
2019-05-30 13:03:33 -04:00
c4a086ba29 Add an option for sending admin notification
[MAILPOET-2042]
2019-05-29 09:58:18 -04:00
79bda9756e Return all information in getSubcriberFields response
[MAILPOET-2099]
2019-05-28 10:39:02 -04:00
352a4b82e7 Accept only whitelisted fields in addList API
[MAILPOET-2093]
2019-05-27 08:32:24 -04:00
97dc68c655 Accept only whitelisted fields in addSubscriber API
[MAILPOET-2093]
2019-05-27 08:32:24 -04:00
c4d8a8137a Refactor $segment_ids to $list_ids to unify naming
[MAILPOET-2035]
2019-05-27 06:10:46 -04:00
85e1976312 Allow only default segments to be used for subscription
[MAILPOET-2035]
2019-05-27 06:10:46 -04:00
879a36e0f2 Rename translation functions 2019-05-21 09:04:00 -04:00
5da7110eb6 Use short array syntax
[MAILPOET-2090]
2019-05-20 10:18:45 -04:00
e479aecdc0 Send confirmation email also within subscribeToLists
[MAILPOET-1992]
2019-05-06 11:13:49 -04:00
3e66e9e1dd Fix phpstan level 6
[MAILPOET-1969]
2019-04-10 09:55:13 -04:00
0a436087e1 Replace all WP function calls 2019-03-07 08:30:14 -05:00
wxa
2f487fd300 Inject subscribe() action instead of calling it statically [MAILPOET-1825] 2019-02-21 09:51:53 -05:00
3ee58aea10 Add space between if and ‘(‘
[MAILPOET-1791]
2019-02-13 08:26:27 -05:00
ebbdec5ebd Add space between foreach and ‘(‘
[MAILPOET-1791]
2019-02-13 08:26:27 -05:00
wxa
5bf968fbc6 Address PR review remarks [MAILPOET-1721] 2019-01-22 12:25:59 +03:00
wxa
a4ff9822ad Add WooCommerce customers list [MAILPOET-1721] 2019-01-17 21:42:57 +03:00
a42787d10d Refactor MP v1 API to obtain services via constructor
[MAILPOET-1637]
2018-11-15 09:03:43 +01:00
wxa
6b6f488f1e Schedule welcome email only if subscriber is confirmed in MPAPI [MAILPOET-1589] 2018-10-16 19:03:44 +03:00
654dd1e8d0 Rename Send classes
[MAILPOET-1522]
2018-10-15 13:06:19 +02:00
40c19cd5d8 Fix parameters
[MAILPOET-1522]
2018-10-15 12:56:15 +02:00
70debcc828 Refactor confirmation email sending
Aspect mock stopped working for me so I had to create a separate service
for sending confirmation emails.

[MAILPOET-1522]
2018-10-11 13:39:39 +02:00
4249c7a2cb Send an email notification on new subscriber
[MAILPOET-1522]
2018-10-11 10:23:06 +02:00
ac33e11c60 Reject requests without mandatory custom fields
We need to make sure subscribers cannot be created without custom fields
Users require GDPR consent and we need to make sure there are no way to
create a subscriber without mandatory custom fields

[MAILPOET-1405]
2018-08-21 15:03:08 +02:00
71fed489ec Improve error reporting in API
[MAILPOET-1290]
2018-06-12 10:32:20 +01:00
582f241ea4 Add source to subscribed entered in admin
[MAILPOET-1377]
2018-05-14 13:55:47 +01:00
78f9fea2b0 Sends welcome notifications when subscribing to lists via MP's API
[MAILPOET-1295]
2018-03-15 13:04:30 +00:00
d7bf6addf1 Fixes error due to throwing exception inside array_map 2017-11-14 09:58:01 -05:00
087f2ebcdd Uses a built-in method to handle plural exception cases
Implements check for empty segments
Implements check for WP segment when unsubscribing
2017-11-13 10:12:50 -05:00
3d2a63f319 Adds methods to unsubscribe from list(s) 2017-11-13 10:12:50 -05:00
54dd3b621a Improves error messages, cleans up code 2017-11-13 10:11:07 -05:00