Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity
10,452 Commits 3 Branches 547 Tags
8c3153e205bb48a83402b50cdfcb15c330ee22c6
Commit Graph

2831 Commits

Author SHA1 Message Date
fred
c984ac7a66 New: Display the number of data to migrate 
Several fixes following the code review:
- For styles we use Stylus. (http://stylus-lang.com/)
  In Stylus styles curly brackets and terminating semicolons are unnecessary. Indentation is sufficient to denote blocks of styles
  You can also use variables to avoid duplication (e.g. mentioning the same color multiple times)
  Vendor prefixes are not necessary. We use the Nib mixin for Stylus to handle those (http://tj.github.io/nib/)
  => DONE

- `admin.js` bundle is included on all admin pages, so we need to ensure that migration fires only on the migration page and nowhere else.
  You can even create a separate bundle only for migration files, as they won't be necessary on other admin pages.
  => DONE

- MP2MigratorAPI => MP2Migrator endpoint would be just as fine
  => DONE

- For storing migration files, you can use the `Env::$temp_path` path
  => DONE

- `proposeMigration()` the method name disagrees with the comment.
  Comment suggests it tests if migration can be or should be performed
  Method name suggests that it proposes doing the migration (to the user?) - not very clear
  => DONE: the new name is isMigrationNeeded()

  And not only does it test, it may also update the `mailpoet_migration_complete` option, which is confusing and is an unexpected side-effect.
  => DONE

  The migration class itself `MP2Migrator` shouldn't even care about _GET, _REQUEST or _POST arguments. It should only work with what is passed to it.
  => DONE

- In views, please make sure all human-friendly texts use WP's gettext functions for translations (e.g. __('text'))
=> DONE
 2017-06-12 13:12:58 +02:00
fred
a1ea56f505 Coding standard fixes 2017-06-12 13:12:58 +02:00
fred
dd7f959731 Migration from Mailpoet 2 to Mailpoet 3 : phase 0 
Interface
 2017-06-12 13:12:57 +02:00
stoletniy
502250a1a3 Merge pull request #930 from mailpoet/import_update 
Adjusts WP's email validation regex to JS's syntax [MAILPOET-943]
 2017-06-12 11:10:38 +03:00
Vlad
48e37f6797 Adjusts WP's email validation regex syntax to JS 2017-06-11 12:31:54 -04:00
Pavel Dohnal
152edda03f Add unit test 
[MAILPOET-896]
 2017-06-08 16:58:30 +01:00
Pavel Dohnal
93ef1d0197 Fix ALC buttons settings when updating all buttons 
[MAILPOET-896]
 2017-06-08 10:19:24 +01:00
stoletniy
4f722ecd8a Add hooks for actions row for standard and notification history newsletter types [PREMIUM-13] 2017-06-07 12:30:50 +03:00
stoletniy
478359f9ff Add minor improvements to stats [PREMIUM-13] 2017-06-07 12:30:48 +03:00
Tautvidas Sipavičius
afa06342a5 Update link for the Premium page 2017-06-07 12:30:40 +03:00
stoletniy
03d2ff5f26 Make use of returned promises for parallel requests loading modal [MAILPOET-890] 2017-06-07 12:30:40 +03:00
stoletniy
58faf64a5c Add a Premium page link to bounced subscribers listing [MAILPOET-887] 2017-06-07 12:30:39 +03:00
Vlad
65ff14a81d Adds hook to modify newsletter actions 2017-06-07 12:30:38 +03:00
stoletniy
7aa0f21d11 Rework 'Send with...' tab UI, make a single license key field [MAILPOET-890] 2017-06-07 12:30:37 +03:00
Vlad
3e988b7a56 Removes welcome notification creation component and routes 
Updates welcome notification template
 2017-06-07 12:30:36 +03:00
Vlad
ce3eb06924 Prevents welcome emails from being created 
Adds filter to modify available email types
 2017-06-07 12:30:35 +03:00
stoletniy
b8904c2d51 Merge pull request #914 from mailpoet/subscriber_email_validation_logic_update 
Uses WP's function to validate subscriber email address [MAILPOET-925]
 2017-06-05 19:25:53 +03:00
Vlad
7f566fb672 Adds client-side check for invalid characters in email addresses 
Adds server-side validation of email addresses using WP's is_email()
 2017-06-04 18:48:11 -04:00
Vlad
8314b05fce Displays "not yet sent" as a sent date when post notification has not 
yet been sent/being sent
 2017-06-01 14:58:25 -04:00
Vlad
fd33cc7068 Uses parent newsletter's subject when queue's rendered subject is not 
available
 2017-06-01 14:26:50 -04:00
Alexey Stoletniy
94f91afce1 Bring back list buttons to TinyMCE toolbar [MAILPOET-906] 2017-05-08 21:01:18 +03:00
Tautvidas Sipavičius
e1991deafd Merge pull request #876 from mailpoet/manage_subscription_shortcode_fix 
Depreciates and removes certain link shortcodes [MAILPOET-895]
 2017-04-27 15:51:26 +03:00
stoletniy
36e4bf468d Merge pull request #871 from mailpoet/editor_marionette 
Upgrade Marionette version in newsletter editor [MAILPOET-892]
 2017-04-27 11:19:46 +03:00
Vlad
b02e9f5ab3 Depreciates and removes server-side rendering of subscription_unsubscribe, 
subscription_manage and newsletter_view_in_browser
 2017-04-26 17:47:52 -04:00
Tautvidas Sipavičius
cc2fdbe5be Merge pull request #864 from mailpoet/campaign_stats 
Add detailed stats page support in Free, change stats style [PREMIUM-1] [MAILPOET-877]
 2017-04-26 14:30:51 +03:00
stoletniy
ab0d573a66 Merge pull request #873 from mailpoet/import_results_fix 
Keeps track of the number of updated/created subscribers over multiple server requests [MAILPOET-894]
 2017-04-25 18:26:38 +03:00
Vlad
26c582b19f Keeps track of the number of updated/created subscribers over multiple 
server requests
 2017-04-25 11:00:52 -04:00
Alexey Stoletniy
3bc53f9f09 Remove Premium-only styles from Free, cleanup styles [PREMIUM-1] 2017-04-25 12:46:05 +03:00
Alexey Stoletniy
bb220baf6a Add names to constants, rename vars for clarity [MAILPOET-877] 2017-04-25 12:46:04 +03:00
Alexey Stoletniy
121a78f42a Update an open rate improvement KB link URL [MAILPOET-877] 2017-04-25 12:46:04 +03:00
Alexey Stoletniy
4257aa634e Don't show green box and KB link in stats for welcome emails [MAILPOET-877] 2017-04-25 12:46:03 +03:00
Alexey Stoletniy
95ff83557f Add a green box in stats for recently sent newsletters, add help KB link [MAILPOET-877] 2017-04-25 12:46:03 +03:00
Alexey Stoletniy
e9070de9c4 Add badges to stats in a newsletter listing, change stats style [PREMIUM-1] [MAILPOET-877] 2017-04-25 12:45:52 +03:00
Alexey Stoletniy
72aa087411 Localize formatting to 1 decimal [PREMIUM-1] 2017-04-25 12:45:50 +03:00
Alexey Stoletniy
fbc0a3ad8d Add detailed stats page support in Free [PREMIUM-1] 2017-04-25 12:45:49 +03:00
Tautvidas Sipavičius
0360f16dc8 Merge pull request #865 from mailpoet/api_versioning 
Adds versioning to our public API [MAILPOET-881]
 2017-04-25 12:07:17 +03:00
Tautvidas Sipavičius
509ec7d3d3 Fix posts block settings to not use deprecated CompositeView 2017-04-24 18:00:23 +03:00
Tautvidas Sipavičius
aa2416f353 Simplify settings views to use methods defined in base settings view 2017-04-24 18:00:23 +03:00
Tautvidas Sipavičius
167a605658 Switch Container block view to use methods defined by base view 2017-04-24 18:00:23 +03:00
Tautvidas Sipavičius
592f11bd5f Fix App activation calls, fix block insertion animations 2017-04-24 18:00:23 +03:00
Tautvidas Sipavičius
92b128039a Fix displaying placeholder message on empty containers 2017-04-24 18:00:23 +03:00
Tautvidas Sipavičius
5efe611b2d Remove obsolete comments, fix ALC settings 2017-04-24 18:00:23 +03:00
Tautvidas Sipavičius
477e2737b1 Fix sorting of social icons in settings 2017-04-24 18:00:23 +03:00
Tautvidas Sipavičius
dc8bacc27d Fix drag&drop 2017-04-24 18:00:23 +03:00
Tautvidas Sipavičius
0b8c787cda Partially migrate newsletter editor to Marionette 3.x from 2.x 2017-04-24 18:00:23 +03:00
Vlad
6a65ff5e5d Removes default version 
Updates all AJAX requests to include api version
Requires namespaces to have version
Clean up code
 2017-04-19 23:34:40 -04:00
Vlad
b549f83422 Updates form subscription class to use the main API class instead of calling directly API endpoint 
Modifies forms to pass api_version
Modifies forms to pass store form-specific values (e.g., form_id, email) inside a separate data array
 2017-04-19 15:38:16 -04:00
Vlad
a9c80c031f Adds version support to public API 2017-04-19 15:38:16 -04:00
Alexey Stoletniy
405bea3049 Upgrade notice classes from deprecated ones [MAILPOET-733] 2017-04-19 17:11:42 +03:00
Alexey Stoletniy
6954acd0b3 Wrap notice messages containing HTML in a paragraph to avoid broken styles [MAILPOET-733] 2017-04-19 17:11:14 +03:00