Commit Graph

15684 Commits

Author SHA1 Message Date
Sam
c32dc0a372 Revert "Revert "Define BlockPostQuery for nicer args processing for quering""
This reverts commit 62e393a76d.
2022-04-18 11:43:47 +02:00
Sam
319017f09d Revert "Revert "Correctly process sortBy argument when fetching posts""
This reverts commit 6c00969e83.
2022-04-18 11:43:47 +02:00
Sam
fc7313d44b Revert "Revert "Fix failing tests because of un-registered product post type""
This reverts commit fbcfa6db82.
2022-04-18 11:43:47 +02:00
Sam
7631042f3d Revert "Revert "Check post-types validity for requests""
This reverts commit fdb4663ca1.
2022-04-18 11:43:47 +02:00
John Oleksowicz
52855b06d8 Fix indentation
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
6ee13b87df Fix copy/paste mistake
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
f032bedffe Move private method after public methods
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
ff8a2926a8 Avoid unnecessary duplicate call
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
250dd441b4 Add step based validations
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
da144a3778 Include all possibilities for validation
Although not required at the moment, validation could certainly involve
the current step as well as the workflow itself.

[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
7ec1bcccc4 Alphabetize dependencies
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
78352d410d Keep subject entities private
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
cbabaf9e4e Idiomatic way of specifying mixed return type
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
c5065c0d8d Remove unnecessary abstract class
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
253a32413c Add exception messages
I'm leaving these strings untranslated for now because I'm not sure that
 we'll want all of them as-is, and I don't want to have our translators
 translate strings we might not even need.

[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
5227481a42 Revert to a simpler approach
Having separate objects for validation results is unnecessary and overly
 complicated at this point, and we should wait to introduce that kind of
  complexity only when/if it's clearly needed.

[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
d6895ebbc2 More efficient method for checking segment status
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
1f697cea47 Separate instances for objects with state
Segment and Subscriber subjects can be stateful, with specific segments
and subscribers loaded into them, so we should probably get separate
instances of them instead of sharing that state and potentially getting
unexpected behavior.

[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
954b23d151 State-independent validation
We need to be able to validate an action in a workflow in the UI,
outside the context of a specific workflow run, so the validation can't
check things like the specific entities loaded in a subject.

[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
2cce9bf7ad An idea for splitting validation and running
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
70911d2424 Make factory consistent with application code
This makes the subscriber factory match
\MailPoet\Subscribers\SubscriberSegmentRepository::createOrUpdate. Prior
 to this change, calling $subscriber->getSegments() after using this
 factory would always return an empty collection, even after using the
 withSegments method.

[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
d31671f6ea Basic tests for welcome email action
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
66564d3b7d Refactor action to use subjects directly
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
b2f2f2665c Add getValue method to Field
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
69b523171f Initial stab at a welcome email action
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
John Oleksowicz
9e4303e6f6 Fix updatedAt assignment
[MAILPOET-4191]
2022-04-18 09:10:23 +02:00
dependabot[bot]
31828a1cce Bump minimist from 1.2.5 to 1.2.6 in /eslint-config
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-18 08:54:15 +02:00
Rostislav Wolny
2bf3386f45 Alter multisite registration test to check tracking cookie after login
The cookie is not set on wp-activate.php page because on the page
plugins are not loaded (or are loaded only when the plugin is
network active).
See https://core.trac.wordpress.org/ticket/23197

[MAILPOET-4249]
2022-04-15 09:02:18 +02:00
Rostislav Wolny
53eb08f91f Fix SubscriberCookieCest test
I found that container used for WordPress site in acceptance test environment
is not configured to send emails to MailHog and that caused that WP transactional emails were not caught by MailHog.

In this commit I switched sending transaction emails via MailPoet plugin as a workaround.
[MAILPOET-4249]
2022-04-15 09:02:18 +02:00
Jan Jakes
0a1cb0f169 Release 3.87.1 2022-04-14 12:37:17 +02:00
Jan Jakes
bc936ef13e Quote emails when inserting/updating WooCommerce subscribers
[MAILPOET-4248]
2022-04-14 09:41:55 +02:00
Brezo Cordero
cfc7c623e3 Separate insert from update on duplicate
[MAILPOET-4248]
2022-04-14 09:41:55 +02:00
Rostislav Wolny
c72e58bc07 Remove invalid and unused translation slug from template
The slug helpTooltipSendPreview is not used in JS. It is probably just a leftover.
[MAILPOET-4243]
2022-04-13 11:17:33 +02:00
Rostislav Wolny
bd2b064c8f Use empty string when translation is null
In a case when translation is not set correctly in a template
(e.g. 'helpTooltipSendPreview': helpTooltipSendPreview)
it's value might be evaluated as null and trigger a deprecation warning on PHP8.1.
[MAILPOET-4243]
2022-04-13 11:17:33 +02:00
David Remer
fa4d673098 Do not track with Cookie when headers have been sent
[MAILPOET-4060]
2022-04-13 10:48:31 +02:00
David Remer
c33937f3ae Finish user registration in acceptance test
[MAILPOET-4060]
2022-04-13 10:48:31 +02:00
Jan Jakes
d482ba79e7 Add prettier autoformatting commit to .git-blame-ignore-revs
[MAILPOET-4075]
2022-04-12 16:17:05 +02:00
Jan Jakes
ab27eaee2d Autoformat files with prettier
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
2506ff5490 Fix eslint-ignore rules that would be broken by prettier formatting
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
0d8100eb3d Ignore scss files for now (we have exact strict stylelint rules)
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
36114d89bb Add prettier check to CircleCI job
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
ba322bc078 Add Robo commands for prettier
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
269e598511 Fix eslint parsing of newsletter editor tests
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
f6a3b7e958 Run root lint-staged in pre-commit hook
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
02c0b2329a Add prettier to root link-staged config
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
19a363d978 Uninstall lint-staged from mailpoet directory
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
36fc50271f Install lint-staged in the monorepo root
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
69ddf8cbe0 Remove specific eslint formatting rules (prettier formats now)
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
6d9db1cde5 Add prettier ruleset to eslint configuration
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00
Jan Jakes
45acd821a3 Install eslint-config-prettier
[MAILPOET-4075]
2022-04-12 15:38:27 +02:00