Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity
16,297 Commits 3 Branches 547 Tags
a052cdccebc1eb99af7355b83e634d9cc6c5881c
Commit Graph

16297 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jan Jakes
a3ea91adae Add no split rule for workflow validation 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
65927cc281 Add no join rule for workflow validation 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
cafe2ed8a7 Add no cycle rule for workflow validation 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
a3797b976a Add triggers under root rule for workflow validation 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
325418e826 Add no duplicate edges rule for workflow validation 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
11a711e42c Add consisten steps map rule for workflow validation 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
0aa4cd4863 Add no unreachable steps rule for workflow validation 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
e472c00b1c Implerment depth-first pre-order workflow graph walker with plug-in node visitors 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
e3668a8187 Add constant for root step type 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
Jan Jakes
8590cb1409 Rename automation "Validators" namespace to a more universal "Validation" 
[MAILPOET-4629]
 2022-09-23 12:42:03 +03:00
David Remer
a1775dd010 Delete user properly in multisite environment 
[MAILPOET-4666]
 2022-09-22 10:37:25 +02:00
Rodrigo Primo
2c159b1694 Document the types of two SendingQueue properties that were undocumented 
It was also necessary to add an if condition to check the type of a
variable before calling one of the methods of one of the documented
properties.

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
f578f3f16a Remove method Tasks\Newsletter\getNewsletterSegments() 
This method was used only once inside SendingQueue and it can be
replaced by NewsletterEntity::getSegmentIds() to simplify the code.

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
686ee18d16 Replace calls to assert() with Assert::assertInstanceOf() 
Doing this as it was mentioned in the review process of the PR.

For more context see: https://wp.me/pcNwfB-wR

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
d79cecbef2 Replace some of the uses of SendingQueue model with Doctrine 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
ccbdbd3e93 Refactor getNewsletterFromQueue() to use Doctrine instead of Paris 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
4ca656a217 Rename $queue to $sendingTask 
Doing this for consistency and to make it more clear that $sendingTask
contains an instance of \MailPoet\Tasks\Sending and not an instance of
\MailPoet\Models\SendingQueue.

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
a7d0ad6568 Set the type of all the Newsletter parameters that use the Sending class 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
3b9a60c039 Rename NewsletterTest::queue to NewsletterTest::sendingTask 
Doing this for consistency and to better makr that this property
contains an instance of \MailPoet\Tasks\Sending and not an instance
of \MailPoet\Models\SendingQueue.

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
168ce20a40 Use NewsletterEntity instead of Newsletter model in Links 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
9a92068d5b Refactor Newsletter to use Doctrine instead of the Newsletter model 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
f6afe987c8 Add return type declaration for Newsletter::prepareNewsletterForSending() 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
68c3277195 Replace Subscriber model with Doctrine in Tasks\Newsletter 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
fd0acbd6cf Refactor Newsletter to use Doctrine instead of the NewsletterSegment model 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
f4053b0583 Stop using a mock of NewslettersRepository to prevent errors in tests 
This commit changes the SendingQueueTest test class to always use a real
NewslettersRepository object instead of a mock object when instantiating
SendingQueue. This is necessary to prevent false errors in the tests.

Using a mock of the NewslettersRepository in this test class means that
all code inside SendingQueue that uses this repository could behave in
unpredictable ways. As it was happening with a few tests incorrectly
failing after dd6e02e2c16a3a0ef7ad2c12479917e33c312c77:

https://app.circleci.com/pipelines/github/mailpoet/mailpoet/11132/workflows/7b4df151-5a10-48f0-9711-dd590a764880/jobs/192389/tests#failed-test-0

In this case, the code was not changing the status of the newsletter
because findOneById() was returning an empty Newsletter entity instead
of the real Newsletter entity that corresponds to the object in the
database. And, thus, $newsletter->getType() was returning `null` instead
of `standard`.

This problem was already partially addressed in the commit below that
removed some of the usages of the NewslettersRepository mock:

5042cdd15e

[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
05664a0c6a Refactor markNewsletterAsSent() to use Doctrine instead of Paris 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
a4bb49852d Replace Subscriber model with Doctrine in NewsletterTest 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
2137503e09 Replace NewsletterSegment model with Doctrine in NewsletterTest 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
9bf025874c Replace SendingQueue model with Doctrine in NewsletterTest 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rodrigo Primo
cc43b25b7d Replace most of the uses of Newsletter model with Doctrine in NewsletterTest 
[MAILPOET-4363]
 2022-09-21 16:03:21 +02:00
Rostislav Wolny
d0c65b9446 Cleanup MP API test 
[MAILPOET-4295]
 2022-09-21 16:02:23 +02:00
Rostislav Wolny
09f5790120 Move getSubscribers integration test into specific test file 
[MAILPOET-4295]
 2022-09-21 16:02:23 +02:00
Rostislav Wolny
1dac2522c6 Refactor public API getSubscriber to doctrine 
[MAILPOET-4295]
 2022-09-21 16:02:23 +02:00
Rostislav Wolny
3d4ca982a6 Update Woo COT build in test to the latest beta 
[MAILPOET-4572]
 2022-09-21 10:49:10 -03:00
Rostislav Wolny
04b6c4c9d5 Fix flaky SenderDomainCheckCest 
The test failed and on the screenshot there was still a spinner
so I'm trying to improve the stability by increasing the timeout.
[MAILPOET-4556]
 2022-09-21 14:02:45 +02:00
Rostislav Wolny
1713781e5a Attempt to fix ManageSegmentCest flakiness 
This is an addition to previous changes in clicks.
I want to make sure the click on the All filter was successful.
It may give us a better insight into what failed in case the test fails in the future.
[MAILPOET-4556]
 2022-09-21 14:02:45 +02:00
Rostislav Wolny
2464fd9705 Fix NewsletterSendingErrorCest 
This test started failing after updating to newer Chrome.
It seems that the text can no longer be used in the array of attributes when
checking an element.

[MAILPOET-4556]
 2022-09-21 14:02:45 +02:00
Rostislav Wolny
14a2a49c66 Try an alternative fix for flaky clicks on row actions in listing table 
The previous fix with with multiple retries didn't help with the flakiness.
I'm trying to improve the click functionality by hovering on the specific table cell instead of the row
and adding wait for the action link being clickable.
I also tried to make our custom click method more robust.
[MAILPOET-4556]
 2022-09-21 14:02:45 +02:00
Rostislav Wolny
71340f28db Update chrome in acceptance test 
Updating chrome version to improve stability.
[MAILPOET-4556]
 2022-09-21 14:02:45 +02:00
Rostislav Wolny
9160318616 Fix flaky ManageSegmentsCest:viewUserRoleSegmentSubscribers 
The was failing because of slide down animation was causing that
when the actor was too quick the input was not visible.
[MAILPOET-4556]
 2022-09-21 14:02:45 +02:00
Jan Lysý
a7ac298cc9 Merge branch 'release' into trunk 2022-09-21 13:10:22 +02:00
Jan Lysý
f1e13697dc Release 3.98.1 3.98.1 2022-09-21 11:23:03 +02:00
Rostislav Wolny
a0e1c4a341 Fix typo in re-engagement email activation notices 
[MAILPOET-4654]
 2022-09-21 11:09:16 +02:00
Rostislav Wolny
409ff2b751 Add activation tracking and display activation notice for re-engagement emails 
[MAILPOET-4654]
 2022-09-21 11:09:11 +02:00
Rostislav Wolny
d73de819ee Add tracking of Automattic email activation 
[MAILPOET-4654]
 2022-09-21 11:09:06 +02:00
Rostislav Wolny
ea2f56bacc Fix delay value in tracking of immediate welcome emails 
I found out that we accidentally track values such as "1 immediate" etc.
This commit makes sure we track only string "immediate".
[MAILPOET-4654]
 2022-09-21 11:08:59 +02:00
Rostislav Wolny
157035f58c Fix typo in re-engagement email activation notices 
[MAILPOET-4654]
 2022-09-21 10:54:44 +02:00
Rostislav Wolny
4662c03d0d Add activation tracking and display activation notice for re-engagement emails 
[MAILPOET-4654]
 2022-09-21 10:54:44 +02:00
Rostislav Wolny
38d7a8821c Add tracking of Automattic email activation 
[MAILPOET-4654]
 2022-09-21 10:54:44 +02:00
Rostislav Wolny
cba6f19bf8 Fix delay value in tracking of immediate welcome emails 
I found out that we accidentally track values such as "1 immediate" etc.
This commit makes sure we track only string "immediate".
[MAILPOET-4654]
 2022-09-21 10:54:44 +02:00