By moving the refresh code into the method used for getting sending queue entity for the old model object
we want to make our code better protected from working with inconsistent sending queue data.
[MAILPOET-4750]
In case we save the task and and queue saving fails the sending may be triggered with incorrect data in the queue.
Since the scheduled task is used for controlling sending state lets save it as last so that we are sure all related
data are up to date before saving the task.
[MAILPOET-4750]
The commit f44afbddf2 introduced a bug
when replacing Paris code with Doctrine code in lib/Tasks/State.php.
This bug was causing the system status page to display "Preview" instead
of the subject of the listed emails. The problem was happening because
during the refactor there was a mistake and we were trying to get a
SendingQueueEntity via its ID using the ScheduledTaskEntity ID. This
commit fixes this problem by getting a SendingQueueEntity that matches
the given ScheduledTaskEntity ID.
[MAILPOET-4508]
PHPStan reported an error in PHP8.1. When we use
the annotation ReturnTypeWillChange it caused another error
for PHPStan in combination in PHP7.2. The new annotations
are solving those issues.
[MAILPOET-4053]
