Commit Graph

307 Commits

Author SHA1 Message Date
Pavel Dohnal
c1f4e0bf32 Make sure the user roles is always array
[MAILPOET-3955]
2021-12-16 14:46:16 +01:00
Brezo Cordero
940e0884cb Update API Test
Change the return of mocked function sendConfirmationEmailOnce after rebasing the changes that refactor that function.

[MAILPOET-3813]
2021-12-15 11:51:12 +01:00
Brezo Cordero
81e0772459 Refactor MPAPI subscribeToLists to Doctrine
[MAILPOET-3820]
2021-12-15 11:51:12 +01:00
Rodrigo Primo
d39d09dd72 Remove calls to Subscriber::setError() from ConfirmationEmailMailer
This commit is part of a task to replace Paris with Doctrine in the
class ConfirmationEmailMailer. Specifically, it removes two calls to
Subscriber::setError() inside ConfirmationEmailMailer::sendConfirmationEmail().

setError() was used to define an error message that was used only in one
of the instances where sendConfirmationEmail() is called
(API::subscribeToLists()). setError() was replaced with code that throws
an exception when there is an error. Thus it was necessary to change all
the places where ConfirmationEmailMailer::sendConfirmationEmail() is
called to handle the exception.

In some cases, there are some oddities as sendConfirmationEmail() can
return false or throw an exception in case of an error and calling code
must account for both. I decided to settle with this approach as
refactoring the rest of this method to use exceptions instead of
returning false seemed outside of the scope of this task.

[MAILPOET-3815]
2021-12-13 16:03:07 +01:00
Rodrigo Primo
6c05b3eaf0 Pass SubscriberEntity to sendConfirmationEmail() and sendConfirmationEmailOnce()
This commit changes the methods sendConfirmationEmail() and
sendConfirmationEmailOnce() to accept as the first parameter an instance
of SubscriberEntity instead of the old model Subscriber. It also updates
all the places where those two methods are called.

[MAILPOET-3815]
2021-12-13 16:03:07 +01:00
Rostislav Wolny
699266c920 Use TrackingConfig and new tracking settings property in PHP
[MAILPOET-3185]
2021-12-06 17:03:28 +01:00
Jan Lysý
7d04ea28ad Add meta to response when email is unauthorized
[MAILPOET-3881]
2021-11-15 15:03:43 +01:00
Pavel Dohnal
09719ca450 Use a better function for instance test
[MAILPOET-3876]
2021-11-10 12:49:48 +01:00
Pavel Dohnal
9229ed77d8 Refactor to doctrine
[MAILPOET-3876]
2021-11-10 12:49:48 +01:00
Pavel Dohnal
f5614ed2bd Refactor test to doctrine
[MAILPOET-3876]
2021-11-10 12:49:48 +01:00
Brezo Cordero
ea6eb0993d Disable activate button if tracking is disable
[MAILPOET-3840]
2021-11-02 09:12:02 +01:00
Rostislav Wolny
b8d72522a2 Replace deprecated doctrine methods in tests directory
[MAILPOET-3889]
2021-10-28 15:44:18 +02:00
Jan Lysý
6e6ba3e7a1 Use new signature of the dynamicSegmentFilterData constructor
[MAILPOET-3427]
2021-10-27 15:45:17 +02:00
Pavel Dohnal
c4037776f7 Fix newly found phpstan errors
[MAILPOET-3792]
2021-10-27 13:29:12 +02:00
Pavel Dohnal
0d70174737 Only do validation if MSS is active
[MAILPOET-3857]
2021-10-26 16:11:32 +02:00
Pavel Dohnal
813d43f857 Validate if newsletter has an unsubscribe link
[MAILPOET-3857]
2021-10-26 16:11:32 +02:00
Pavel Dohnal
709b4d8fcd Add more checks to the test
[MAILPOET-3628]
2021-10-04 12:37:46 +02:00
Pavel Dohnal
1aa93d1b3c Add a new test for creating a custom field
[MAILPOET-3628]
2021-10-04 12:37:46 +02:00
Pavel Dohnal
04c2061c12 Move the tests to a separate file
[MAILPOET-3628]
2021-10-04 12:37:46 +02:00
Pavel Dohnal
518c33187f Move custom fields methods to a separate file
[MAILPOET-3628]
2021-10-04 12:37:46 +02:00
Jan Lysý
1a3f16a3c0 Remove action create from endpoint
[MAILPOET-3662]
2021-09-27 10:14:02 +02:00
Pavel Dohnal
0f618cdc64 Remove old Form model from the subscribers test
[MAILPOET-3644]
2021-09-22 15:37:24 +02:00
Jan Lysý
ccedd3a112 Add count of bounced emails into API response
[MAILPOET-3766]
2021-09-14 15:59:50 +02:00
Pavel Dohnal
a53a680e8c Make naming more consistent
[MAILPOET-3740]
2021-08-30 14:04:29 +02:00
Pavel Dohnal
464f23c82b Display machine opens
[MAILPOET-3740]
2021-08-30 14:04:29 +02:00
Pavel Dohnal
3b7752daed Refactor creating new list to Doctrine
[MAILPOET-3625]
2021-08-23 14:18:57 +02:00
Pavel Dohnal
e31707903e Refactor import export test to doctrine
[MAILPOET-3625]
2021-08-23 14:18:57 +02:00
Jan Lysý
74dc9fce53 Remove the character "~" from counts
[MAILPOET-3708]
2021-08-16 10:25:37 +02:00
Brezo Cordero
b2857cbf40 Refactor code that checks for list deletion with form
Move segment deletion to new function doTrash to avoid calling methods twice on individual segment deletion. Refactor acceptance test.

[MAILPOET-3661]
2021-08-16 09:42:08 +02:00
Brezo Cordero
d9186e4230 Prevent deleting a list if attached to a form
[MAILPOET-3661]
2021-08-16 09:42:08 +02:00
Jan Lysý
a6dc552cdc Use new controller with subscribers counts
[MAILPOET-3646]
2021-07-12 11:51:39 +02:00
Jan Lysý
b735c8ac85 Fix dependency in settings integration test
[MAILPOET-3646]
2021-07-12 11:51:39 +02:00
Jan Lysý
96c84009b7 Add tilde before subscribers count in selects
[MAILPOET-3646]
2021-07-12 11:51:39 +02:00
Rostislav Wolny
65b834a9ff Update renamed NotCamelCaps rule
[MAILPOET-3658]
2021-07-06 13:29:00 +02:00
Jan Lysý
2288d745b1 Improve integration tests for DynamicSegments API
[MAILPOET-3559]
2021-06-28 11:29:46 +02:00
Jan Lysý
a23c73b341 Add test into DynamicSegmentsResponseBuilder
[MAILPOET-3469]
2021-06-21 14:02:04 +02:00
Jan Lysý
38aa403602 Add integration test for DynamicSegments with two filters
[MAILPOET-3469]
2021-06-21 14:02:04 +02:00
Jan Lysý
97dd402d21 Change error message when request is almost empty
[MAILPOET-3469]
2021-06-21 14:02:04 +02:00
Jan Lysý
72a3bfa35e Update integration test for DynamicSegmentsResponseBuilder
[MAILPOET-3469]
2021-06-21 14:02:04 +02:00
Jan Lysý
f106d6f2f2 Fix dependencies in integration tests
[MAILPOET-3269]
2021-06-14 10:12:34 +02:00
Jan Lysý
aeeceeeb8d Use Newsletter\Url as service
[MAILPOET-3269]
2021-06-14 10:12:34 +02:00
Jan Lysý
f7b77cf75d Remove FormRepository from SettingsController
[MAILPOET-3643]
2021-06-07 14:14:50 +02:00
Jan Lysý
4d5630b1ca Remove ScheduledTaskRepository from SettingsController
[MAILPOET-3643]
2021-06-07 14:14:50 +02:00
Jan Lysý
a0a0313c46 Use WP transient for lock running migrations
[MAILPOET-3537]
2021-05-24 14:59:40 +02:00
Pavel Dohnal
d9ec70dfe6 Refactor form api test to doctrine
[MAILPOET-3037]
2021-05-19 11:00:18 +02:00
Pavel Dohnal
61d73c1b6c Remove unused method
[MAILPOET-3037]
2021-05-19 11:00:18 +02:00
Jan Lysý
28060c8e12 Reschedule existing subscriber score task on reset
[MAILPOET-3533]
2021-05-12 14:42:22 +02:00
Rostislav Wolny
5f5e5d0860 Fix backend error messages
[MAILPOET-3226]
2021-05-11 14:25:16 +02:00
Pavel Dohnal
025d588591 Fix tests
[MAILPOET-3525]
2021-04-26 13:46:23 +02:00
Jan Lysý
3d5905c288 Remove usage old model from FormsResponseBuilderTest
[MAILPOET-3032]
2021-04-12 14:26:36 +02:00