This commit updates the remove date of the deprecated models
NewsletterOption and NewsletterOptionField. When they were initially
deprecated it was missed that two Newsletter model methods still used
them.
Those two methods are deprecated in this commit as apparently they are
not used anymore in MP's codebase.
[MAILPOET-5252]
In the previous commit, I removed all calls to the deprecated
utf8_encode() that seemed safe to remove. In this commit, I'm replacing
the calls to this function that I'm not sure if are same to remove or
not with mb_convert_encoding().
mb_convert_encoding() requires the extension mbstring to be enabled. It
should be enabled on most PHP install but not all. We are already using
mbstring functions in our code base and we provide a polyfill for PHP
installs where the extension is not enabled
(62bb75ed91/mailpoet/prefixer/composer.json (L25)).
So it should be safe to use it.
[MAILPOET-4865]
This was added in a37ff8d. Per the commit message, php_uname() in a
Windows server can sometimes return the string using encondings other
than ISO-8859-1 and thus utf8_encode() was added. The problem is that
utf8_encode() only converts from ISO-8859-1 to UTF-8 so it does not work
for the purpose that it was added and it was deprecated in PHP 8.2.
Removing it seems safe. If we start having problems with character
encoding in the string that we are sending to Helpscout, we can consider
other alternatives to make sure the string is always send using UTF-8.
[MAILPOET-4865]
In MAILPOET-4464 we introduced the new state "valid_underprivileged".
During implementation we introduced the state for MSS key validation,
but we forgot about the premium key.
This commit adds support for the state also for premium key validation.
When the key is underprivileged we don't display any error.
We will add specific error for underprivileged keys with specific
access restrictions in follow-up commits.
[MAILPOET-5103]
The two public methods for checking MSS and Premium keys were almost
exact copies.
To avoid doing the same changes in two places I decided to refactor them to
internally use a common private method.
[MAILPOET-5103]
This error was detected by a rule "Internal.NoCodeFound" with the following message:
No PHP code was found in this file and short open tags are not allowed by this install of PHP.
This file may be using short open tags but PHP does not allow them.
[MAILPOET-5236]
