Release 3.73.1

If a migration to new columns wasn't executed correctly, we want to be sure that getters return the correct value.
[MAILPOET-3910]

lib/Config/Migrator.php

@@ -702,8 +702,8 @@ class Migrator {
 
   private function migrateSerializedFilterDataToNewColumns(): bool {
     global $wpdb;
-    // skip the migration if the DB version is higher than 3.71.3 or is not set (a new install)
+    // skip the migration if the DB version is higher than 3.73.1 or is not set (a new install)
-    if (version_compare($this->settings->get('db_version', '3.71.4'), '3.71.3', '>')) {
+    if (version_compare($this->settings->get('db_version', '3.73.1'), '3.73.0', '>')) {
       return false;
     }
 

lib/Entities/DynamicSegmentFilterData.php

@@ -2,6 +2,7 @@
 
 namespace MailPoet\Entities;
 
+use MailPoet\Segments\DynamicSegments\Filters\UserRole;
 use MailPoetVendor\Doctrine\ORM\Mapping as ORM;
 
 /**
@@ -56,10 +57,22 @@ class DynamicSegmentFilterData {
   }
 
   public function getFilterType(): ?string {
-    return $this->filterType;
+    if ($this->filterType) {
+      return $this->filterType;
+    }
+    // When a new column is empty, we try to get the value from serialized data
+    return $filterData['segmentType'] ?? null;
   }
 
   public function getAction(): ?string {
-    return $this->action;
+    if ($this->action) {
+      return $this->action;
+    }
+    // When a new column is empty, we try to get the value from serialized data
+    // BC compatibility, the wordpress user role segment didn't have action
+    if ($this->getFilterType() === self::TYPE_USER_ROLE && !isset($this->filterData['action'])) {
+      return UserRole::TYPE;
+    }
+    return $this->filterData['action'] ?? null;
   }
 }

mailpoet.php

@@ -2,7 +2,7 @@
 
 /*
  * Plugin Name: MailPoet 3 (New)
- * Version: 3.73.0
+ * Version: 3.73.1
  * Plugin URI: http://www.mailpoet.com
  * Description: Create and send newsletters, post notifications and welcome emails from your WordPress.
  * Author: MailPoet
@@ -15,7 +15,7 @@
  */
 
 $mailpoetPlugin = [
-  'version' => '3.73.0',
+  'version' => '3.73.1',
   'filename' => __FILE__,
   'path' => dirname(__FILE__),
   'autoloader' => dirname(__FILE__) . '/vendor/autoload.php',

readme.txt

@@ -3,7 +3,7 @@ Contributors: mailpoet
 Tags: email, email marketing, post notification, woocommerce emails, email automation, newsletter, newsletter builder, newsletter subscribers
 Requires at least: 5.3
 Tested up to: 5.8
-Stable tag: 3.73.0
+Stable tag: 3.73.1
 Requires PHP: 7.1
 License: GPLv3
 License URI: https://www.gnu.org/licenses/gpl-3.0.html
@@ -184,6 +184,9 @@ Check our [Knowledge Base](https://kb.mailpoet.com) or contact us through our [s
 
 == Changelog ==
 
+= 3.73.1 - 2021-11-04 =
+* Fixed: segments are not loading.
+
 = 3.73.0 - 2021-11-02 =
 * Updated: composer dependencies;
 * Improved: don't allow duplicate sending and sending without an unsubscribe link;