Compare commits

..

333 Commits
4.0.1 ... 4.4.0

Author SHA1 Message Date
03b1a6e9ce Release 4.4.0 2023-01-10 07:52:34 +01:00
69440ec2a6 Add migration with a fix for inconsistent MailerLog data
[MAILPOET-4940]
2023-01-09 20:01:47 +01:00
0bbdf4b47f Add error log when pausing sending due an error
[MAILPOET-4940]
2023-01-09 20:01:47 +01:00
f11aca925f Do not attempt to send a confirmation email when sending is paused
When sending is paused due to some MSS configuration error the confirmation
email error may cause that the important error from MSS gets overwritten
event reset in case the mail is accidentally sent.
[MAILPOET-4940]
2023-01-09 20:01:47 +01:00
e4029a607a Adopt logging test to warning instead of error
[MAILPOET-4639]
2023-01-09 15:23:48 +01:00
eb53973799 Remove logEntity cleanup
[MAILPOET-4639]
2023-01-09 15:23:48 +01:00
aab8281af0 Remove request data from logged context
[MAILPOET-4639]
2023-01-09 15:23:48 +01:00
3df00548ab Change logged error to warning
[MAILPOET-4639]
2023-01-09 15:23:48 +01:00
ada346f4ef Add logging to php error log
[MAILPOET-4104]
2023-01-09 15:23:48 +01:00
b3691a4625 Detach invalid entity
[MAILPOET-4104]
2023-01-09 15:23:48 +01:00
e02b631172 Add log entities cleanup
[MAILPOET-4104]
2023-01-09 15:23:48 +01:00
2200411455 Add test case for logged error
[MAILPOET-4104]
2023-01-09 15:23:48 +01:00
b0ab2f404f Add logging errors to the log table
[MAILPOET-4104]
2023-01-09 15:23:48 +01:00
4195428643 Add API topic
[MAILPOET-4104]
2023-01-09 15:23:48 +01:00
1692c9bef5 Fix typo in strings
MAILPOET-4797
2023-01-09 14:38:09 +01:00
cb25cf2944 Handle redirect to welcome wizard with named function
MAILPOET-4797
2023-01-09 14:38:09 +01:00
794c5ce2d5 Extract landing page content into Header and Footer components
MAILPOET-4797
2023-01-09 14:38:09 +01:00
974d2d5a59 Add welcome_wizard_url variable
MAILPOET-4797
2023-01-09 14:38:09 +01:00
2ebcad1468 Exclude Notices from landingpage
MAILPOET-4797
2023-01-09 14:38:09 +01:00
671c7eed7d Add React landingpage component
MAILPOET-4797
2023-01-09 14:38:09 +01:00
72de76fe9b Fix multi site tests 2023-01-09 10:49:24 +01:00
53cc357632 Fix step info being rendered inside inserter popover
[MAILPOET-4922]
2023-01-06 18:31:36 +01:00
47d3472fef Fix acceptance tests error and add acceptance test for landing page
MAILPOET-4795
2023-01-06 18:29:46 +01:00
05c5b46089 Redirect to landingpage when welcome wizard is not filled
MAILPOET-4795
2023-01-06 18:29:46 +01:00
f85bd8622f Add comment explaining the usage of the method
MAILPOET-4795
2023-01-06 18:29:46 +01:00
503cf61c0f Do not redirect when activated with bulk activation mode
MAILPOET-4795
2023-01-06 18:29:46 +01:00
d9eca55189 Redirect to Landing page after plugin activation
MAILPOET-4795
2023-01-06 18:29:46 +01:00
e850eaa90c Add Landing page and hide behind feature flag
MAILPOET-4795
2023-01-06 18:29:46 +01:00
478eab61e4 Add Landingpage feature flag
MAILPOET-4795
2023-01-06 18:29:46 +01:00
ea53728799 Add period at the end of delay action description
[MAILPOET-4928]
2023-01-06 18:26:30 +01:00
914d0d37c0 Add periods at the end of automation action descriptions
[MAILPOET-4928]
2023-01-06 18:26:30 +01:00
c1aae2c192 Update usage of settings inside tinymce callbacks
Settings are now accesable via this.options.get
[MAILPOET-4213]
2023-01-04 14:46:59 +01:00
03cdcb30f8 Add missing tinymce DOM model
[MAILPOET-4213]
2023-01-04 14:46:59 +01:00
a462e72b30 Update name of the used plugin from formatselect to blocks
In v6 formatselect is renamed to blocks
[MAILPOET-4213]
2023-01-04 14:46:59 +01:00
83db3db90d Remove explicit addition of paste plugin as it's added to core
[MAILPOET-4213]
2023-01-04 14:46:59 +01:00
9495a40900 Convert TextEditorBehavior.js to TS
[MAILPOET-4213]
2023-01-04 14:46:59 +01:00
dbc2c9c240 Update tinymce package
[MAILPOET-4213]
2023-01-04 14:46:59 +01:00
d6bd1a5527 Release 4.3.1 2023-01-03 13:58:02 -06:00
c5cd863f15 Use database() value for column existing detection
[MAILPOET-4916]
2023-01-02 14:37:33 +01:00
8ef1bfaf24 Add acceptance test for homepage basic functionality
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
abac8d7147 Move MailerError notice component to notices namespace
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
367bcaf233 Refactor MailerError notice props to camel case
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
fdbb9428d9 Refactor MailerError notice to Typescript
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
bd047a0108 Automatically hide MailerError notice after resuming sending
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
05202d572f Add Mailer Error notice to homepage
This commit reuses the MailerError component to render important errors related to issues in sending.

I needed to slightly modify the MailerError notice component to be able to render as inline notice.
When rendered as non-inline WordPress JS code grabbed it and moved in DOM breaking all callbacks.
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
a698e416ad Allow all permanent notices on all pages except the wizard page
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
1efc417f82 Add TransactionalEmailsProposeOptInNotice on homepage
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
4dc31bbdb0 Add InvalidMssKeyNotice to homepage
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
12dc727fda Refactor SubscribersLimitNotice to TS
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
6602103d0f Add email volume limit notice
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
f3e8fb8ae2 Add subscribers limit notice to homepage
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
a205d4d7f4 Add basic support for dynamic notices
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
1783ca6e42 Add basic top bar with beamer at homepage
[MAILPOET-4825]
2023-01-02 14:13:53 +01:00
6555833fb6 Add test case for scheduled tasks
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
ce3b9b2b7b Remove redundant variables
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
1a653c5676 Add small code style improvements
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
85a8d8aedb Move more specific conditions into private methods
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
5c453fcd54 Add list of simple workers
To avoid code repetition I added a const with a list of simple workers that was used in a loop.
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
ec9adf8a6c Add missing test cases
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
b5064ca46f Remove old model from WordPressTest
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
84b97ead76 Make parameter scheduledAt optional
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
4e578238f7 Improve code style in WordPressTest
[MAILPOET-3995]
2023-01-02 12:07:24 +01:00
bb6d6137aa Stop checking if website is on HTTPS for 1-click-unsubscribe
[MAILPOET-4859]
2022-12-29 11:18:25 +01:00
74c7728e3a Fix issue with passing too few params to tested class 2022-12-28 20:02:36 +03:00
e13113e38b Fix condition for pausing sending when confirmation emails fail
[MAILPOET-4736]
2022-12-28 14:25:56 +01:00
68db0dbefe Don't process soft sending errors via MailerLog in confirmation mailer
Soft errors are usually related to the particular email address. We don't want to
pause sending due soft errors.
[MAILPOET-4736]
2022-12-28 14:25:56 +01:00
e015302a94 Update the confirmation email error message
[MAILPOET-4736]
2022-12-28 14:25:56 +01:00
20fcf23f8f Add processing of sending errors to the confirmation mailer
[MAILPOET-4736]
2022-12-28 14:25:56 +01:00
11beebf74d Add MailerLog method for handling transactional emails errors
The new method allows processing sending errors that happen when sending from other places of plugin
then from the Sending Queue worker.
After three failed attempts it pauses the sending and admin user will see an notice.
[MAILPOET-4736]
2022-12-28 14:25:56 +01:00
5a53406d33 Show error in form if confirmation email fails
[MAILPOET-4736]
2022-12-28 14:25:56 +01:00
ee83e4d748 Refactor SubscriberActions:subscribe to return status of confirmation email
We need to pass the error or success info about the confirmation email
in order to be able to be able to display the error message.
[MAILPOET-4736]
2022-12-28 14:25:56 +01:00
970db8f0d8 Prevent undefined function request_filesystem_credentials error
The function request_filesystem_credentials was not loaded when
running translation update during regular page load.
This commit ensures the function is loaded.
[MAILPOET-4902]
2022-12-28 13:24:47 +01:00
71828f9f6e Fix WC Checkout test by stoping to toggle removed setting
Starting from wc@7.2 the WC Blocks compatible version's
Checkout block doesn't offer the option to enable/disable
creating checkout on checkout, and this is only controllled
via the WC settings page

[MAILPOET-4925]
2022-12-23 10:28:35 +01:00
0525dd0f56 Update cerdic/css-tidy to version 2.0.3 to remove PHP 8.2 warnings
PHP 8.2 deprecates dynamic properties. The version of the Composer package cerdic/css-tidy that we are using relies on dynamic properties and thus MailPoet is generating a few deprecation warnings when running with PHP 8.2. Updating cerdic/css-tidy to the latest version remove those warnings as this was already fixed by the package maintainers.

[MAILPOET-4857]
2022-12-21 10:50:05 +01:00
e3ba525195 Unify inheritance with other processors
[MAILPOET-4735]
2022-12-21 10:07:35 +01:00
1eed55cbce Indicate optional processors
[MAILPOET-4735]
2022-12-21 10:07:35 +01:00
fd1331e602 Add plugins version to logs
[MAILPOET-4735]
2022-12-21 10:07:35 +01:00
02b82c04f3 Release 4.3.0 2022-12-20 16:25:45 +01:00
ad5ef6ebbc Fix ESLint errors after rebasing PR
Use async/await for promisses. Similar to what was discussed here: https://github.com/mailpoet/mailpoet/pull/4603#discussion_r1048950706

This is the ESLint error that started happening after the rebase:

```
mailpoet/assets/js/src/wizard/woocommerce_controller.tsx
  71:11  error  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator  @typescript-eslint/no-floating-promises
```

[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
3c5bc5b384 Fix issue in wizard.tsx with using Route.render
Route.render expects other types than the one coming out of
withBoundary, replacing it with Route.component fixes the
typing issue

[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
f229df0383 Replace void with async/await based on input from PR reviewer
See https://github.com/mailpoet/mailpoet/pull/4603#discussion_r1048950706

[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
9092f892d0 Refactor webpack_admin_index.jsx to TypeScript
[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
9c3fb0856f Refactor wizard.jsx to TypeScript
[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
2a8c665e12 Refactor welcome_wizard_controller.jsx to TypeScript
[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
9b1942ce48 Refactor sender_step.jsx to TypeScript
[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
932b4532f0 Change ReinstallFromScratch test now that the Welcome Wizard is mandatory
This commit updates the ReinstallFromScratch test now that the logic for
displaying the Welcome Wizard changed in
afba41ad27b8b72e892892fe386b48b5a6f59b9b. Before just loading the wizard
once was enough to dismiss it, now it is necessary to complete it. In
this commit, an utility function was created and it is used to dismiss
the wizard twice in the modified test.

[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
6533a1444d Display submenu entries only after the Welcome Wizard is completed
[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
05a109dcf4 Force users to complete the Welcome Wizard
This commit changes the behavior of the Welcome Wizard. Up until now,
the wizard would load once and users could opt to complete or skip it.
Now it is mandatory for the users to complete the wizard. Before we
saved the setting "version" the first time the first step of the wizard
was loaded and now we saved it when the wizard is completed.

[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
5b5b7856c6 Use DI container to get an instance of Menu to simplify MenuTest
By using the DI container to get an instance of Menu we simplify
MenuTest and avoid the need to change MenuTest::getMenu() every time the
signature of the constructor of the Menu class changes, which will
happen in a subsequent commit.

[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
4ceb508218 Fix typo 2022-12-19 21:37:42 +01:00
3afc7dc140 Change button in the first step of the welcome wizard
This commit changes the button "Finish later" of the first step of the
welcome wizard to "Skip this step". Both the label and the functionality
of the button changed.

[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
1c1058667b Change copy of the first step of the welcome wizard
[MAILPOET-4815]
2022-12-19 21:37:42 +01:00
129aed2ae9 Add minimal error boundary to Automation app
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
f8c7adf5a6 Add error boundary to common components
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
6346d39507 Add erro boundary to newsletter app
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
1b76f3b862 Add error boundary to form editor app
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
40c140a631 Add error boundary to wizard app
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
7fd11d4fb5 Add error boundary to subscriber import/export app
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
7fa694314b Add error boundary to logs namespace
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
080e385b02 Add error boundary to experimental_features.jsx
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
7c0b625793 Add error boundaries to logs.tsx
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
f0b858b1f8 Add error boundery to underlying components in forms/forms.jsx
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
b218663e7e Add error boundary to segments/segments.jsx
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
d8ea29423d Add error boundary to newsletters_editor/initialize.jsx
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
ff038a1c56 Wrap inner components of newsletters.jsx in erro boundary
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
588e8fca6b Use withBoundary HOC in subscribers.jsx
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
8d9f23d5f8 Define error boundary and relevant HOC
[MAILPOET-4706]
2022-12-19 17:02:00 +01:00
ea4637c740 Add the possibility to skip hooks when subscribing to segments
[PREMIUM-214]
2022-12-19 12:04:28 +01:00
c0e56a4f92 Expose checkbox control
[PREMIUM-214]
2022-12-19 12:04:28 +01:00
53a4722e91 Add remove-from-list step placeholder
[PREMIUM-214]
2022-12-19 12:04:28 +01:00
d175870adf Add add-to-list step placeholder
[PREMIUM-214]
2022-12-19 12:04:28 +01:00
a64229f688 Fix automation template variables being loaded too late
[PREMIUM-214]
2022-12-19 12:04:28 +01:00
cd69e1e7b9 Refactor woocommerce_controller.jsx to TypeScript
[MAILPOET-4817]
2022-12-17 13:16:30 +01:00
321db0b004 Refactor woo_commerce_step.jsx to TypeScript
While renaming the file, I also opted to remove the underscore in
between "woo" and "commerce" as it is more common to spell "woocommerce"
without the underscore in file names and we already have at least
woocommerce_controller.jsx.

[MAILPOET-4817]
2022-12-17 13:16:30 +01:00
aaf01475b0 Simplify code to redirect to next step based on review feedback
See https://github.com/mailpoet/mailpoet/pull/4605#discussion_r1044404486

[MAILPOET-4817]
2022-12-17 13:16:30 +01:00
1cd38a396e Add parent container to the list of options in the WooCommerce step
This parent container is needed so that the last-child CSS pseudo
selector that was added in #4602 works to remove the horizontal line
from the last .mailpoet-wizard-woocommerce-option.

[MAILPOET-4817]
2022-12-17 13:16:30 +01:00
1f1c9dd077 Update copy of the Woo step of the Welcome Wizard
[MAILPOET-4817]
2022-12-17 13:16:30 +01:00
0da6d84309 Welcome Wizard: invert the order of the Woo and MSS steps
Now the Woo step comes first and then the MSS step which is always the
last step.

[MAILPOET-4817]
2022-12-17 13:16:30 +01:00
3a05598166 Improve comparison stability in test
[MAILPOET-4886]
2022-12-16 15:39:43 +01:00
5035d64298 Update the layout of the horizontal lines in the second step of the Welcome Wizard
In the second step of the wizard, it was necessary to add a <div> as a
container for all of the options, so that we could use the CSS
pseudo-class `last-child` to remove the horizontal line from the last
option.

[MAILPOET-4816]
2022-12-16 14:54:46 +01:00
56f6d20244 Update copy of the title of the second step of the Welcome Wizard
[MAILPOET-4816]
2022-12-16 14:54:46 +01:00
650d730c3f Fix lowercased captcha on built-in CAPTCHA buttons
[MAILPOET-4915]
2022-12-16 14:27:49 +01:00
decaa0f636 Fix typos
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
c2b9e33b79 Show error background in FormTokenField
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
34347f241d Add RemoveTag action stub
[PREMIUM-216]
2022-12-16 14:11:34 +01:00
5802f2132d Use badRequest method instead of throwing an InvalidState exception
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
8e502e5f50 Rename save method to create
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
0187f0cede change date keys
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
8457aa7e2b Remove ToDo comments
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
67156b7c6f Expose wordpress/components/spinner
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
f9250b66a9 Export wordpress/data-controls
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
1fcdccaa33 Expost json api endpoint
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
5b93b88f46 Add Tags endpoint
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
cbd41cd1be Remove unnecessary styles
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
95a8943b7e Use span instead of paragraph
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
dd363370f6 Remove white space
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
1027a6a676 Move FormTokenField to editor components
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
0fd93b0ff9 Show Upsell and LockedBadge
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
bfade87b62 Add Badge with locked symbol
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
26d9030544 Expose PanelBody via @wordpress/components
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
5688a0daea Rename filter to mailpoet.automation.register_step_type
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
92996ac781 Make mailpoet_tags available globally
[MAILPOET-4423]
2022-12-16 14:11:34 +01:00
1f471782ab Add Action stub 'Add Tag'
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
320459eaab Add filter mailpoet.register_step_type
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
e65b2cce02 Expose components for premium
[PREMIUM-213]
2022-12-16 14:11:34 +01:00
520ee981d3 Fix autosaving when activation link is missing
MAILPOET-4649
2022-12-15 18:15:01 +01:00
f100ef72da Add tracking and reporting information
MAILPOET-4649
2022-12-15 18:15:01 +01:00
146e1c871f Remove preview button
The preview button is a nice addition to the confirmation email template, but it's currently not part of the Jira ticket spec.

MAILPOET-4649
2022-12-15 18:15:01 +01:00
669367c9c6 Update texts and fix editor saving template with missing activation link
MAILPOET-4649
2022-12-15 18:15:01 +01:00
77d62c431a Fix coding style issues
MAILPOET-4649
2022-12-15 18:15:01 +01:00
4a5fc507ca Add tests for ConfirmationEmailCustomizer
MAILPOET-4649
2022-12-15 18:15:01 +01:00
06f59dd320 Update JS tests
MAILPOET-4649
2022-12-15 18:15:01 +01:00
4367f44449 Add support for confirmation email in newsletter editor
MAILPOET-4649
2022-12-15 18:15:01 +01:00
856e0f69d3 Add text contents and data required for confirmation email editor
MAILPOET-4649
2022-12-15 18:15:01 +01:00
c4bd2acd84 Update tests
MAILPOET-4649
2022-12-15 18:15:01 +01:00
210c240aab Update ConfirmationEmailMailer to support custom confirmation email created with the email editor from template
Setup confirmation email customizer in ConfirmationEmailMailer and trigger confirmation email template creation when visual subscription confirmation emails is enabled from settings

MAILPOET-4649
2022-12-15 18:15:01 +01:00
d19f5dc732 Add ConfirmationEmailCustomizer class and confirmation email template
MAILPOET-4649
2022-12-15 18:15:01 +01:00
6541c20466 Hide both “Email subject” and “Email content” when ConfirmationEmailCustomizer is enabled
MAILPOET-4649
2022-12-15 18:15:01 +01:00
3952484848 Add openEmailCustomizer action used by the ConfirmationEmailCustomizer component
MAILPOET-4649
2022-12-15 18:15:01 +01:00
7d918604c3 Add ConfirmationEmailCustomizer component and setup types
MAILPOET-4649
2022-12-15 18:15:01 +01:00
ffaf5b88b6 Configure integration tests oldest to use MYISAM and MySQL 5.5
[MAILPOET-4832]
2022-12-14 12:00:49 +01:00
eca4a9e923 Add integration test to ensure correct unique varchar indexes
[MAILPOET-4832]
2022-12-14 12:00:49 +01:00
1cee4e67e8 Print DB tables with engine and collation on test env star
[MAILPOET-4832]
2022-12-14 12:00:49 +01:00
b1c35b60d8 Configure acceptance tests oldest to use MYISAM db engine
[MAILPOET-4832]
2022-12-14 12:00:49 +01:00
1e5cfb4eaf Switch acceptance tests oldest to MYSQL 5.5
[MAILPOET-4832]
2022-12-14 12:00:49 +01:00
5e5956420f Release 4.2.0 2022-12-13 13:34:21 +01:00
78446d174a Fix quotes in a queries processed by $wpdb
These queries failed when ANSI_QUOTES mode is enabled
[MAILPOET-4887]
2022-12-12 13:59:09 +01:00
917d64a3e3 Print sql_mode when starting test environment
[MAILPOET-4887]
2022-12-12 13:59:09 +01:00
a3d51b2b08 Add ANSI and ONLY_FULL_GROUP_BY to sql_mode for tests environment
The default modes shipped with the mysql or mariaDB docker containers are
STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
In this commit I added ANSI, ONLY_FULL_GROUP_BY so that we are sure that we don't break compatibility with those modes
[MAILPOET-4887]
2022-12-12 13:59:09 +01:00
3ffbd6e236 Add ANSI and ONLY_FULL_GROUP_BY to sql_mode for dev environment
The default modes shipped with the mysql or mariaDB docker containers are
STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
in this commit I added ANSI, ONLY_FULL_GROUP_BY so that we are sure that we don't break compatibility with those modes
[MAILPOET-4887]
2022-12-12 13:59:09 +01:00
9753331d52 Improve sql_mode replace code to support both ANSI and ANSI_QUOTES
[MAILPOET-4887]
2022-12-12 13:59:09 +01:00
b266edb8e7 Make initial migration ANSI_QUOTES compatible
We run the initial migrations via dbDelta which internally uses
$wpdb. ANSI_QUOTES is not on the list of WPDB's incompatible modes
(767bdad516/wp-includes/class-wpdb.php (L648-L655))
So we need to make sure SQL queries we run through wpdb are ANSI_QUOTES compatible.
This commit makes initial migrations compatible with the ANSI_QUETES mode.
[MAILPOET-4887]
2022-12-12 13:59:09 +01:00
f1899055b8 Drop StepType from mailpoet.automation.step.more-controls filter
[MAILPOET-4889]
2022-12-12 12:23:52 +01:00
c3f0a36665 Make it possible to display the MP logo without a link
[MAILPOET-4819]
2022-12-08 13:30:12 +01:00
88efb1f3d1 Move logo to the top bar in the welcome wizard
[MAILPOET-4819]
2022-12-08 13:30:12 +01:00
146f5881f7 Adjustments to the layout of the welcome wizard layout
[MAILPOET-4819]
2022-12-08 13:30:12 +01:00
3279fb1154 Move regexes out of KeyActivation to avoid rerunning them in every render
[MAILPOET-4749]
2022-12-08 11:00:09 +01:00
5f5efbe876 Change title and description of the key activation settings tab
This commit changes the text of the title and the description of the key
activation settings tab to hopefully make it more clear the meaning of the
key and what they should do if they don't have one or if they are unsure
where they can get their key.

[MAILPOET-4749]
2022-12-08 11:00:09 +01:00
12afcfb656 Improve readability
[MAILPOET-3487]
2022-12-07 11:53:48 +01:00
0aac9e9d60 Test language switches in newsletters
[MAILPOET-3487]
2022-12-07 11:53:48 +01:00
4e3b1527cd If no translation for the current language exists, return 'en'
[MAILPOET-3487]
2022-12-07 11:53:48 +01:00
b27dcdd40a Use new language function in twig email templates
[MAILPOET-3487]
2022-12-07 11:53:48 +01:00
7b584dd482 Add language function to twig
[MAILPOET-3487]
2022-12-07 11:53:48 +01:00
5e71d94b62 Use website language for newsletters
[MAILPOET-3487]
2022-12-07 11:53:48 +01:00
8bb4338627 Inject WPFunctions
[MAILPOET-3487]
2022-12-07 11:53:48 +01:00
4bcd4a2cf2 Add single const to expose shortcodes for unsubscribe link
[MAILPOET-4862]
2022-12-07 10:52:07 +01:00
ea7971cb3b Translate the shortcode for instance unsubscribe link
The [link:subscription_instant_unsubscribe_url] shown on
stats page was not translated

[MAILPOET-4862]
2022-12-07 10:52:07 +01:00
9036b210a0 Add test for click stat recording for 1-click
[MAILPOET-4862]
2022-12-07 10:52:07 +01:00
f337ac388b Fix wrong assertions in PagesTest
[MAILPOET-4862]
2022-12-07 10:52:07 +01:00
b0ae21ec60 Record click stat for 1-click unsubscribe
[MAILPOET-4862]
2022-12-07 10:52:07 +01:00
7d11eeeddd Add triggering of the actionScheduler
[MAILPOET-4899]
2022-12-07 07:42:03 +01:00
4577ca5476 Fix tests
[MAILPOET-3982]
2022-12-06 14:17:49 +01:00
846794b60d Improve Cron error message
This commit gives more context to the maximum execution limit error

[MAILPOET-3982]
2022-12-06 14:17:49 +01:00
5757af95aa Release 4.1.1 2022-12-06 13:04:01 +01:00
b8c3b38652 Skip SwitchingLanguagesCest on release branch
The test would fail because the translations packs are not ready
at the time when we prepare the release.
[MAILPOET-4863]
2022-12-05 12:02:15 +01:00
3d21e4f35e Increase retries when waiting for languages update to be available
[MAILPOET-4863]
2022-12-05 12:02:15 +01:00
73ce89d051 Mention both forms and emails when describing 3rd-party libraries and Google Fonts
[MAILPOET-4888]
2022-12-05 11:59:48 +01:00
49d9dd666b Fix coding styles issues in DisableMailFunctionNotice
[MAILPOET-4760]
2022-12-05 11:59:16 +01:00
53dda33c02 Update method and constant name
MAILPOET-4760
2022-12-05 10:25:28 +01:00
9b9f61bf13 Only queue test mail for sending when the mailpoet sending method is updated
MAILPOET-4760
2022-12-05 10:25:28 +01:00
651e2d3c56 Update tests and refactor method name
MAILPOET-4760
2022-12-05 10:25:28 +01:00
0bd627d3b1 Add support for checking misconfiguration of the PHP mail function
Some hosts do perform intentional misconfiguration of the mail function, causing it not to work.

When the mail function is misconfigured, we can still access and execute the mail function from within the codebase, but we get an error.

There’s no accurate way to know the PHP mail function is misconfigured. Unless we execute the function with all the proper parameters and check the exception error message against this error `Could not instantiate mail function.`

MAILPOET-4760
2022-12-05 10:25:28 +01:00
99d0eede80 Add tests for DisabledMailFunctionNotice
MAILPOET-4760
2022-12-05 10:25:28 +01:00
d09b4ca409 Add check for mail function and display notice if disabled
MAILPOET-4760
2022-12-05 10:25:28 +01:00
caa76983e4 Ensure action scheduler jobs are done
[MAILPOET-4864]
2022-12-02 14:58:48 +01:00
7b6bbb0bc3 Remove unnecessary integration test job for woo
After the release of HPOS we no longer need to install the special Woo build and
that caused that integration_test_woocommerce job and integration_test_woo_cot_off job
have completely same configuration.
This commit removes one of those job.
[MAILPOET-4880]
2022-12-01 12:20:42 -03:00
cdf7c81a94 Remove unnecessary acceptance_tests_woo_cot_off job
The same set of tests run within acceptance_tests_base_and_woo_cot_off job
[MAILPOET-4880]
2022-12-01 12:20:42 -03:00
86812c5259 Rename acceptance test job to contain info about HPOS configuration
[MAILPOET-4880]
2022-12-01 12:20:42 -03:00
657302b720 Simplify <Tags> component and add wrapper components
[MAILPOET-4628]
2022-12-01 13:36:18 +01:00
172b5215d2 Fix strict types definition spacing
[MAILPOET-4879]
2022-11-30 12:39:19 +01:00
52a9d9f76c Remove redundant name from package.json 2022-11-30 12:30:52 +01:00
8eb7a48d3e Fix display of Text option in the editor sidebar
[MAILPOET-4808]
2022-11-30 12:30:52 +01:00
a8bceffc9c Add forgotten strict_types to Homepage page class
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
2c728c793a Redirect to main page instead of emails page from logo and after reinstall
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
8d974d8147 Add mainPageSlug to MailPoet module
In some places we hardcode emails page as the main page.
This property is meant to be used in places where we want to link
to main plugin page so that the links change when homepage is active
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
8fbc5c270a Place home at the first position in submenu
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
92dc5921df Set main page to homepage in case the feature is active
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
3c3ce37720 Temporarily add static property for MAIN_PAGE_SLUG
We need to be able to change it when homepage feature is active.
When we remove the feature flag will switch back to using constant.
Note I also kept the constant in case a third party plugin uses it.
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
f369e399ed Distinguish main page and emails page
There are some cases where we link or redirect to main page but
actually we want to redirect to emails page. It happens that currently they are
the same page, but we need to distinguish these cases for the future when
we switch the main page to new homepage.
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
01aa1e1e52 Refactor page slugs into constants
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
2bbc1b7063 Add homepage page and submenu item hidden behind feature flag
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
04b8a0ed73 Add feature flag for homepage
[MAILPOET-4824]
2022-11-30 11:42:41 +01:00
761f7c6537 Prevent issues if other plugins define WC function
It's possible that other plugins might define wc_get_page_id, so it's
more important to know that WC is installed/active than to know if the
function itself exists.

For good measure I'm including a cast to int even though the WC version
of the function always returns an integer. This is probably unnecessary
but it protects us from the possibility of the WC version of the
function returning something other than an integer in the future.

[MAILPOET-4834]
2022-11-30 11:03:40 +01:00
723dc2c9d3 Fix type errors in tests
[MAILPOET-2688]
2022-11-29 15:04:09 +01:00
d66fbb1c20 Fix confirmed IP value in tests
[MAILPOET-2688]
2022-11-29 15:04:09 +01:00
c2107b8d59 Enable strict types rule for all files
[MAILPOET-2688]
2022-11-29 15:04:09 +01:00
926620e8f8 Ignore strict types rule in all existing files that don't have it
[MAILPOET-2688]
2022-11-29 15:04:09 +01:00
82aeb89854 Use strict types in tests
[MAILPOET-2688]
2022-11-29 15:04:09 +01:00
c67c58709b Unify spacing of declare statements
[MAILPOET-2688]
2022-11-29 15:04:09 +01:00
75b5958a53 Release 4.1.0 2022-11-29 13:56:02 +01:00
bba5101669 Replace switching groups' tab by a new function
[MAILPOET-4861]
2022-11-29 10:58:11 +01:00
b9c5dddbaf Try switch group multiple times
[MAILPOET-4861]
2022-11-29 10:58:11 +01:00
0566b3f5fa Fix remaining code style issues
[MAILPOET-4850]
2022-11-28 22:24:54 +01:00
ac4adac1ab Fix test class name
[MAILPOET-4850]
2022-11-28 22:24:54 +01:00
33a9097719 Fix trim(null) issue
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
08c74cdf8b Fix SlevomatCodingStandard.Namespaces.UnusedUses.MismatchingCaseSensitivity
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
8c5222d850 Fix WordPress.Security.ValidatedSanitizedInput.InputNotSanitized and related errors
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
08c76a46af Fix Squiz.Classes.ClassFileName.NoMatch and related errors
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
3d24cb1deb Fix Generic.Classes.DuplicateClassName.Found
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
a151f93be1 Fix Generic.CodeAnalysis.JumbledIncrementer.Found
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
bce6a06c15 Fix Sniffs.ControlSignature.Found
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
10a6e387f3 Fix Squiz.Scope.MethodScope.Missing
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
b6a37f274c Fix Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
2cdbc68643 Fix Squiz.Classes.ValidClassName.NotCamelCaps
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
7db40b27b5 Fix errors automatically with phpcbf
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
b1760ff676 Add MinimalPluginStandard to lint-staged command
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
293eef2c78 Add MinimalPluginStandard to Robofile
./do qa:minimal-plugin-standard will not execute the MinimalPluginStandard phpcs sniffs
./do qa:php has been extended to include the sniffs as well

[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
299c6b779e Remove MinimalPluginStandard from ruleset
[MAILPOET-4850]
2022-11-28 22:54:13 +03:00
842f435976 Add default value for method to StatisticsUnsubscribeEntity
When entity is created the default value is not set and it may causes
failures when it is not set additionally.
This commit sets default value and also defines a constant for the default value.
[PREMIUM-211]
2022-11-28 18:21:52 +01:00
11faf925cc Refactor time assertions in AutomaticEmailTest to use assert with delta
Carbon:setTestNow was not working because we are instantiating the new Carbon instance with value.
This commit updates all DateTime assertions to use the new assertEqualDateTimes method
[MAILPOET-4867]
2022-11-28 14:19:30 +01:00
1295aa21cc Skip congratulatory email if we know it will fail
[MAILPOET-4641]
2022-11-28 14:12:50 +01:00
84cd137c76 Don't switch to MSS when activating key without sending
[MAILPOET-4641]
2022-11-28 14:12:50 +01:00
37067dff67 Add state to MSS key check response
[MAILPOET-4641]
2022-11-28 14:12:50 +01:00
c7f850e1ba Declare strict types
[MAILPOET-4842]
2022-11-28 13:03:06 +01:00
b25f2cd5f4 Enable a Trigger to activate a second automation
[MAILPOET-4842]
2022-11-28 13:03:06 +01:00
af95080b67 Add test for TriggerHandler
[MAILPOET-4842]
2022-11-28 13:03:06 +01:00
6b8c35d5fe Fix Manage Sender Domain modal hides underneath Preview newsletter modal
MAILPOET-4812
2022-11-28 12:14:52 +01:00
a35e0dced4 Accept null opt-in values for in Woo Blocks integration
[MAILPOET-4804]
2022-11-28 11:51:27 +01:00
c6259eb185 Create acceptance test container upfront with one retry
This is and attempt to fix random issue with
Error response from daemon: Conflict. The container name "/wordpress_X" is already in use
[MAILPOET-4851]
2022-11-28 09:14:56 +01:00
670017b342 Update nesbot/carbon to the latest version
This is needed for MailPoet to work well with the upcoming PHP 8.2.

nesbot/carbon versions previous to 2.62.1 could cause issues when used
with PHP 8.2, see this PR for more information:
https://github.com/briannesbitt/Carbon/pull/2663

Without this update MailPoet users will see the following fatal error
when using PHP 8.2:

```
TypeError
MailPoetVendor\Carbon\Carbon::setLastErrors(): Argument #1 ($lastErrors) must be of type array, bool given, called in /srv/www/mp/public_html/wp-content/plugins/mailpoet/vendor-prefixed/nesbot/carbon/src/Carbon/Traits/Creator.php on line 567
```

[MAILPOET-4838]
2022-11-26 09:38:05 +01:00
ce7b210da9 Bump tested up to
[MAILPOET-4841]
2022-11-26 09:09:00 +01:00
1a2d8b8d40 Add saving nicename for created WP users
[MAILPOET-4841]
2022-11-26 09:09:00 +01:00
fe2df00a8c Use the latest WP version as default for acceptance tests
[MAILPOET-4841]
2022-11-26 09:09:00 +01:00
20577d974f Replace custom createSubscriber method with common factory method
[MAILPOET-4860]
2022-11-25 17:17:48 +01:00
7369465a3a Add subscribers cleanup to stats notification worker test
The test creates subscribers and there was not cleanup so this was increasing
probability of conflict in subscribers email.
[MAILPOET-4860]
2022-11-25 17:17:48 +01:00
5769fa45f5 Use helper methods for method column migration
This fixes issues with MailPoet in multiple schemas on the same MySQL instance as well
as simplifies the code. The migration was also renamed to a newer date. Additionally, the
edit of the initial MailPoet migration was reverted as this is not needed.

[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
193b4cbf98 Set missing unsubscribe method for failing tests
[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
461df1a560 Adjust strict_types & method typehint based on PR feedback
[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
d5f78680eb Add integration test for unsubscibe properties
[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
96dde7107b Expose unsubscribe analytics properperties
[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
3e756bfadd Add test to assert correct unsubscription method is saved
[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
82c755200e Augment track persister test with method as meta
[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
735d33d05b Add method of tracking when tracking unsubscriptions
[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
90c8e5b2c9 Introduce method column to statistics_unsubscribes table
[MAILPOET-4733]
2022-11-25 14:51:57 +01:00
cd1f06b116 Forbid assert() in code base
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
173f347431 Fix assert in Helper
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
353d3389cd Fix assert in data factories
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
fe364978a1 Fix usage of assert in acceptance tests
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
cd512bbb01 Fix instanceOf assertions in unit tests
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
f5193df721 Fix not null assertions in integration tests
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
25b5d24867 Fix is_array assertion in integration tests
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
1d99ff0943 Fix all is_string assertions in integration tests
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
99d6d96b05 Fix all is_numeric asserts in integration tests
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
6ddfe2c605 Remove ignores no longer needed
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
d2ec7bba42 Replace instance_of asserts in integration tests
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
2557171953 Fix assert() in lib
[MAILPOET-4258]
2022-11-25 14:32:34 +01:00
0d7e45ea03 Fix filename that is removed by fix-monolog.php
The following error is being thrown when running composer commands:

```
> php fix-monolog.php
rm: cannot remove 'mailpoet/mailpoet/prefixer/../vendor-prefixed/monolog/monolog/src/Monolog/Handler/ElasticSearchHandler.php': No such file or directory
```

This is happening because in commit 9b71a7804c
we updated Monolog from v1 to v2. v2 renamed the file ElasticSearchHandler.php
to ElasticsearchHandler.php (see
4c7795d310).
Note that search is not spelled with a capital S anymore. We didn’t update
fix-monolog.php to reflect this change.

This commit updates fix-monolog.php to use the new file name and to remove
the error.

[MAILPOET-4856]
2022-11-25 13:47:24 +01:00
e677169a51 Update Mysql image for integration and acceptance tests
[MAILPOET-4851]
2022-11-25 13:37:08 +01:00
e268eac378 Add healthcheck for mysql service in the test environment
This is replacement for custom wait scripts and also should ensure
that DB is ready before starting the wordpress serive container,
which was missing the check.
[MAILPOET-4851]
2022-11-25 13:37:08 +01:00
375f2b13c5 Try select option in select 2 multiple times
[MAILPOET-4555]
2022-11-25 13:21:42 +01:00
34406a2f72 Fix flaky WooCommercePurchaseTest
[MAILPOET-4854]
2022-11-25 13:10:30 +01:00
cc658bcc3d Split one big test case into three smaller
[MAILPOET-4846]
2022-11-25 13:04:46 +01:00
973aefe7ae Hide black Friday notice in acceptance tests
[MAILPOET-4846]
2022-11-25 13:04:46 +01:00
34e91251e8 Add waiting on clickable trash button
[MAILPOET-4846]
2022-11-25 13:04:46 +01:00
882402645d Do not wrap automations beta badge, make it a bit smaller
[MAILPOET-4840]
2022-11-25 09:55:11 +01:00
d9d4dccc09 Make instruction on how to test with different PHP versions more generic
This commit just updates the README file so that it doesn't mention
specific PHP versions. This way we don't have to update it every time we
add a new version to the dev environment.

[MAILPOET-4855]
2022-11-25 09:33:39 +01:00
9d2fcccbf5 Add option to run the dev env with PHP 8.2RC6
[MAILPOET-4855]
2022-11-25 09:33:39 +01:00
c4fdd881e6 Retry language updates if they are not scheduled yet
[MAILPOET-4849]
2022-11-24 16:58:18 +01:00
83f7eee8ae Early return to make the migration idempotent
[MAILPOET-4852]
2022-11-24 16:04:29 +01:00
dc1f63d8bb Rename segments migration to be executed again
[MAILPOET-4852]
2022-11-24 16:04:29 +01:00
3e2425abd8 Rewrite segments migration to use helper methods, Doctrine DBAL, and lower number of queries
[MAILPOET-4852]
2022-11-24 16:04:29 +01:00
65e78c7990 Add helper to determine whether a column exists
[MAILPOET-4852]
2022-11-24 16:04:29 +01:00
2bdc5d3683 Add helper to get current table name
[MAILPOET-4852]
2022-11-24 16:04:29 +01:00
1de276378f Use different container names for different parallel runs
[MAILPOET-4851]
2022-11-24 15:48:43 +01:00
cc76fe77f0 Ensure that docker caching on CircleCi is disabled
[MAILPOET-4851]
2022-11-24 13:29:20 +01:00
c8636aac6f Update selenium and chrome image
[MAILPOET-4848]
2022-11-24 10:34:59 +01:00
a09f41143e Update codeception, webdriver and lucatume/browser
[MAILPOET-4848]
2022-11-24 10:34:59 +01:00
8b29694446 Compare scheduledAt with delta 2022-11-24 10:06:59 +01:00
5e0e89408c Test CaptchaFormRenderer
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
86076547c3 Raise aria-live level
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
b1bbabe14d early return when no audioCaptcha element was found
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
f5c678ec2d Initialize session when no ID exists
[MAILPOET-4514]
2022-11-24 09:20:39 +01:00
223625bd9b Use constant for endpoint
[MAILPOET-4514]
2022-11-24 09:20:39 +01:00
fbd7cf8cc7 Use SubscriberEntity instead of the Model
[MAILPOET-4514]
2022-11-24 09:20:39 +01:00
26c7e4d1cc Use null instead of empty string
[MAILPOET-4514]
2022-11-24 09:20:39 +01:00
4832771185 Refactor the captcha system
The current Captcha class has a lot of responsibilities. It renders the captcha
image, can check if a certain captcha type is a Google captcha, if a captcha is
required for a certain email. The SubscriberSubscribeController is not only in
charge of "controlling" the subscription process but also validates, whether a
captcha is correct or not. This architecture made it difficult to extend the
functionality and introduce the audio captcha feature.

Therefore this commit refactors the captcha architecture and tries to seperate
the different concerns into several classes and objects. Validation is now done
by validators.

The CaptchaPhrase now is in charge of keeping the captcha phrase consistent
between the image and the new audio, so that you can renew the captcha and both
captchas are in sync.

[MAILPOET-4514]
2022-11-24 09:20:39 +01:00
7fb8d64628 Rename CaptchaRenderer to CaptchaFormRenderer
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
36fed3bbf8 Enable output of audio captcha when image captcha has not yet been generated
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
8ab738b315 Use classes instead of ids for captcha elements
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
b84b9606e9 Remove type residual from audio captcha url building
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
aa68b7e148 Bust caching when building the audio captcha url
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
ca44339512 Fix typo in button cursor property
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
91f5376dfc Apply prettier
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
d51ef70db6 Add audio assets
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
c164268c20 Change file name to lower case
and codestyle
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
4c7c94c75d Update JavaScript for captcha audio player
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
ccf141b279 Add button icons
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
e42808f22d Update Captcha UI to add audio button
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
75a4b2c538 Add Captcha Audio endpoint to Router
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
f1d64c0572 Add Captcha styles
[MAILPOET-4203]
2022-11-24 09:20:39 +01:00
25c57bf9fe Fix flaky acceptance test for tag filter
[MAILPOET-4844]
2022-11-23 16:38:49 +01:00
079c90dbba Add acceptance test for switching languages
[MAILPOET-4147]
2022-11-23 12:50:32 +01:00
0fc342ee4c Release 4.0.1 2022-11-22 13:57:46 +01:00
1559 changed files with 10080 additions and 4758 deletions

View File

@ -312,6 +312,7 @@ jobs:
working_directory: /home/circleci/mailpoet/mailpoet
machine:
image: ubuntu-2204:2022.10.2
docker_layer_caching: false
parameters:
multisite:
type: integer
@ -322,7 +323,7 @@ jobs:
mysql_command:
type: string
default: ''
mysql_image_version:
mysql_image:
type: string
default: ''
codeception_image_version:
@ -351,7 +352,7 @@ jobs:
default: 0
environment:
MYSQL_COMMAND: << parameters.mysql_command >>
MYSQL_IMAGE_VERSION: << parameters.mysql_image_version >>
MYSQL_IMAGE: << parameters.mysql_image >>
CODECEPTION_IMAGE_VERSION: << parameters.codeception_image_version >>
WORDPRESS_IMAGE_VERSION: << parameters.wordpress_image_version >>
steps:
@ -411,6 +412,12 @@ jobs:
circleci tests glob "tests/acceptance/**/*Cest.php" | circleci tests split --split-by=timings > tests/acceptance/_groups/circleci_split_group
fi
cat tests/acceptance/_groups/circleci_split_group
- run:
name: Create docker containers for test
# We experienced some failures when creating containers so we do it explicitly with one retry
command: |
cd tests/docker
docker-compose create || docker-compose create
- run:
name: Run acceptance tests
command: |
@ -477,8 +484,11 @@ jobs:
working_directory: /home/circleci/mailpoet/mailpoet
machine:
image: ubuntu-2204:2022.10.2
docker_layer_caching: false
environment:
CODECEPTION_IMAGE_VERSION: << parameters.codeception_image_version >>
MYSQL_COMMAND: << parameters.mysql_command >>
MYSQL_IMAGE: << parameters.mysql_image >>
parameters:
codeception_image_version:
type: string
@ -501,6 +511,12 @@ jobs:
multisite:
type: integer
default: 0
mysql_command:
type: string
default: ''
mysql_image:
type: string
default: ''
steps:
- attach_workspace:
at: /home/circleci
@ -618,7 +634,7 @@ workflows:
- build
- acceptance_tests:
<<: *slack-fail-post-step
name: acceptance_tests
name: acceptance_tests_base_and_woo_cot_off
requires:
- unit_tests
- static_analysis_php8
@ -646,28 +662,10 @@ workflows:
- static_analysis_php8
- qa_js
- qa_php
- acceptance_tests:
<<: *slack-fail-post-step
name: acceptance_tests_woo_cot_off
group: woo
requires:
- unit_tests
- static_analysis_php8
- qa_js
- qa_php
- js_tests:
<<: *slack-fail-post-step
requires:
- build
- integration_tests:
<<: *slack-fail-post-step
group: woo
name: integration_test_woocommerce
requires:
- unit_tests
- static_analysis_php8
- qa_js
- qa_php
- integration_tests:
<<: *slack-fail-post-step
group: woo
@ -728,15 +726,13 @@ workflows:
<<: *slack-fail-post-step
requires:
- build
- acceptance_tests
- acceptance_tests_base_and_woo_cot_off
- js_tests
- integration_test_woocommerce
- integration_test_base
- integration_test_woo_cot_no_sync
- integration_test_woo_cot_off
- integration_test_woo_cot_sync
- acceptance_tests_woo_cot_sync
- acceptance_tests_woo_cot_off
- acceptance_tests_woo_cot_no_sync
nightly:
@ -766,8 +762,8 @@ workflows:
woo_subscriptions_version: 4.3.0
woo_memberships_version: 1.21.0
woo_blocks_version: 6.8.0
mysql_command: --max_allowed_packet=100M
mysql_image_version: 5.7.36
mysql_command: --max_allowed_packet=100M --default-storage-engine=MYISAM
mysql_image: mysql:5.5
codeception_image_version: 7.4-cli_20220605.0
wordpress_image_version: wp-5.8_php7.3_20221104.1
requires:
@ -792,6 +788,8 @@ workflows:
<<: *slack-fail-post-step
name: integration_oldest
codeception_image_version: 7.2-cli_20220605.0
mysql_command: --max_allowed_packet=100M --default-storage-engine=MYISAM
mysql_image: mysql:5.5
requires:
- build
- build_premium:

View File

@ -126,23 +126,24 @@ You can access this help in your command line running `./do` without parameters.
[Read the article.](https://mailpoet.atlassian.net/wiki/spaces/MAILPOET/pages/629374977/Adding+new+templates+to+the+plugin)
## 🚥 Testing with PHP 7.4 or PHP 8.0
## 🚥 Testing with different PHP versions
To switch the environment to PHP 7.4/8.0:
To switch the environment to a different PHP version:
1. Configure the `wordpress` service in `docker-compose.override.yml` to build from the php74 Dockerfile:
1. Check https://github.com/mailpoet/mailpoet/tree/trunk/dev for a list of available PHP versions. Each directory starting with `php` corresponds to a available version.
2. Configure the `wordpress` service in `docker-compose.override.yml` to build from the desired PHP version Dockerfile (replace {PHP_VERSION} with the name of the directory that corresponds to the version that you want to use):
```yaml
wordpress:
build:
context: .
dockerfile: dev/php74/Dockerfile # OR dev/php80/Dockerfile
dockerfile: dev/{PHP_VERSION}/Dockerfile
```
2. Run `docker-compose build wordpress`.
3. Start the stack with `./do start`.
3. Run `docker-compose build wordpress`.
4. Start the stack with `./do start`.
To switch back to PHP 8.1 remove what was added in 1) and, run `docker-compose build wordpress` for application container and `docker-compose build test_wordpress` for tests container,
To switch back to the default PHP version remove what was added in 2) and, run `docker-compose build wordpress` for application container and `docker-compose build test_wordpress` for tests container,
and start the stack using `./do start`.
## ✅ TODO

46
dev/php82/Dockerfile Normal file
View File

@ -0,0 +1,46 @@
FROM php:8.2.0RC6-apache
ARG UID=1000
ARG GID=1000
# additinal extensions
RUN apt-get update \
&& apt-get install -y git zlib1g-dev libzip-dev zip wget gnupg msmtp libpng-dev gettext subversion \
&& \
# Install NodeJS, enable Corepack
curl -sL https://deb.nodesource.com/setup_17.x | bash - && \
apt-get install -y nodejs build-essential && \
corepack enable && \
\
# Install WP-CLI
curl -o /usr/local/bin/wp https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar && \
chmod +x /usr/local/bin/wp && \
\
# Clean up
apt-get clean && \
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
COPY dev/php.ini /usr/local/etc/php/conf.d/php_user.ini
# msmtp config
RUN printf "account default\nhost smtp\nport 1025" > /etc/msmtprc
# xdebug build an config
ENV XDEBUGINI_PATH=/usr/local/etc/php/conf.d/xdebug.ini
RUN git clone -b "3.2.0RC2" --depth 1 https://github.com/xdebug/xdebug.git /usr/src/php/ext/xdebug \
&& docker-php-ext-configure xdebug --enable-xdebug-dev \
&& docker-php-ext-install xdebug \
&& mkdir /tmp/debug
COPY dev/xdebug.ini /tmp/xdebug.ini
RUN cat /tmp/xdebug.ini >> $XDEBUGINI_PATH
# php extensions
RUN docker-php-ext-install pdo_mysql
RUN docker-php-ext-install mysqli
# allow .htaccess files (between <Directory /var/www/> and </Directory>, which is WordPress installation)
RUN sed -i '/<Directory \/var\/www\/>/,/<\/Directory>/ s/AllowOverride None/AllowOverride All/' /etc/apache2/apache2.conf
# ensure existing content in /var/www/html respects UID and GID, give Node permissions for Corepack
RUN chown -R ${UID}:${GID} /var/www/html && \
mkdir -p /.node && chown -R ${UID}:${GID} /.node

View File

@ -15,6 +15,7 @@ services:
volumes:
- my-datavolume:/var/lib/mysql
- ./dev/database/create_test_db.sh:/docker-entrypoint-initdb.d/10-create_test_db.sh
command: --sql_mode=STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION,ANSI,ONLY_FULL_GROUP_BY
environment:
MYSQL_ROOT_PASSWORD: somewordpress
MYSQL_DATABASE: wordpress

View File

@ -1,4 +1,4 @@
<?php
<?php // phpcs:ignore SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing
// phpcs:disable PSR1.Classes.ClassDeclaration
// phpcs:disable PSR1.Classes.ClassDeclaration.MissingNamespace
@ -425,6 +425,9 @@ class RoboFile extends \Robo\Tasks {
$collection->addCode(function() {
return $this->qaCodeSniffer([]);
});
$collection->addCode(function() {
return $this->qaMinimalPluginStandard([]);
});
return $collection->run();
}
@ -536,6 +539,55 @@ class RoboFile extends \Robo\Tasks {
$stringFilesToCheck = !empty($filesToCheck) ? implode(' ', $filesToCheck) : '.';
return $this->taskExec($task)
->arg('--ignore=' . implode(',', $ignorePatterns))
->rawArg($stringFilesToCheck)
->run();
}
public function qaMinimalPluginStandard(array $filesToCheck, $opts = ['severity' => 'all']) {
$severityFlag = $opts['severity'] === 'all' ? '-w' : '-n';
$task = implode(' ', [
'php -d memory_limit=-1',
'./tasks/code_sniffer/vendor/bin/phpcs',
'--extensions=php',
$severityFlag,
'--standard=tasks/code_sniffer/vendor/wporg/plugin-directory/MinimalPluginStandard',
'-s',
]);
$ignorePaths = [
'.mp_svn',
'assets',
'doc',
'generated',
'lib/Config/PopulatorData/Templates',
'lib-3rd-party',
'node_modules',
'plugin_repository',
'prefixer/build',
'prefixer/vendor',
'tasks/code_sniffer/vendor',
'tasks/phpstan/vendor',
'tasks/makepot',
'tools/vendor',
'temp',
'tests/_data',
'tests/_output',
'tests/_support/_generated',
'vendor',
'vendor-prefixed',
'views',
];
// the "--ignore" arg takes a list of regexes, we need to anchor and escape them
$ignorePatterns = array_map(function (string $path): string {
return '^' . preg_quote(__DIR__ . DIRECTORY_SEPARATOR . $path);
}, $ignorePaths);
$stringFilesToCheck = !empty($filesToCheck) ? implode(' ', $filesToCheck) : '.';
return $this
->taskExec($task)
->arg('--ignore=' . implode(',', $ignorePatterns))

BIN
mailpoet/assets/audio/0.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/1.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/2.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/3.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/4.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/5.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/6.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/7.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/8.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/9.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/a.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/b.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/c.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/d.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/e.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/f.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/g.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/h.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/i.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/j.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/k.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/l.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/m.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/n.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/o.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/p.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/q.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/r.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/s.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/t.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/u.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/v.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/w.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/x.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/y.mp3 Normal file

Binary file not shown.

BIN
mailpoet/assets/audio/z.mp3 Normal file

Binary file not shown.

View File

@ -36,7 +36,8 @@
input,
select,
textarea {
textarea,
input[type='text'].components-form-token-field__input {
background: right top/26px no-repeat url('../../img/icons/alert.svg');
padding-right: 26px;
}

View File

@ -51,4 +51,8 @@
.mailpoet_form_field_block {
display: block;
}
.mailpoet_form_field_input_nowrap {
white-space: nowrap;
}
}

View File

@ -122,3 +122,21 @@ body .components-modal__screen-overlay {
justify-content: flex-end;
margin-top: $grid-gap-half;
}
.mailpoet-locked-badge {
align-items: center;
background: #fcf9e8;
border: .5px solid #f5e6ab;
border-radius: 4px;
color: #bd8600;
display: flex;
font-size: 11px;
font-weight: 500;
gap: 4px;
height: 20px;
letter-spacing: .2px;
line-height: 16px;
padding: 2px 8px 2px 4px;
text-transform: uppercase;
width: 82px;
}

View File

@ -0,0 +1,11 @@
#mailpoet_landingpage_container {
.mailpoet-content-center {
text-align: center;
}
.landing-footer {
box-shadow: 0 -1px 0 0 $color-tertiary-light;
padding-bottom: 1px;
padding-top: 25px;
}
}

View File

@ -22,6 +22,12 @@
}
}
#mailpoet-wizard-container {
.mailpoet-top-bar {
left: 0;
}
}
.mailpoet-wizard-logo {
margin-bottom: 100px;
text-align: center;
@ -35,6 +41,7 @@
align-items: center;
display: flex;
justify-content: center;
margin-top: 8px;
@include respond-to(medium-screen) {
flex-direction: column;
@ -42,7 +49,7 @@
}
.mailpoet-wizard-step-illustration {
margin-right: $grid-gap;
margin-right: $grid-gap-xl;
max-width: $grid-column;
text-align: center;
width: 100%;
@ -63,12 +70,16 @@
}
.mailpoet-wizard-step-content {
max-width: $grid-column-small + $grid-gap + $grid-column;
max-width: 480px;
width: 100%;
@include respond-to(medium-screen) {
max-width: $grid-column;
}
.mailpoet-button {
height: 36px;
}
}
.mailpoet-wizard-label {
@ -111,12 +122,16 @@
.mailpoet-wizard-woocommerce-option {
align-items: center;
box-shadow: 0 -1px 0 0 $color-tertiary-light;
box-shadow: 0 1px 0 0 $color-tertiary-light;
display: flex;
flex-direction: row-reverse;
justify-content: space-between;
padding-bottom: 25px;
padding-top: 1px;
&:last-child {
box-shadow: 0 0;
}
}
.mailpoet-wizard-note {

View File

@ -0,0 +1,12 @@
.mailpoet_captcha_form {
.mailpoet_icon_button {
background: transparent;
border: 0;
cursor: pointer;
img {
height: 20px;
width: 20px;
}
}
}

View File

@ -112,3 +112,11 @@
max-width: 100%;
width: 100%;
}
.authorize-sender-email-and-domain-modal {
z-index: 30; // overlay other modals
}
.authorize-sender-email-and-domain-modal-overlay {
z-index: $modal-screen-overlay-z-index + 4; // overlay other modals
}

View File

@ -29,7 +29,6 @@ $beamer-dot-size: 8px;
}
.mailpoet-top-bar-logo {
cursor: pointer;
position: relative;
top: 2px;
z-index: 1;
@ -39,6 +38,10 @@ $beamer-dot-size: 8px;
max-width: 100%;
}
}
a.mailpoet-top-bar-logo {
cursor: pointer;
}
}
.mailpoet-top-bar-logo-desktop {

View File

@ -85,3 +85,4 @@
@import 'components-plugin/set-from-address-modal';
@import 'components-plugin/stats';
@import 'components-plugin/import-export';
@import 'components-plugin/landingpage';

View File

@ -19,3 +19,4 @@
@import 'components-public/public';
@import 'components-public/animation';
@import 'components-public/form_colors';
@import 'components-public/captcha';

View File

@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20"><rect x="0" fill="none" width="20" height="20"/><g><path d="M2 7h4l5-4v14l-5-4H2V7zm12.69-2.46C14.82 4.59 18 5.92 18 10s-3.18 5.41-3.31 5.46c-.06.03-.13.04-.19.04-.2 0-.39-.12-.46-.31-.11-.26.02-.55.27-.65.11-.05 2.69-1.15 2.69-4.54 0-3.41-2.66-4.53-2.69-4.54-.25-.1-.38-.39-.27-.65.1-.25.39-.38.65-.27zM16 10c0 2.57-2.23 3.43-2.32 3.47-.06.02-.12.03-.18.03-.2 0-.39-.12-.47-.32-.1-.26.04-.55.29-.65.07-.02 1.68-.67 1.68-2.53s-1.61-2.51-1.68-2.53c-.25-.1-.38-.39-.29-.65.1-.25.39-.39.65-.29.09.04 2.32.9 2.32 3.47z"/></g></svg>

After

Width:  |  Height:  |  Size: 587 B

View File

@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20"><rect x="0" fill="none" width="20" height="20"/><g><path d="M10.25 1.02c5.1 0 8.75 4.04 8.75 9s-3.65 9-8.75 9c-3.2 0-6.02-1.59-7.68-3.99l2.59-1.52c1.1 1.5 2.86 2.51 4.84 2.51 3.3 0 6-2.79 6-6s-2.7-6-6-6c-1.97 0-3.72 1-4.82 2.49L7 8.02l-6 2v-7L2.89 4.6c1.69-2.17 4.36-3.58 7.36-3.58z"/></g></svg>

After

Width:  |  Height:  |  Size: 355 B

View File

@ -1,12 +1,10 @@
import { useState, Fragment } from 'react';
import { DropdownMenu } from '@wordpress/components';
import { useSelect } from '@wordpress/data';
import { moreVertical, trash } from '@wordpress/icons';
import { __ } from '@wordpress/i18n';
import { Hooks } from 'wp-js-hooks';
import { PremiumModal } from 'common/premium_modal';
import { Step as StepData } from './types';
import { storeName } from '../../store';
import { StepMoreControlsType } from '../../../types/filters';
type Props = {
@ -14,12 +12,6 @@ type Props = {
};
export function StepMoreMenu({ step }: Props): JSX.Element {
const { stepType } = useSelect(
(select) => ({
stepType: select(storeName).getStepType(step.key),
}),
[step],
);
const [showModal, setShowModal] = useState(false);
const moreControls: StepMoreControlsType = Hooks.applyFilters(
@ -53,7 +45,6 @@ export function StepMoreMenu({ step }: Props): JSX.Element {
},
},
step,
stepType,
);
const slots = Object.values(moreControls).filter(

View File

@ -21,7 +21,7 @@ const Dropdown: ComponentType<
}
> = WpDropdown;
export function DocumentActions({ children }): JSX.Element {
function DocumentActions({ children }): JSX.Element {
const { automationName, automationStatus, showIconLabels } = useSelect(
(select) => ({
automationName: select(storeName).getAutomationData().name,
@ -101,3 +101,6 @@ export function DocumentActions({ children }): JSX.Element {
</div>
);
}
DocumentActions.displayName = 'DocumentActions';
export { DocumentActions };

View File

@ -9,6 +9,7 @@ import {
import { useDispatch, useSelect } from '@wordpress/data';
import { createContext } from '@wordpress/element';
import { __ } from '@wordpress/i18n';
import { ErrorBoundary } from 'common';
import { Chip } from '../chip';
import { ColoredIcon } from '../icons';
import {
@ -70,6 +71,8 @@ function StepError({ stepId }: StepErrorProps): JSX.Element {
);
}
StepError.displayName = 'StepError';
export function Errors(): JSX.Element | null {
const [showPopover, setShowPopover] = useState(false);
@ -160,9 +163,11 @@ export function Errors(): JSX.Element | null {
__('The following steps are not fully set:', 'mailpoet')
}
</div>
{stepErrors.map((error) => (
<StepError key={error.step_id} stepId={error.step_id} />
))}
<ErrorBoundary>
{stepErrors.map((error) => (
<StepError key={error.step_id} stepId={error.step_id} />
))}
</ErrorBoundary>
</Composite>
</ErrorsCompositeContext.Provider>
</Popover>

View File

@ -8,6 +8,7 @@ import {
import { dispatch, useDispatch, useSelect } from '@wordpress/data';
import { PinnedItems } from '@wordpress/interface';
import { __ } from '@wordpress/i18n';
import { ErrorBoundary } from 'common';
import { DocumentActions } from './document_actions';
import { Errors } from './errors';
import { InserterToggle } from './inserter_toggle';
@ -227,28 +228,32 @@ export function Header({ showInserterToggle }: Props): JSX.Element {
</div>
<div className="edit-site-header_center">
<DocumentActions>
{() => (
<div className="mailpoet-automation-editor-dropdown-name-edit">
<div className="mailpoet-automation-editor-dropdown-name-edit-title">
{__('Automation name', 'mailpoet')}
<ErrorBoundary>
<DocumentActions>
{() => (
<div className="mailpoet-automation-editor-dropdown-name-edit">
<div className="mailpoet-automation-editor-dropdown-name-edit-title">
{__('Automation name', 'mailpoet')}
</div>
<TextControl
value={automationName}
onChange={(newName) => setAutomationName(newName)}
help={__(
`Give the automation a name that indicates its purpose. E.g. "Abandoned cart recovery"`,
'mailpoet',
)}
/>
</div>
<TextControl
value={automationName}
onChange={(newName) => setAutomationName(newName)}
help={__(
`Give the automation a name that indicates its purpose. E.g. "Abandoned cart recovery"`,
'mailpoet',
)}
/>
</div>
)}
</DocumentActions>
)}
</DocumentActions>
</ErrorBoundary>
</div>
<div className="edit-site-header_end">
<div className="edit-site-header__actions">
<Errors />
<ErrorBoundary>
<Errors />
</ErrorBoundary>
{automationStatus === AutomationStatus.DRAFT && (
<>
<SaveDraftButton />

View File

@ -0,0 +1,2 @@
export * from './panel';
export * from './form-token-field';

View File

@ -45,7 +45,7 @@ export function InserterPopover(): JSX.Element | null {
}
}}
>
<Inserter onInsert={onInsert} />
<Inserter onInsert={onInsert} showInserterHelpPanel={false} />
</Popover>
{showModal && (

View File

@ -20,134 +20,139 @@ const filterItems = (value: string, item: Item[]): Item[] =>
type Props = {
onInsert?: (item: Item) => void;
showInserterHelpPanel?: boolean;
};
export const Inserter = forwardRef(({ onInsert }: Props, ref): JSX.Element => {
const [filterValue, setFilterValue] = useState('');
const [hoveredItem, setHoveredItem] = useState(null);
export const Inserter = forwardRef(
({ onInsert, showInserterHelpPanel = true }: Props, ref): JSX.Element => {
const [filterValue, setFilterValue] = useState('');
const [hoveredItem, setHoveredItem] = useState(null);
const { steps, type } = useSelect(
(select) => ({
steps: select(storeName).getSteps(),
type: select(storeName).getInserterPopover().type,
}),
[],
);
const { steps, type } = useSelect(
(select) => ({
steps: select(storeName).getSteps(),
type: select(storeName).getInserterPopover().type,
}),
[],
);
const groups: Group[] = useMemo(
() =>
type === 'triggers'
? [
{
type: 'triggers',
title: undefined,
// translators: Label for a list of automation steps of type trigger
label: _x('Triggers', 'automation steps', 'mailpoet'),
items: steps.filter(({ group }) => group === 'triggers'),
},
]
: [
{
type: 'actions',
// translators: Label for a list of automation steps of type action
title: _x('Actions', 'automation steps', 'mailpoet'),
// translators: Label for a list of automation steps of type action
label: _x('Actions', 'automation steps', 'mailpoet'),
items: steps.filter(({ group }) => group === 'actions'),
},
{
type: 'logical',
// translators: Label for a list of logical automation steps (if/else, etc.)
title: _x('Logical', 'automation steps', 'mailpoet'),
// translators: Label for a list of logical automation steps (if/else, etc.)
label: _x('Logical', 'automation steps', 'mailpoet'),
items: steps.filter(({ group }) => group === 'logical'),
},
],
[steps, type],
);
const groups: Group[] = useMemo(
() =>
type === 'triggers'
? [
{
type: 'triggers',
title: undefined,
// translators: Label for a list of automation steps of type trigger
label: _x('Triggers', 'automation steps', 'mailpoet'),
items: steps.filter(({ group }) => group === 'triggers'),
},
]
: [
{
type: 'actions',
// translators: Label for a list of automation steps of type action
title: _x('Actions', 'automation steps', 'mailpoet'),
// translators: Label for a list of automation steps of type action
label: _x('Actions', 'automation steps', 'mailpoet'),
items: steps.filter(({ group }) => group === 'actions'),
},
{
type: 'logical',
// translators: Label for a list of logical automation steps (if/else, etc.)
title: _x('Logical', 'automation steps', 'mailpoet'),
// translators: Label for a list of logical automation steps (if/else, etc.)
label: _x('Logical', 'automation steps', 'mailpoet'),
items: steps.filter(({ group }) => group === 'logical'),
},
],
[steps, type],
);
const onHover = useCallback(
(item) => {
setHoveredItem(item);
},
[setHoveredItem],
);
const onHover = useCallback(
(item) => {
setHoveredItem(item);
},
[setHoveredItem],
);
const searchRef = useRef<HTMLInputElement>();
useImperativeHandle(ref, () => ({
focusSearch: () => {
searchRef.current?.focus();
},
}));
const searchRef = useRef<HTMLInputElement>();
useImperativeHandle(ref, () => ({
focusSearch: () => {
searchRef.current?.focus();
},
}));
const filteredGroups = useMemo(
() =>
groups.map((group) => ({
...group,
items: filterItems(filterValue, group.items),
})),
[filterValue, groups],
);
const filteredGroups = useMemo(
() =>
groups.map((group) => ({
...group,
items: filterItems(filterValue, group.items),
})),
[filterValue, groups],
);
return (
<div className="block-editor-inserter__menu">
<div className="block-editor-inserter__main-area">
<div className="block-editor-inserter__content">
<SearchControl
className="block-editor-inserter__search"
onChange={(value: string) => {
if (hoveredItem) setHoveredItem(null);
setFilterValue(value);
}}
value={filterValue}
label={__('Search for automation steps', 'mailpoet')}
placeholder={__('Search', 'mailpoet')}
ref={searchRef}
/>
return (
<div className="block-editor-inserter__menu">
<div className="block-editor-inserter__main-area">
<div className="block-editor-inserter__content">
<SearchControl
className="block-editor-inserter__search"
onChange={(value: string) => {
if (hoveredItem) setHoveredItem(null);
setFilterValue(value);
}}
value={filterValue}
label={__('Search for automation steps', 'mailpoet')}
placeholder={__('Search', 'mailpoet')}
ref={searchRef}
/>
<div className="block-editor-inserter__block-list">
<InserterListbox>
{filteredGroups.map(
(group) =>
group.items.length > 0 && (
<Fragment key={group.type}>
{group.title && (
<div className="block-editor-inserter__panel-header">
<h2 className="block-editor-inserter__panel-title">
<div>{group.title}</div>
</h2>
<div className="block-editor-inserter__block-list">
<InserterListbox>
{filteredGroups.map(
(group) =>
group.items.length > 0 && (
<Fragment key={group.type}>
{group.title && (
<div className="block-editor-inserter__panel-header">
<h2 className="block-editor-inserter__panel-title">
<div>{group.title}</div>
</h2>
</div>
)}
<div className="block-editor-inserter__panel-content">
<StepList
items={group.items}
onHover={onHover}
onSelect={(item: Item) => onInsert(item)}
label={group.label}
/>
</div>
)}
<div className="block-editor-inserter__panel-content">
<StepList
items={group.items}
onHover={onHover}
onSelect={(item: Item) => onInsert(item)}
label={group.label}
/>
</div>
</Fragment>
),
)}
</Fragment>
),
)}
{filteredGroups.reduce(
(sum, { items }) => sum + items.length,
0,
) === 0 && (
<div className="block-editor-inserter__no-results">
<Icon
className="block-editor-inserter__no-results-icon"
icon={blockDefault}
/>
<p>{__('No results found.', 'mailpoet')}</p>
</div>
)}
</InserterListbox>
{filteredGroups.reduce(
(sum, { items }) => sum + items.length,
0,
) === 0 && (
<div className="block-editor-inserter__no-results">
<Icon
className="block-editor-inserter__no-results-icon"
icon={blockDefault}
/>
<p>{__('No results found.', 'mailpoet')}</p>
</div>
)}
</InserterListbox>
</div>
</div>
</div>
{showInserterHelpPanel && hoveredItem && (
<StepInfoPanel item={hoveredItem} />
)}
</div>
{hoveredItem && <StepInfoPanel item={hoveredItem} />}
</div>
);
});
);
},
);

View File

@ -1,7 +1,10 @@
import { dispatch } from '@wordpress/data';
import { Hooks } from 'wp-js-hooks';
import { storeName } from './constants';
import { StepType } from './types';
export const registerStepType = (stepType: StepType): void => {
dispatch(storeName).registerStepType(stepType);
dispatch(storeName).registerStepType(
Hooks.applyFilters('mailpoet.automation.register_step_type', stepType),
);
};

View File

@ -19,7 +19,7 @@ export const step: StepType = {
foreground: '#7F54B3',
background: '#f7edf7',
description: __(
'Wait some time before proceeding with the steps below',
'Wait some time before proceeding with the steps below.',
'mailpoet',
),
subtitle: (data): string => {

View File

@ -2,11 +2,19 @@ import { registerStepType } from '../../editor/store';
import { step as SendEmailStep } from './steps/send_email';
import { step as SomeoneSubscribesTrigger } from './steps/someone-subscribes';
import { step as WpUserRegisteredTrigger } from './steps/wp-user-registered';
import { step as AddTagsAction } from './steps/add_tags';
import { step as RemoveTagsAction } from './steps/remove_tags';
import { step as AddToListStep } from './steps/add_to_list';
import { step as RemoveFromListStep } from './steps/remove_from_list';
import { registerStepControls } from './step-controls';
export const initialize = (): void => {
registerStepType(SendEmailStep);
registerStepType(WpUserRegisteredTrigger);
registerStepType(SomeoneSubscribesTrigger);
registerStepType(AddTagsAction);
registerStepType(RemoveTagsAction);
registerStepType(AddToListStep);
registerStepType(RemoveFromListStep);
registerStepControls();
};

View File

@ -2,7 +2,6 @@ import { __ } from '@wordpress/i18n';
import { chartBar } from '@wordpress/icons';
import { Hooks } from 'wp-js-hooks';
import { MoreControlType, StepMoreControlsType } from '../../../types/filters';
import { StepType } from '../../../editor/store';
import { Step } from '../../../editor/components/automation/types';
const emailStatisticsControl = (step: Step): MoreControlType => {
@ -30,12 +29,8 @@ export function registerStepControls() {
Hooks.addFilter(
'mailpoet.automation.step.more-controls',
'mailpoet',
(
controls: StepMoreControlsType,
step: Step,
stepType: StepType,
): StepMoreControlsType => {
if (stepType.key === 'mailpoet:send-email') {
(controls: StepMoreControlsType, step: Step): StepMoreControlsType => {
if (step.key === 'mailpoet:send-email') {
return {
statistics: emailStatisticsControl(step),
...controls,

View File

@ -0,0 +1,28 @@
import { __ } from '@wordpress/i18n';
import { tag } from '@wordpress/icons';
import { StepType } from '../../../../editor/store';
import { LockedBadge } from '../../../../../common/premium_modal/locked_badge';
import { PremiumModalForStepEdit } from '../../../../../common/premium_modal';
export const step: StepType = {
key: 'mailpoet:add-tag',
group: 'actions',
title: __('Add tag', 'mailpoet'),
description: __('Add a tag or multiple tags to a subscriber.', 'mailpoet'),
subtitle: () => <LockedBadge text={__('Premium', 'mailpoet')} />,
foreground: '#00A32A',
background: '#EDFAEF',
icon: () => (
<div style={{ width: '100%', height: '100%', scale: '1.4' }}>{tag}</div>
),
edit: () => (
<PremiumModalForStepEdit
tracking={{
utm_medium: 'upsell_modal',
utm_campaign: 'create_automation_editor_add_tag',
}}
>
{__('Adding tags is a premium feature.', 'mailpoet')}
</PremiumModalForStepEdit>
),
} as const;

View File

@ -0,0 +1,28 @@
import { __ } from '@wordpress/i18n';
import { list } from '@wordpress/icons';
import { StepType } from '../../../../editor/store/types';
import { PremiumModalForStepEdit } from '../../../../../common/premium_modal';
import { LockedBadge } from '../../../../../common/premium_modal/locked_badge';
export const step: StepType = {
key: 'mailpoet:add-to-list',
group: 'actions',
title: __('Add to list', 'mailpoet'),
description: __('Add a subscriber to a list.', 'mailpoet'),
subtitle: () => <LockedBadge text={__('Premium', 'mailpoet')} />,
foreground: '#00A32A',
background: '#EDFAEF',
icon: () => (
<div style={{ width: '100%', height: '100%', scale: '1.12' }}>{list}</div>
),
edit: () => (
<PremiumModalForStepEdit
tracking={{
utm_medium: 'upsell_modal',
utm_campaign: 'create_automation_editor_add_to_list',
}}
>
{__('Adding subscribers to lists is a premium feature.', 'mailpoet')}
</PremiumModalForStepEdit>
),
} as const;

View File

@ -0,0 +1,28 @@
import { __ } from '@wordpress/i18n';
import { list } from '@wordpress/icons';
import { StepType } from '../../../../editor/store/types';
import { PremiumModalForStepEdit } from '../../../../../common/premium_modal';
import { LockedBadge } from '../../../../../common/premium_modal/locked_badge';
export const step: StepType = {
key: 'mailpoet:remove-from-list',
group: 'actions',
title: __('Remove from list', 'mailpoet'),
description: __('Remove a subscriber from a list.', 'mailpoet'),
subtitle: () => <LockedBadge text={__('Premium', 'mailpoet')} />,
foreground: '#00A32A',
background: '#EDFAEF',
icon: () => (
<div style={{ width: '100%', height: '100%', scale: '1.12' }}>{list}</div>
),
edit: () => (
<PremiumModalForStepEdit
tracking={{
utm_medium: 'upsell_modal',
utm_campaign: 'create_automation_editor_remove_from_list',
}}
>
{__('Removing subscribers from lists is a premium feature.', 'mailpoet')}
</PremiumModalForStepEdit>
),
} as const;

View File

@ -0,0 +1,31 @@
import { __ } from '@wordpress/i18n';
import { tag } from '@wordpress/icons';
import { StepType } from '../../../../editor/store';
import { LockedBadge } from '../../../../../common/premium_modal/locked_badge';
import { PremiumModalForStepEdit } from '../../../../../common/premium_modal';
export const step: StepType = {
key: 'mailpoet:remove-tag',
group: 'actions',
title: __('Remove tag', 'mailpoet'),
description: __(
'Remove a tag or multiple tags from a subscriber.',
'mailpoet',
),
subtitle: () => <LockedBadge text={__('Premium', 'mailpoet')} />,
foreground: '#00A32A',
background: '#EDFAEF',
icon: () => (
<div style={{ width: '100%', height: '100%', scale: '1.4' }}>{tag}</div>
),
edit: () => (
<PremiumModalForStepEdit
tracking={{
utm_medium: 'upsell_modal',
utm_campaign: 'create_automation_editor_remove_tag',
}}
>
{__('Removing tags is a premium feature.', 'mailpoet')}
</PremiumModalForStepEdit>
),
} as const;

View File

@ -9,7 +9,7 @@ export const step: StepType = {
key: 'mailpoet:send-email',
group: 'actions',
title: __('Send email', 'mailpoet'),
description: __('An email will be sent to subscriber', 'mailpoet'),
description: __('An email will be sent to subscriber.', 'mailpoet'),
subtitle: (data) =>
(data.args.name as string) ?? __('Send email', 'mailpoet'),
foreground: '#996800',

View File

@ -3,8 +3,10 @@ import { dispatch, useSelect } from '@wordpress/data';
import { __ } from '@wordpress/i18n';
import { storeName } from '../../../../../editor/store';
import { segments } from './segment';
import { PlainBodyTitle } from '../../../../../editor/components/panel';
import { FormTokenField } from '../../../components/form-token-field';
import {
PlainBodyTitle,
FormTokenField,
} from '../../../../../editor/components';
export function ListPanel(): JSX.Element {
const { selectedStep } = useSelect(

View File

@ -1,4 +1,4 @@
import { FormTokenItem } from '../../../components/form-token-field';
import { FormTokenItem } from '../../../../../editor/components';
type Segment = FormTokenItem & {
type: string;

View File

@ -1,4 +1,4 @@
import { FormTokenItem } from '../../../components/form-token-field';
import { FormTokenItem } from '../../../../../editor/components';
declare global {
interface Window {

View File

@ -3,9 +3,11 @@ import { dispatch, useSelect } from '@wordpress/data';
import { __ } from '@wordpress/i18n';
import ReactStringReplace from 'react-string-replace';
import { storeName } from '../../../../../editor/store';
import { PlainBodyTitle } from '../../../../../editor/components/panel';
import {
PlainBodyTitle,
FormTokenField,
} from '../../../../../editor/components';
import { userRoles } from './role';
import { FormTokenField } from '../../../components/form-token-field';
function SettingsInfoText(): JSX.Element {
return (

View File

@ -92,6 +92,7 @@ function AuthorizeSenderEmailAndDomainModal({
<Modal
onRequestClose={onRequestClose}
contentClassName="authorize-sender-email-and-domain-modal"
overlayClassName="authorize-sender-email-and-domain-modal-overlay"
>
<Tabs activeKey={initialTab}>
<Tab

View File

@ -6,7 +6,7 @@ type Props = {
active: string;
};
export function Categories({ onSelect, categories, active }: Props) {
function Categories({ onSelect, categories, active }: Props) {
const cats = categories.map((category) => (
<CategoriesItem
{...category}
@ -18,3 +18,6 @@ export function Categories({ onSelect, categories, active }: Props) {
return <div className="mailpoet-categories">{cats}</div>;
}
Categories.displayName = 'Categories';
export { Categories };

View File

@ -1,6 +1,7 @@
import classnames from 'classnames';
import ReactDatePicker, { ReactDatePickerProps } from 'react-datepicker';
import { MailPoet } from 'mailpoet';
import { withBoundary } from '../error_boundary';
type Props = ReactDatePickerProps & {
dimension?: 'small';
@ -9,7 +10,7 @@ type Props = ReactDatePickerProps & {
iconEnd?: JSX.Element;
};
export function Datepicker({
function Datepicker({
dimension,
isFullWidth,
iconStart,
@ -34,3 +35,8 @@ export function Datepicker({
</div>
);
}
Datepicker.displayName = 'Datepicker';
const DatepickerWithBoundary = withBoundary(Datepicker);
export { DatepickerWithBoundary as Datepicker };

View File

@ -0,0 +1,68 @@
import { Children, Component } from '@wordpress/element';
import { ComponentType } from 'react';
import { getComponentDisplayName } from './utils';
type ErrorBoundaryState = {
hasError: boolean;
error?: string;
};
export type ErrorBoundaryProps = {
onError?: (Error_Boundary_State) => ComponentType;
};
export class ErrorBoundary extends Component<
ErrorBoundaryProps,
ErrorBoundaryState
> {
constructor(props: ErrorBoundaryProps) {
super(props);
this.state = {
hasError: false,
error: '',
};
}
static getDerivedStateFromError(error: Error & { fileName?: string }) {
return {
hasError: true,
error: `${error?.toString()} \nFile name: ${
error?.fileName ?? 'No fileName reported'
} \nStack trace: ${error?.stack ?? 'No stack trace reported'}`,
};
}
componentDidCatch(error, errorInfo) {
// eslint-disable-next-line no-console
console.log('logging', { error, errorInfo });
}
render() {
const { onError } = this.props;
const { hasError, error } = this.state;
if (hasError) {
if (onError) {
return onError(this.state);
}
return (
<>
<h1>
The application{' '}
<strong>
{Children.map(this.props.children, (child) =>
getComponentDisplayName(child as ComponentType),
).join(', ')}{' '}
</strong>
encountered an error
</h1>
<p>
Please report the following error to{' '}
<a href="https://www.mailpoet.com/support/">MailPoet support</a>
</p>
<pre>{error}</pre>
</>
);
}
return this.props.children;
}
}

View File

@ -0,0 +1,3 @@
export * from './utils';
export * from './error_boundary';
export * from './with_boundary';

View File

@ -0,0 +1,4 @@
import { ComponentType } from 'react';
export const getComponentDisplayName = (component: ComponentType): string =>
component.displayName || component.name || 'Unknown application/component';

View File

@ -0,0 +1,14 @@
import { ComponentType, JSXElementConstructor } from 'react';
import { ErrorBoundary, ErrorBoundaryProps } from './error_boundary';
export const withBoundary = <P extends Record<string, unknown> | unknown>(
Bound: JSXElementConstructor<P>,
props?: ErrorBoundaryProps,
): ComponentType<P> =>
function bounder(boundProps: P) {
return (
<ErrorBoundary {...props}>
<Bound {...boundProps} />
</ErrorBoundary>
);
};

View File

@ -7,7 +7,7 @@ type Props = InputHTMLAttributes<HTMLInputElement> & {
automationId?: string;
};
export function Toggle({
function Toggle({
dimension,
onCheck,
automationId,
@ -33,3 +33,7 @@ export function Toggle({
</label>
);
}
Toggle.displayName = 'FormToggle';
export { Toggle };

View File

@ -7,3 +7,4 @@ export * from './loading';
export * from './form';
export * from './tag';
export * from './listings';
export * from './error_boundary';

View File

@ -63,7 +63,7 @@ type NewsletterStatusProps = {
status?: string;
};
export function NewsletterStatus({
function NewsletterStatus({
scheduledFor,
processed,
total,
@ -150,3 +150,6 @@ export function NewsletterStatus({
</div>
);
}
NewsletterStatus.displayName = 'NewsletterStatus';
export { NewsletterStatus };

View File

@ -1,8 +1,9 @@
import { useEffect } from 'react';
import { useSelect } from '@wordpress/data';
import { MailPoet } from 'mailpoet';
import { withBoundary } from '../error_boundary';
export function UnsavedChangesNotice({ storeName }) {
function UnsavedChangesNotice({ storeName }) {
const hasUnsavedChanges = useSelect(
(sel) => sel(storeName).hasUnsavedChanges(),
[],
@ -24,3 +25,7 @@ export function UnsavedChangesNotice({ storeName }) {
return null;
}
UnsavedChangesNotice.displayName = 'UnsavedChangesNotice';
const UnsavedChangesNoticeWithBoundary = withBoundary(UnsavedChangesNotice);
export { UnsavedChangesNoticeWithBoundary as UnsavedChangesNotice };

View File

@ -13,6 +13,7 @@ import {
Button,
Modal,
} from '@wordpress/components';
import { dispatch } from '@wordpress/data';
import { __ } from '@wordpress/i18n';
import { MailPoet } from 'mailpoet';
import {
@ -21,6 +22,8 @@ import {
useUpgradeInfo,
UtmParams,
} from './upgrade_info';
import { storeName } from '../../automation/editor/store';
import { withBoundary } from '../error_boundary';
export const premiumValidAndActive =
premiumFeaturesEnabled && MailPoet.premiumActive;
@ -49,11 +52,7 @@ const getCta = (state: State, upgradeInfo: UpgradeInfo): string => {
return cta;
};
export function PremiumModal({
children,
tracking,
...props
}: Props): JSX.Element {
function PremiumModal({ children, tracking, ...props }: Props): JSX.Element {
const [state, setState] = useState<State>();
const upgradeInfo = useUpgradeInfo(tracking);
@ -126,3 +125,44 @@ export function PremiumModal({
</Modal>
);
}
PremiumModal.displayName = 'PremiumModal';
type EditProps = Omit<Props, 'onRequestClose'>;
function PremiumModalForStepEdit({
children,
...props
}: EditProps): JSX.Element {
const [showModal, setShowModal] = useState(true);
useEffect(() => {
if (showModal) {
return;
}
const { selectStep } = dispatch(storeName);
selectStep(undefined);
setShowModal(true);
}, [showModal]);
if (!showModal) {
return null;
}
return (
<PremiumModal
onRequestClose={() => {
setShowModal(false);
}}
{...props}
>
{children}
</PremiumModal>
);
}
PremiumModalForStepEdit.displayName = 'PremiumModalForStepEdit';
const PremiumModalForStepEditWithBoundary = withBoundary(
PremiumModalForStepEdit,
);
export {
PremiumModal,
PremiumModalForStepEditWithBoundary as PremiumModalForStepEdit,
};

View File

@ -0,0 +1,31 @@
const lockIcon = (
<svg
width="12"
height="12"
viewBox="0 0 12 12"
fill="none"
xmlns="http://www.w3.org/2000/svg"
>
<g clipPath="url(#clip0_1896_34966)">
<path
fillRule="evenodd"
clipRule="evenodd"
d="M6 1.625C4.96447 1.625 4.125 2.46447 4.125 3.5V5H3.5C3.22386 5 3 5.22386 3 5.5V9.5C3 9.77614 3.22386 10 3.5 10H8.5C8.77614 10 9 9.77614 9 9.5V5.5C9 5.22386 8.77614 5 8.5 5H7.875V3.5C7.875 2.46447 7.03553 1.625 6 1.625ZM7.125 5V3.5C7.125 2.87868 6.62132 2.375 6 2.375C5.37868 2.375 4.875 2.87868 4.875 3.5V5H7.125Z"
fill="#BD8600"
/>
</g>
<defs>
<clipPath id="clip0_1896_34966">
<rect width="12" height="12" fill="white" />
</clipPath>
</defs>
</svg>
);
export function LockedBadge({ text }): JSX.Element {
return (
<span className="mailpoet-locked-badge">
{lockIcon} {text}
</span>
);
}

View File

@ -77,5 +77,5 @@ Preview.defaultProps = {
onDisplayTypeChange: () => {},
selectedDisplayType: 'desktop',
};
Preview.displayName = 'FormEditorPreview';
export { Preview };

View File

@ -1,5 +1,6 @@
import { useEffect } from 'react';
import { withRouter } from 'react-router-dom';
import { withBoundary } from './error_boundary';
function ScrollToTopComponent({ children, location: { pathname } }) {
useEffect(() => {
@ -9,4 +10,5 @@ function ScrollToTopComponent({ children, location: { pathname } }) {
return children || null;
}
export const ScrollToTop = withRouter(ScrollToTopComponent);
ScrollToTopComponent.displayName = 'ScrollToTopComponent';
export const ScrollToTop = withRouter(withBoundary(ScrollToTopComponent));

View File

@ -163,5 +163,5 @@ SenderEmailAddressWarning.defaultProps = {
showSenderDomainWarning: false,
onSuccessfulEmailOrDomainAuthorization: noop,
};
SenderEmailAddressWarning.displayName = 'SenderEmailAddressWarning';
export { SenderEmailAddressWarning };

View File

@ -1,5 +1,6 @@
import range from 'lodash/range';
import classnames from 'classnames';
import { withBoundary } from 'common';
import { ContentWrapperFix } from './content_wrapper_fix';
type Props = {
@ -8,7 +9,7 @@ type Props = {
titles?: string[];
};
function Steps({ count, current, titles }: Props) {
function StepsComponent({ count, current, titles }: Props) {
return (
<div className="mailpoet-steps">
<ContentWrapperFix />
@ -35,8 +36,9 @@ function Steps({ count, current, titles }: Props) {
);
}
Steps.defaultProps = {
StepsComponent.defaultProps = {
titles: [],
};
StepsComponent.displayName = 'StepsComponent';
const Steps = withBoundary(StepsComponent);
export { Steps };

View File

@ -10,7 +10,7 @@ import {
} from 'react-router-dom';
import { noop } from 'lodash';
import { Tabs, Props as TabProps } from './tabs';
import { Props as TabProps, Tabs } from './tabs';
function RouterAwareTabs(
props: TabProps & {
@ -105,4 +105,6 @@ function RoutedTabs({
);
}
RoutedTabs.displayName = 'RoutedTabs';
export { RoutedTabs };

View File

@ -1,5 +1,5 @@
import { Heading } from 'common/typography/heading/heading';
import { Tags } from '../tags';
import { SegmentTags, StringTags } from '../tags';
export default {
title: 'Tags',
@ -18,15 +18,20 @@ export function Segments() {
<>
<Heading level={1}>Tags</Heading>
<Heading level={2}>Segments</Heading>
<Tags segments={segments} dimension="large" />
<SegmentTags segments={segments} dimension="large" />
<div className="mailpoet-gap" />
<Tags segments={segments}>
<SegmentTags segments={segments}>
<span>Prefix: </span>
</Tags>
</SegmentTags>
<Heading level={2}>Strings</Heading>
<Tags strings={strings} dimension="large" variant="good" />
<StringTags strings={strings} dimension="large" variant="good" />
<div className="mailpoet-gap" />
<Tags strings={strings} dimension="large" variant="good" isInverted />
<StringTags
strings={strings}
dimension="large"
variant="good"
isInverted
/>
</>
);
}

View File

@ -3,11 +3,36 @@ import { Tag, TagVariant } from './tag';
import { Tooltip } from '../tooltip/tooltip';
import { MailPoet } from '../../mailpoet';
type SharedTagProps = {
children?: ReactNode;
dimension?: 'large';
variant?: TagVariant;
isInverted?: boolean;
};
type TagData = {
name: string;
target?: string;
tooltip?: string;
};
type TagProps = SharedTagProps & {
tags: TagData[];
};
type StringTagsProps = SharedTagProps & {
strings: string[];
};
type Segment = {
name: string;
id?: string;
};
type SegmentTagsProps = SharedTagProps & {
segments: Segment[];
};
type SubscriberTag = {
id: string;
name: string;
@ -15,99 +40,96 @@ type SubscriberTag = {
tag_id: string;
};
type Props = {
children?: ReactNode;
dimension?: 'large';
segments?: Segment[];
subscriberTags?: SubscriberTag[];
strings?: string[];
variant?: TagVariant;
isInverted?: boolean;
type SubscriberTagsProps = SharedTagProps & {
subscribers: SubscriberTag[];
};
function Tags({
children,
dimension,
segments,
subscriberTags,
strings,
variant,
isInverted,
}: Props) {
function Tags({ children, tags, dimension, variant, isInverted }: TagProps) {
return (
<div className="mailpoet-tags">
{children}
{segments &&
segments.map((segment) => {
const tag = (
<Tag key={segment.name} dimension={dimension} variant="list">
{segment.name}
</Tag>
);
if (!segment.id) {
return tag;
}
const randomId = Math.random().toString(36).substring(2, 15);
const tooltipId = `segment-tooltip-${randomId}`;
return (
<div key={randomId}>
<Tooltip id={tooltipId} place="top">
{MailPoet.I18n.t('viewFilteredSubscribersMessage')}
</Tooltip>
<a
data-tip=""
data-for={tooltipId}
href={`admin.php?page=mailpoet-subscribers#/filter[segment=${segment.id}]`}
>
{tag}
</a>
</div>
);
})}
{subscriberTags &&
subscriberTags.map((subscriberTag) => {
const randomId = Math.random().toString(36).substring(2, 15);
const tooltipId = `tag-tooltip-${randomId}`;
const tag = (
<Tag
key={subscriberTag.name}
dimension={dimension}
variant={variant || 'list'}
isInverted={isInverted}
>
{subscriberTag.name}
</Tag>
);
return (
<div key={randomId}>
<Tooltip id={tooltipId} place="top">
{MailPoet.I18n.t('viewFilteredSubscribersMessage')}
</Tooltip>
<a
data-tip=""
data-for={tooltipId}
href={`admin.php?page=mailpoet-subscribers#/filter[tag=${subscriberTag.tag_id}]`}
>
{tag}
</a>
</div>
);
})}
{strings &&
strings.map((string) => (
{tags.map((item) => {
const tag = (
<Tag
key={string}
key={item.name}
dimension={dimension}
variant={variant || 'list'} // due to backward compatibility we use `list` as the default value
variant={variant || 'list'}
isInverted={isInverted}
>
{string}
{item.name}
</Tag>
))}
);
if (!item.target) {
return tag;
}
const randomId = Math.random().toString(36).substring(2, 15);
const tooltipId = `segment-tooltip-${randomId}`;
return (
<div key={randomId}>
{item.tooltip && (
<Tooltip id={tooltipId} place="top">
{MailPoet.I18n.t('viewFilteredSubscribersMessage')}
</Tooltip>
)}
<a data-tip="" data-for={tooltipId} href={item.target}>
{tag}
</a>
</div>
);
})}
</div>
);
}
export { Tags };
Tags.displayName = 'Tags';
function StringTags({ children, strings, ...props }: StringTagsProps) {
const tags: TagData[] = strings.map((item) => ({
name: item,
}));
return (
<Tags tags={tags} {...props}>
{children}
</Tags>
);
}
StringTags.displayName = 'StringTags';
function SegmentTags({ children, segments, ...props }: SegmentTagsProps) {
const tags: TagData[] = segments.map((segment) => ({
name: segment.name,
target: segment.id
? `admin.php?page=mailpoet-subscribers#/filter[segment=${segment.id}]`
: undefined,
tooltip: MailPoet.I18n.t('viewFilteredSubscribersMessage'),
}));
return (
<Tags tags={tags} {...props}>
{children}
</Tags>
);
}
SegmentTags.displayName = 'SegmentTags';
function SubscriberTags({
children,
subscribers,
...props
}: SubscriberTagsProps) {
const tags: TagData[] = subscribers.map((item) => ({
name: item.name,
target: `admin.php?page=mailpoet-subscribers#/filter[tag=${item.tag_id}]`,
tooltip: MailPoet.I18n.t('viewFilteredSubscribersMessage'),
}));
return (
<Tags tags={tags} {...props}>
{children}
</Tags>
);
}
SubscriberTags.displayName = 'SubscriberTags';
export { SegmentTags, StringTags, SubscriberTags };

View File

@ -5,36 +5,54 @@ import { MailPoetLogoMobile } from './mailpoet_logo_mobile';
type Props = {
onClick?: () => void;
withLink?: boolean;
};
export function MailPoetLogoResponsive({ onClick }: Props) {
export function MailPoetLogoResponsive({ onClick, withLink = true }: Props) {
const history = useHistory();
let logo;
let onLogoClick = onClick;
if (!onClick) {
onLogoClick = () => history.push('/');
}
return (
<a
role="button"
className="mailpoet-top-bar-logo"
title={t('topBarLogoTitle')}
onClick={onLogoClick}
tabIndex={0}
onKeyDown={(event) => {
if (
['keydown', 'keypress'].includes(event.type) &&
['Enter', ' '].includes(event.key)
) {
event.preventDefault();
onLogoClick();
}
}}
>
<div className="mailpoet-top-bar-logo-desktop">
<MailPoetLogo />
if (withLink) {
logo = (
<a
role="button"
className="mailpoet-top-bar-logo"
title={t('topBarLogoTitle')}
onClick={onLogoClick}
tabIndex={0}
onKeyDown={(event) => {
if (
['keydown', 'keypress'].includes(event.type) &&
['Enter', ' '].includes(event.key)
) {
event.preventDefault();
onLogoClick();
}
}}
>
<div className="mailpoet-top-bar-logo-desktop">
<MailPoetLogo />
</div>
<div className="mailpoet-top-bar-logo-mobile">
<MailPoetLogoMobile />
</div>
</a>
);
} else {
logo = (
<div className="mailpoet-top-bar-logo">
<div className="mailpoet-top-bar-logo-desktop">
<MailPoetLogo />
</div>
<div className="mailpoet-top-bar-logo-mobile">
<MailPoetLogoMobile />
</div>
</div>
<div className="mailpoet-top-bar-logo-mobile">
<MailPoetLogoMobile />
</div>
</a>
);
);
}
return logo;
}

View File

@ -5,21 +5,28 @@ import { withFeatureAnnouncement } from 'announcements/with_feature_announcement
import { MailPoetLogoResponsive } from './mailpoet_logo_responsive';
import { BeamerIcon } from './beamer_icon';
import { ScreenOptionsFix } from './screen_options_fix';
import { withBoundary } from '../error_boundary';
type Props = {
children?: ReactNode;
hasNews?: boolean;
onBeamerClick?: () => void;
logoWithLink?: boolean;
};
export function TopBar({ children, hasNews, onBeamerClick }: Props) {
export function TopBar({
children,
hasNews,
onBeamerClick,
logoWithLink = true,
}: Props) {
const buttonClasses = classnames(
'mailpoet-top-bar-beamer',
hasNews ? 'mailpoet-top-bar-beamer-dot' : '',
);
return (
<div className="mailpoet-top-bar">
<MailPoetLogoResponsive />
<MailPoetLogoResponsive withLink={logoWithLink} />
<div className="mailpoet-top-bar-children">{children}</div>
<div className="mailpoet-flex-grow" />
{onBeamerClick && (
@ -51,4 +58,5 @@ export function TopBar({ children, hasNews, onBeamerClick }: Props) {
);
}
export const TopBarWithBeamer = withFeatureAnnouncement(TopBar);
TopBar.displayName = 'TopBar';
export const TopBarWithBeamer = withFeatureAnnouncement(withBoundary(TopBar));

View File

@ -1,8 +1,9 @@
import { useState, useEffect } from 'react';
import { useEffect, useState } from 'react';
import ReactDOM from 'react-dom';
import { MailPoet } from 'mailpoet';
import { GlobalContext, useGlobalContextValue } from 'context/index.jsx';
import { Notices } from 'notices/notices.jsx';
import { ErrorBoundary } from 'common';
function ExperimentalFeatures() {
const [flags, setFlags] = useState(null);
@ -106,6 +107,14 @@ function ExperimentalFeatures() {
const experimentalFeaturesContainer = document.getElementById(
'experimental_features_container',
);
ExperimentalFeatures.displayName = 'ExperimentalFeatures';
if (experimentalFeaturesContainer) {
ReactDOM.render(<ExperimentalFeatures />, experimentalFeaturesContainer);
ReactDOM.render(
<ErrorBoundary>
<ExperimentalFeatures />
</ErrorBoundary>,
experimentalFeaturesContainer,
);
}

View File

@ -1,5 +1,5 @@
import { TokenFieldProps, TokenField } from 'common/form/tokenField/tokenField';
import { FormTokenItem } from '../../automation/integrations/mailpoet/components/form-token-field';
import { FormTokenItem } from '../../automation/editor/components';
interface TokenFormFieldProps {
onValueChange: TokenFieldProps['onChange'];

View File

@ -1,5 +1,6 @@
import PanelColorGradientSettings from '@wordpress/block-editor/build-module/components/colors-gradients/panel-color-gradient-settings';
import { useSetting } from '@wordpress/block-editor';
import { withBoundary } from 'common';
type Setting = {
label: string;
@ -14,7 +15,7 @@ type Props = {
settings: Setting[];
};
export function ColorGradientSettings({ title, settings }: Props): JSX.Element {
function ColorGradientSettings({ title, settings }: Props): JSX.Element {
const settingsColors = useSetting('color.palette');
const settingsGradients = useSetting('color.gradients');
return (
@ -28,3 +29,7 @@ export function ColorGradientSettings({ title, settings }: Props): JSX.Element {
</div>
);
}
ColorGradientSettings.displayName = 'ColorGradientSettings';
const ColorGradientSettingsWithBoundary = withBoundary(ColorGradientSettings);
export { ColorGradientSettingsWithBoundary as ColorGradientSettings };

View File

@ -1,6 +1,6 @@
import classnames from 'classnames';
import '@wordpress/core-data';
import { useSelect, useDispatch } from '@wordpress/data';
import { useDispatch, useSelect } from '@wordpress/data';
import { Popover, SlotFillProvider } from '@wordpress/components';
import { uploadMedia } from '@wordpress/media-utils';
import {
@ -9,13 +9,14 @@ import {
BlockList,
BlockSelectionClearer,
BlockTools,
WritingFlow,
ObserveTyping,
SETTINGS_DEFAULTS,
WritingFlow,
} from '@wordpress/block-editor';
import { ShortcutProvider } from '@wordpress/keyboard-shortcuts';
import { UnsavedChangesNotice } from 'common/notices/unsaved_changes_notice.jsx';
import { ErrorBoundary } from 'common';
import { fetchLinkSuggestions } from '../utils/link_suggestions';
import { Header } from './header.jsx';
import { Tutorial } from './tutorial';
@ -113,10 +114,12 @@ export function Editor() {
<div className={layoutClass}>
<div className="interface-interface-skeleton__editor">
<div className="interface-interface-skeleton__header">
<Header
isInserterOpened={isInserterOpened}
setIsInserterOpened={toggleInserter}
/>
<ErrorBoundary>
<Header
isInserterOpened={isInserterOpened}
setIsInserterOpened={toggleInserter}
/>
</ErrorBoundary>
</div>
<div className="interface-interface-skeleton__body">
<BlockEditorProvider
@ -132,7 +135,9 @@ export function Editor() {
</div>
)}
<div className="interface-interface-skeleton__content">
<Notices />
<ErrorBoundary>
<Notices />
</ErrorBoundary>
<UnsavedChangesNotice storeName="mailpoet-form-editor" />
<BlockSelectionClearer className="edit-post-visual-editor editor-styles-wrapper">
<BlockTools>
@ -141,9 +146,11 @@ export function Editor() {
<div className="mailpoet_form">
<WritingFlow>
<ObserveTyping>
<FormStylingBackground>
<BlockList />
</FormStylingBackground>
<ErrorBoundary>
<FormStylingBackground>
<BlockList />
</FormStylingBackground>
</ErrorBoundary>
</ObserveTyping>
</WritingFlow>
</div>
@ -152,19 +159,27 @@ export function Editor() {
</div>
{sidebarOpened && (
<div className="interface-interface-skeleton__sidebar">
<Sidebar />
<ErrorBoundary>
<Sidebar />
</ErrorBoundary>
</div>
)}
</BlockEditorProvider>
</div>
<FormStyles />
<Fullscreen />
<ErrorBoundary>
<FormStyles />
</ErrorBoundary>
<ErrorBoundary>
<Fullscreen />
</ErrorBoundary>
</div>
<Popover.Slot />
</div>
</SlotFillProvider>
</ShortcutProvider>
<FormPreview />
<ErrorBoundary>
<FormPreview />
</ErrorBoundary>
<Tutorial />
</>
);

Some files were not shown because too many files have changed in this diff Show More