f745975c03
This was causing flakiness of acceptance test ReinstallFromScratchCest.php:reinstallFromScratch and also potential issue for production. In Activator::deactivate we remove MailPoet's DB tables. This takes some time. In case there is another request during the deletion it may detect some tables are missing and trigger activation and we end up creating MailPoet tables and removing them at the same time. This commit adds locking to deactivate method so that any other attempt for activation ends up with an error. [MAILPOET-4274]
102 lines
2.5 KiB
PHP
102 lines
2.5 KiB
PHP
<?php
|
|
|
|
namespace MailPoet\Config;
|
|
|
|
use MailPoet\InvalidStateException;
|
|
use MailPoet\Settings\SettingsController;
|
|
use MailPoet\WP\Functions as WPFunctions;
|
|
|
|
class Activator {
|
|
public const TRANSIENT_ACTIVATE_KEY = 'mailpoet_activator_activate';
|
|
private const TRANSIENT_EXPIRATION = 120; // seconds
|
|
|
|
/** @var SettingsController */
|
|
private $settings;
|
|
|
|
/** @var Populator */
|
|
private $populator;
|
|
|
|
/** @var WPFunctions */
|
|
private $wp;
|
|
|
|
/** @var Migrator */
|
|
private $migrator;
|
|
|
|
public function __construct(
|
|
SettingsController $settings,
|
|
Populator $populator,
|
|
WPFunctions $wp,
|
|
Migrator $migrator
|
|
) {
|
|
$this->settings = $settings;
|
|
$this->populator = $populator;
|
|
$this->wp = $wp;
|
|
$this->migrator = $migrator;
|
|
}
|
|
|
|
public function activate() {
|
|
$isRunning = $this->wp->getTransient(self::TRANSIENT_ACTIVATE_KEY);
|
|
if ($isRunning === false) {
|
|
$this->lockActivation();
|
|
try {
|
|
$this->processActivate();
|
|
} finally {
|
|
$this->unlockActivation();
|
|
}
|
|
} else {
|
|
throw new InvalidStateException(__('MailPoet version update is in progress, please refresh the page in a minute.', 'mailpoet'));
|
|
}
|
|
}
|
|
|
|
private function lockActivation(): void {
|
|
$this->wp->setTransient(self::TRANSIENT_ACTIVATE_KEY, '1', self::TRANSIENT_EXPIRATION);
|
|
}
|
|
|
|
private function unlockActivation(): void {
|
|
$this->wp->deleteTransient(self::TRANSIENT_ACTIVATE_KEY);
|
|
}
|
|
|
|
private function processActivate(): void {
|
|
$this->migrator->up();
|
|
|
|
$this->populator->up();
|
|
$this->updateDbVersion();
|
|
|
|
$caps = new Capabilities();
|
|
$caps->setupWPCapabilities();
|
|
|
|
$localizer = new Localizer();
|
|
$localizer->forceInstallLanguagePacks($this->wp);
|
|
}
|
|
|
|
public function deactivate() {
|
|
$this->lockActivation();
|
|
$this->migrator->down();
|
|
|
|
$caps = new Capabilities();
|
|
$caps->removeWPCapabilities();
|
|
$this->unlockActivation();
|
|
}
|
|
|
|
public function updateDbVersion() {
|
|
try {
|
|
$currentDbVersion = $this->settings->get('db_version');
|
|
} catch (\Exception $e) {
|
|
$currentDbVersion = null;
|
|
}
|
|
|
|
$this->settings->set('db_version', Env::$version);
|
|
|
|
// if current db version and plugin version differ, log an update
|
|
if (version_compare((string)$currentDbVersion, Env::$version) !== 0) {
|
|
$updatesLog = (array)$this->settings->get('updates_log', []);
|
|
$updatesLog[] = [
|
|
'previous_version' => $currentDbVersion,
|
|
'new_version' => Env::$version,
|
|
'date' => date('Y-m-d H:i:s'),
|
|
];
|
|
$this->settings->set('updates_log', $updatesLog);
|
|
}
|
|
}
|
|
}
|