coolestskinnieinthejungle/SnootGame
1
0
Fork 0
forked from Cavemanon/SnootGame
Code Issues Pull Requests Projects Releases Wiki Activity

issue2-init #1

Merged
coolestskinnieinthejungle merged 26 commits from issue2-init into master 2021-06-13 04:43:30 +00:00
Conversation 0 Commits 26 Files Changed 79 +28319 -28222
coolestskinnieinthejungle commented 2021-06-13 04:40:00 +00:00
Owner
Copy Link

Stage: Initial/Ready for pull and playtest

Issue Reference: https://git.snootgame.xyz/PrincipalSpears/SnootGame/issues/2

Description of Pull Request:

game is in a "it opens and doesn't crash after a minute in the story" state after some additional indent/formatting fixes, and most importantly a transition to a dedicated directory that contains the game's script (directory appropriately named script)
chapter files are split as closely based on the script as possible.
the "branching path" if statement has been cleaned up greatly, it now just redirects to the appropriate route to jump to (scoring system hasn't changed) rather than having it all inline.

everything should be good (with fresh saves - I don't see this playing nicely with past saves but idfk) - but definitely worth scrutinizing as this is a big fuckin' change to the infrastructure of the code moving forward.

commented out some stale/redundant labels as well and datestamped them with 6/12/21
and some context.

definitely may be worth documenting the format flow for modularity QoL in the near future

#### Stage: Initial/Ready for pull and playtest #### Issue Reference: https://git.snootgame.xyz/PrincipalSpears/SnootGame/issues/2 ## Description of Pull Request: game is in a "it opens and doesn't crash after a minute in the story" state after some additional indent/formatting fixes, and most importantly a transition to a dedicated directory that contains the game's script (directory appropriately named `script`) chapter files are split as closely based on the script as possible. the "branching path" `if` statement has been cleaned up greatly, it now just redirects to the appropriate route to jump to (scoring system hasn't changed) rather than having it all inline. everything should be good (with fresh saves - I don't see this playing nicely with past saves but idfk) - but definitely worth scrutinizing as this is a big fuckin' change to the infrastructure of the code moving forward. commented out some stale/redundant labels as well and datestamped them with 6/12/21 and some context. definitely may be worth documenting the format flow for modularity QoL in the near future
coolestskinnieinthejungle added 26 commits 2021-06-13 04:40:01 +00:00 
making sure i didnt fuck up my dev env lol
this would've been done 1 hour earlier if pacman didn't fuck up my xfce4 conf
go away
fugg
yay
fixed now doe
coolestskinnieinthejungle changed title from WIP: issue2-init to issue2-init 2021-06-13 04:43:11 +00:00
coolestskinnieinthejungle merged commit 74eb44ca99 into master 2021-06-13 04:43:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolestskinnieinthejungle/SnootGame#1
No description provided.
Delete Branch "issue2-init"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?