From 5012b15ce9faaabd6e3397ef52f097528651cbf3 Mon Sep 17 00:00:00 2001 From: jgen Date: Sun, 14 Dec 2014 15:20:47 -0800 Subject: [PATCH] Comment as to why the default is to ignore the aspect ratio. --- ext/handle_video/main.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ext/handle_video/main.php b/ext/handle_video/main.php index 46e3cf1f..6b679278 100644 --- a/ext/handle_video/main.php +++ b/ext/handle_video/main.php @@ -21,8 +21,14 @@ class VideoFileHandler extends DataHandlerExtension { public function onInitExt(InitExtEvent $event) { global $config; $config->set_default_string('video_thumb_engine', 'static'); - $config->set_default_bool('video_thumb_ignore_aspect_ratio', true); $config->set_default_string('thumb_ffmpeg_path', ''); + + // By default we generate thumbnails ignoring the aspect ratio of the video file. + // + // Why? - This allows Shimmie to work with older versions of FFmpeg by default, + // rather than completely failing out of the box. If people complain that their + // thumbnails are distorted, then they can turn this feature on manually later. + $config->set_default_bool('video_thumb_ignore_aspect_ratio', true); } public function onSetupBuilding(SetupBuildingEvent $event) {