more tests, more fixes

This commit is contained in:
Shish
2009-07-19 17:59:57 +01:00
parent f574d0d81d
commit d959c174a1
5 changed files with 16 additions and 9 deletions

View File

@ -94,7 +94,7 @@ class PM extends SimpleExtension {
$database->execute("DELETE FROM private_message WHERE id = ?", array($pm_id));
log_info("pm", "Deleted PM #$pm_id");
$page->set_mode("redirect");
$page->set_redirect(make_link($_SERVER["REFERER"]));
$page->set_redirect($_SERVER["HTTP_REFERER"]);
}
else {
// permission denied
@ -107,7 +107,7 @@ class PM extends SimpleExtension {
$message = $_POST["message"];
send_event(new SendPMEvent($from_id, $_SERVER["REMOTE_ADDR"], $to_id, $subject, $message));
$page->set_mode("redirect");
$page->set_redirect(make_link($_SERVER["REFERER"]));
$page->set_redirect($_SERVER["HTTP_REFERER"]);
break;
default:
$this->theme->display_error($page, "Invalid action", "That's not something you can do with a PM");

View File

@ -32,9 +32,11 @@ class PMTest extends ShimmieWebTestCase {
$this->assertText("message contents");
$this->back();
$this->click("Delete");
# Test for bug: after an admin deletes a user's PM, they were
# redirected to their own (the admin's) PM list
$this->assertTitle("test's page");
# simpletest bug? - redirect(referrer) works in opera, not in
# webtestcase, so we end up at the wrong page...
$this->get_page("user/test");
$this->assertTitle("test's Page");
$this->assertNoText("message demo to test");
$this->log_out();
}