Wrong Backgrounds #25

New Issue

Ghost · 2021-06-16T00:30:50Z

Ghost commented

2021-06-16 00:30:50 +00:00

At least one person is reporting Backgrounds that do not seem to match what the text says.
They seem to indicate that it's an issue mostly before the initial rooftop scene.
Listed were

Anon, Reed, and Trish in the bandroom, when they should be in the auditorium
Anon in the classroom instead of bandroom
Anon inside Fang's home before reaching it (pic related)

I have not personally double checked that these are errors, and will look into it tonight. Just wanted to create an issue when it got brought up in thread.

At least one person is reporting Backgrounds that do not seem to match what the text says. They seem to indicate that it's an issue mostly before the initial rooftop scene. Listed were * Anon, Reed, and Trish in the bandroom, when they should be in the auditorium * Anon in the classroom instead of bandroom * Anon inside Fang's home before reaching it (pic related) I have not personally double checked that these are errors, and will look into it tonight. Just wanted to create an issue when it got brought up in thread.

1623802741953.png

1.2 MiB

MichaelYick added the

bug

Low Priority

help wanted

labels 2021-06-16 00:33:13 +00:00

Ghost commented

2021-06-16 04:58:23 +00:00

Starting to dig into this now.

Edit: Looked into the initial 3 issues anon reported haven't gone through the whole game yet. Lot's of speculation ahead.

Lines ~4651 ~6643
Both times the texts supports you being in the Auditorium, but the background is the listed bandroom. Possibly used as a placeholder for an asset never created of the auditorium stage, should be an easy fix to change the file pointers

Line ~7773
Anon leaves his house with a fade to get on a bus and is instead inside Fang's house already. Again possibly a placeholder, or just needs removal to continue the fade or possibly use the sidewalk BG.

Starting to dig into this now. Edit: Looked into the initial 3 issues anon reported haven't gone through the whole game yet. Lot's of speculation ahead. Lines ~4651 ~6643 Both times the texts supports you being in the Auditorium, but the background is the listed bandroom. Possibly used as a placeholder for an asset never created of the auditorium stage, should be an easy fix to change the file pointers Line ~7773 Anon leaves his house with a fade to get on a bus and is instead inside Fang's house already. Again possibly a placeholder, or just needs removal to continue the fade or possibly use the sidewalk BG.

Ghost commented

2021-06-17 11:33:07 +00:00

@PrincipleSpears please let me know if I am wrong about any of this, this isn't a code issue as much as a story/knowledge issue. If the above assumptions are correct we can just roll the this into my intial PR, unless you would prefer them seperately for some reason.

MichaelYick commented

2021-06-17 23:46:29 +00:00

Backgrounds not matching text is a code issue (after all they've been coded in) so this can stay. If you want to roll this into a PR, sure, but make sure that you note it down as solving this issue as well.

Ghost commented

2021-06-18 00:21:46 +00:00

Better explanation. I understand it is literally a code issue (especially the fade scene), but as someone who's highschool auditorium always had band stuff on stage, I could see a wierd reality where it being the background for those scenes made sense.

But of course I'll mark it as such

Edit: PR is up and should fix this issue

Better explanation. I understand it is literally a code issue (especially the fade scene), but as someone who's highschool auditorium always had band stuff on stage, I could see a wierd reality where it being the background for those scenes made sense. But of course I'll mark it as such Edit: PR is up and should fix this issue

~~Ghost referenced this issue 2021-06-18 01:13:51 +00:00~~

Minor Issue Fixes Issues #25 and #31 #33

MichaelYick commented

2021-06-18 22:01:11 +00:00

do you mind making a version of this PR for when https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/17 gets merged? It'll be soon enough.

Ghost commented

2021-06-19 00:21:30 +00:00

Of course. Sort of assumed with the big boy almost being done that would be the case. I am currently on the road, but I will crank this out when I get to my destintation. As a heads up I will be unavailable tomorrow untill probably ~1800 CDT.