Cavemanon/SnootGame
25
1
Fork 18
Code Issues 3 Pull Requests 1 Projects Releases 9 Wiki Activity

Minor Issue Fixes Issues #25 and #31 #33

Merged
MichaelYick merged 7 commits from :master into Patchy-Patch5 2021-06-21 00:09:10 +00:00
Conversation 2 Commits 7 Files Changed 5 +20 -3
Ghost commented 2021-06-17 11:34:42 +00:00
First-time contributor
Copy Link

This pull request addresses issues #25 and #31

fixes #25
2 scenes were switched from bandroom to auditorium as the text implied, and then a misplaced scene BG was removed from the bus story.

fixes #31
a variable was created wingStory that is initialized as false, and switches to true only if Anon hears Fang's story about Naser. This variable is then checked during a Naser scene to see additional story if it is TRUE.

This pull request addresses issues #25 and #31 fixes #25 2 scenes were switched from bandroom to auditorium as the text implied, and then a misplaced scene BG was removed from the bus story. fixes #31 a variable was created wingStory that is initialized as false, and switches to true only if Anon hears Fang's story about Naser. This variable is then checked during a Naser scene to see additional story if it is TRUE.
Ghost added 1 commit 2021-06-17 11:34:44 +00:00
Ghost changed title from WIP: wingStory if/else added to WIP: story issue #31 2021-06-17 11:39:04 +00:00
Ghost added 3 commits 2021-06-18 00:49:49 +00:00
Ghost changed title from WIP: story issue #31 to WIP: Minor Issue Fixes Issues #25 and #31 2021-06-18 01:13:51 +00:00
Ghost added 64 commits 2021-06-19 02:38:03 +00:00 
making sure i didnt fuck up my dev env lol
this would've been done 1 hour earlier if pacman didn't fuck up my xfce4 conf
go away
fugg
yay
fixed now doe
Reviewed-on: https://git.snootgame.xyz/coolestskinnieinthejungle/SnootGame/pulls/1
Reviewed-on: https://git.snootgame.xyz/coolestskinnieinthejungle/SnootGame/pulls/2
Reviewed-on: https://git.snootgame.xyz/coolestskinnieinthejungle/SnootGame/pulls/3
Reviewed-on: https://git.snootgame.xyz/PrincipalSpears/SnootGame/pulls/20
Reviewed-on: https://git.snootgame.xyz/coolestskinnieinthejungle/SnootGame/pulls/4
fuck you

Reviewed-on: https://git.snootgame.xyz/coolestskinnieinthejungle/SnootGame/pulls/5
Reviewed-on: https://git.snootgame.xyz/coolestskinnieinthejungle/SnootGame/pulls/6
Reviewed-on: https://git.snootgame.xyz/coolestskinnieinthejungle/SnootGame/pulls/7
Reviewed-on: https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/17
Seems to be working
(scream at me if it is not working)
Reviewed-on: https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/36
Ghost changed target branch from master to Patchy-Patch5 2021-06-19 02:38:35 +00:00
Ghost added 1 commit 2021-06-19 03:05:51 +00:00
MichaelYick commented 2021-06-20 04:23:28 +00:00
Member
Copy Link

Is this good to push in? Its got WIP and just wanted to ask @stillzero.

Is this good to push in? Its got WIP and just wanted to ask @stillzero.
MichaelYick added this to the Patchy-Patch5 Release milestone 2021-06-20 04:29:00 +00:00
Ghost commented 2021-06-20 10:38:52 +00:00
Author
First-time contributor
Copy Link

Everything looks good locally. So yeah I think we are good to go.

Everything looks good locally. So yeah I think we are good to go.
Ghost changed title from WIP: Minor Issue Fixes Issues #25 and #31 to Minor Issue Fixes Issues #25 and #31 2021-06-20 10:39:13 +00:00
MichaelYick merged commit 445f4490c3 into Patchy-Patch5 2021-06-21 00:09:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
Critical Priority

Absolutely urgent issues that must be delt with before others can even be considered.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High Priority

Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.

  
Low Priority

Minor or easy to miss errors. Features that'd be nice, but can be done with out.

  
Medium Priority

Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount

  
Meta

for all the other fun stuff about the project thats not code

  
needs more info

Something is wrong

  
question

   
refactor

Cleaning up the cruft

  
wontfix

This won't be fixed

  
bug

Something is not working

  
Critical Priority

Absolutely urgent issues that must be delt with before others can even be considered.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High Priority

Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.

  
invalid

Something is wrong

  
Low Priority

Minor or easy to miss errors. Features that'd be nice, but can be done with out.

  
Medium Priority

Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount

  
Meta

for all the other fun stuff about the project thats not code

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
Low Priority
Medium Priority
Meta
needs more info
question
refactor
wontfix
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
invalid
Low Priority
Medium Priority
Meta
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Patchy-Patch5 Release
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#33
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?