Cavemanon/SnootGame
24
Fork 18
Code Issues 4 Pull Requests 1 Projects Releases 9 Wiki Activity

Fixes #183 | Certain CGs are not marked as seen on the gallery #196

Closed
GManon wants to merge 1 commits from Minor-Gallery-Fix into Patch8
pull from: Minor-Gallery-Fix
merge into: Cavemanon:Patch8
Conversation 0 Commits 1 Files Changed 5 +5
GManon commented 2022-11-02 22:43:11 +00:00
Contributor
Copy Link

Supersedes #187, go there for original discussion.

Turns out that to use renpy.mark_image_seen(name) you need to use ren'py 7.4.7 (Yes, literally the next version). But as per #184 this shouldn't be a problem.

Also, CG a12 technically didn't exist, it was just the background of the fence from the shooting scene, so I just took a screenshot of that moment (Using renpy's screenshot function) and then just compressed it to a ~75% quality JPEG (Like all other CGs). Hopefully all is correct.

Supersedes #187, go there for original discussion. Turns out that to use `renpy.mark_image_seen(name)` you need to use ren'py 7.4.7 (Yes, literally the next version). But as per #184 this *shouldn't* be a problem. Also, CG a12 technically didn't exist, it was just the background of the fence from the shooting scene, so I just took a screenshot of that moment (Using renpy's screenshot function) and then just compressed it to a ~75% quality JPEG (Like all other CGs). Hopefully all is correct.
GManon added 1 commit 2022-11-02 22:43:14 +00:00
Implements fix 6131b5ba88
GManon closed this pull request 2022-11-16 13:38:36 +00:00
GManon deleted branch Minor-Gallery-Fix 2022-11-17 01:36:47 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
needs more info
Something is wrong
question
refactor
Cleaning up the cruft
wontfix
This won't be fixed
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
invalid
Something is wrong
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Cereal Jingo Jluminate Legalo Map MapAnon MichaelYick Mod Nerd Nio nutbuster ReleaseSmith Sl1 TheNerd writerdev
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#196
No description provided.
Delete Branch "Minor-Gallery-Fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?