Redo chapter select and minor clean up of code base #247

MapAnon · 2024-10-02T16:32:06Z

MapAnon commented

2024-10-02 16:32:06 +00:00

Organizes all non-default renpy scripts into the src folder
Some better documentation of various functions
Splits the rest of the definitions (like names, screens, etc.) into misc_definitions
Redoes chapter select to be less segmented, fixing some edge cases, layed out a bit more like Wani's chapter select, and using revised chapter selection/names
Redoes chapter sequencing to be less bloated

More or less required to be looked at before the italian update can go, since the chapter select had a few bugs that slipped by.

- Organizes all non-default renpy scripts into the src folder - Some better documentation of various functions - Splits the rest of the definitions (like names, screens, etc.) into misc_definitions - Redoes chapter select to be less segmented, fixing some edge cases, layed out a bit more like Wani's chapter select, and using revised chapter selection/names - Redoes chapter sequencing to be less bloated More or less required to be looked at before the italian update can go, since the chapter select had a few bugs that slipped by.

MapAnon added the

refactor

Medium Priority

labels 2024-10-02 16:32:06 +00:00

MapAnon added 12 commits 2024-10-02 16:32:10 +00:00

Add more safegaurds when entering the chapter select, rephrase some chapter select text 0ceae541a5

reorganize definitions into a seperate file. d9cb051d91

Rename definitions.rpy into image_definitions.rpy
change some var defaults into actual default statements

move insult layers function into misc_definitions 00166f6d3d

document the few functions in script.rpy cebabce278

move all non-default renpy scripts into src 99997a4204

document chapter_variables 1373bed36b

add locking feature to get_ending (needed for chapter 11) 2a157e1362

redo chapter select and chapter processing 3059d469f2

Add setup_ending. Endings are now determined and setup the moment branching is required. c3e365d01c

fix oversight of me being retarded and removing an import without testing 5126f0e3ae

fix chapter select needing developer mode enabled 10e8010f9b

final overhaul that should make everything work 73328cb2e1

Redid chapter names, sourced from the source snoot script
Tightened up transitions in chapter select
made all get_ending() checks use ending_route_number instead.

MapAnon requested review from nutbuster 2024-10-02 16:44:26 +00:00

MapAnon requested review from Legalo 2024-10-02 16:44:28 +00:00

nutbuster commented

2024-10-02 20:59:21 +00:00

move

default persistent.lewd = False
default persistent.autoup = False

to misc

move ``` default persistent.lewd = False default persistent.autoup = False ``` to misc

nutbuster approved these changes 2024-10-02 21:01:13 +00:00

MapAnon commented

2024-10-02 22:09:11 +00:00

move

default persistent.lewd = False
default persistent.autoup = False

to misc

As in misc_definitions.rpy? Why? Those are config vars

> move > ``` > default persistent.lewd = False > default persistent.autoup = False > ``` > to misc As in misc_definitions.rpy? Why? Those are config vars

Legalo approved these changes 2024-10-03 00:10:28 +00:00

Legalo left a comment

Looks good to me

MapAnon merged commit 267634783d into master

2024-10-03 03:19:16 +00:00

MapAnon deleted branch chapter_select_and_misc_fixes

2024-10-03 03:19:54 +00:00

MapAnon referenced this issue from a commit

2024-10-03 03:23:31 +00:00

Merge pull request 'Redo chapter select and minor clean up of code base' (#247) from chapter_select_and_misc_fixes into master

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#247