Cavemanon/SnootGame
28
Fork 18
Code Issues 3 Pull Requests 3 Actions Projects Releases 10 Wiki Activity

Backporting Wani's mod interface #249

Merged
MapAnon merged 12 commits from wani_mod_menu into master 2024-10-07 02:01:06 +00:00
Conversation 5 Commits 12 Files Changed 20
+1290 -138
MapAnon commented 2024-10-05 02:00:42 +00:00
Member
Copy Link
Copy Source

I am reaching levels of 'Fuck it' I haven't done before.

This backports all of Wani's nice mod UI and control to Snoot since the engine update now allows us to take advantage of it. I haven't tested any mod or made any sample mods to try it out, but anyone (especially interested modders) should give it a whirl to test for bugs. UI is a bit slap dash, I'll improve it later.

Also, I'm fixing conflicting properties in screens besides the mod menu, using config.check_conflicting_properties. Should this be forced on on release?

  • Create internal english language like Wani. Dunno if it's a hard requirement, can't remember.
  • Make sure it's working on Android too.
I am reaching levels of 'Fuck it' I haven't done before. This backports all of Wani's nice mod UI and control to Snoot since the engine update now allows us to take advantage of it. I haven't tested any mod or made any sample mods to try it out, but anyone (especially interested modders) should give it a whirl to test for bugs. UI is a bit slap dash, I'll improve it later. Also, I'm fixing conflicting properties in screens besides the mod menu, using `config.check_conflicting_properties`. Should this be forced on on release? - [X] Create internal english language like Wani. Dunno if it's a hard requirement, can't remember. - [X] Make sure it's working on Android too.
MapAnon added the enhancementHigh Priorityhelp wanted labels 2024-10-05 02:00:43 +00:00
MapAnon added 2 commits 2024-10-05 02:00:46 +00:00
import wani mod script 85d71da086
make the mod menu work (not testing mods) and slightly better the mod processing code 7d2203dc04
MapAnon added 3 commits 2024-10-05 15:04:09 +00:00
Implement internal 'en' language, and backport splashscreen fixes from Wani dabac1f5f0
Remove redundant mod var setup f0892157ab
add back in mod menu options 6c283a8dcd
MapAnon added 1 commit 2024-10-05 19:14:29 +00:00
fix typo blunders that crash the game 6a407f4630
MapAnon added 1 commit 2024-10-05 19:15:24 +00:00
forgor to return the fucking label that puts you into the main menu 8dfa492442
MapAnon added 1 commit 2024-10-05 23:16:06 +00:00
Fix UI issues. e54c950ef6 
Tighten up mod display to include more buttons at once, showing the original while in android.
Expands mod buttons to fill the space the menu panel provides. Redone mod button images to fit aesthetically
Imports misc files for modding, including the readme and flags
MapAnon added 1 commit 2024-10-06 19:33:07 +00:00
move mod buttons slightly higher, and create a seperate 'start' button for starting mods on Andoird aa0eff4377
MapAnon added 1 commit 2024-10-06 19:33:21 +00:00
Merge branch 'master' into wani_mod_menu 5eb39a7c3c
MapAnon marked the pull request as ready for review 2024-10-06 19:35:01 +00:00
MapAnon requested review from Legalo 2024-10-06 19:36:01 +00:00
Legalo commented 2024-10-07 00:10:09 +00:00
Member
Copy Link
Copy Source

Only comment I have is that mods that don't use rpym files shouldn't be able to be enabled/disabled since that would do nothing and it might give users a false sense of security and, although this comment also applies to Wani, this issue is going to be way more prevalent in Snoot due to missing a mod uploader that does to conversion to rpym for them.

Only comment I have is that mods that don't use rpym files shouldn't be able to be enabled/disabled since that would do nothing and it might give users a false sense of security and, although this comment also applies to Wani, this issue is going to be way more prevalent in Snoot due to missing a mod uploader that does to conversion to rpym for them.
Legalo approved these changes 2024-10-07 00:11:33 +00:00
Dismissed
MapAnon commented 2024-10-07 00:14:28 +00:00
Author
Member
Copy Link
Copy Source

Only comment I have is that mods that don't use rpym files shouldn't be able to be enabled/disabled since that would do nothing

But this is already implemented. Mods that soley use rpy files don't have the buttons for managing the mods appear.

> Only comment I have is that mods that don't use rpym files shouldn't be able to be enabled/disabled since that would do nothing But this is already implemented. Mods that soley use rpy files don't have the buttons for managing the mods appear.
Legalo commented 2024-10-07 00:21:59 +00:00
Member
Copy Link
Copy Source

Here's Moon Princess, only change I did was create a metadata.json, did not change a single rpy into an rpym and it's 'Scripts' list is empty
imagen

Here's Moon Princess, only change I did was create a metadata.json, did not change a single rpy into an rpym and it's 'Scripts' list is empty ![imagen](/attachments/60da7c85-bbfb-4efd-a6ab-1e07a49d3f36)
imagen.png
844 KiB
MapAnon added 1 commit 2024-10-07 00:56:50 +00:00
make the mod toggle button disappear if the mod doesn't have any valid scripts loaded b1719c4b21
MapAnon dismissed Legalo's review 2024-10-07 00:56:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Legalo requested review from Legalo 2024-10-07 01:03:22 +00:00
MapAnon added 1 commit 2024-10-07 01:33:25 +00:00
Fix NOMODS flag clearing the load order a266c9508c 
Mods that don't have loadable scripts are forced on
Legalo approved these changes 2024-10-07 01:50:10 +00:00
MapAnon merged commit 87e9546d15 into master 2024-10-07 02:01:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Legalo
Labels
Clear labels
bug
Something is not working
 Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
 Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
 Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
 Meta
for all the other fun stuff about the project thats not code
 needs more info
Something is wrong
 question
refactor
Cleaning up the cruft
 wontfix
This won't be fixed
back-burner
"Shit Nobody Cares About" issues
 bug
Something is not working
 Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
 enhancement
New feature
 help wanted
Need some help
 High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
 Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
 Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
 Meta
for all the other fun stuff about the project thats not code
 question
More information is needed
 undelegated
Issues that need to be assigned by a project manager
No labels enhancement High Priority help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bighoss (bighoss) Cereal (Cereal) columbo (columbo) Jluminate (Jluminate) Legalo (Legalo) Map (Map) MichaelYick (MichaelYick) Mod (Mod) Mono (Mono) Nerd (Nerd) Nio nutbuster (Nutbuster) ReleaseSmith Sl1 (Sl1) TheNeonWerewolf (TheNeonWerewolf) TheNerd writerdev Zadeon
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#249