Cavemanon/SnootGame
25
1
Fork 18
Code Issues 3 Pull Requests 1 Projects Releases 9 Wiki Activity

Fix Snootgame Building #253

Merged
MapAnon merged 2 commits from fix-snootgame-building into master 2024-10-11 20:59:12 +00:00
Conversation 2 Commits 2 Files Changed 1 +1
MichaelYick commented 2024-10-11 20:08:15 +00:00
Member
Copy Link

Debloated builds and include renconstruct

An option in the options.rpy made it so renconstruct.toml wasn't shipped
with the game AND the lack of an option made the game compile with the
dist/ folder being exported, meaning that the game would ship with an
android build unnecessarily.

Fixes: #239
Fixes: #240
Debloated builds and include renconstruct An option in the options.rpy made it so renconstruct.toml wasn't shipped with the game AND the lack of an option made the game compile with the dist/ folder being exported, meaning that the game would ship with an android build unnecessarily. Fixes: #239 Fixes: #240
MichaelYick added the
help wanted
 label 2024-10-11 20:08:15 +00:00
MapAnon was assigned by MichaelYick 2024-10-11 20:08:16 +00:00
MichaelYick added 1 commit 2024-10-11 20:08:25 +00:00
Debloated builds and include renconstruct
Some checks are pending
ci/woodpecker/push/woodpecker Pipeline is pending
Details
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
b16bd97d33 
An option in the options.rpy made it so renconstruct.toml wasn't shipped
with the game AND the lack of an option made the game compile with the
dist/ folder being exported, meaning that the game would ship with an
android build unnecessarily.

Fixes: #239
Fixes: #240
MapAnon requested changes 2024-10-11 20:13:40 +00:00
Dismissed
MapAnon left a comment
Member
Copy Link

Oh man, it was that simple? Now that I look at Wani's options.rpy the exact same thing is implemented. In hindsight this probably should've been checked.

Also, you misread me with the renconstruct issue, I was saying that the toml file isn't supposed to be included, but it was on the patch 10 releases for whatever reason. Revert that change, and let's do a test build to see if the issue still persists.

Oh man, it was that simple? Now that I look at Wani's `options.rpy` the exact same thing is implemented. In hindsight this probably should've been checked. Also, you misread me with the renconstruct issue, I was saying that the toml file _isn't_ supposed to be included, but it was on the patch 10 releases for whatever reason. Revert that change, and let's do a test build to see if the issue still persists.
MichaelYick added 1 commit 2024-10-11 20:48:45 +00:00
Remove renconstruct from build
Some checks are pending
ci/woodpecker/push/woodpecker Pipeline is pending
Details
ci/woodpecker/pr/woodpecker Pipeline is pending
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline is pending
Details
6377fffba0
MapAnon approved these changes 2024-10-11 20:58:52 +00:00
MapAnon merged commit 46c47303d7 into master 2024-10-11 20:59:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
MapAnon
Labels
Clear labels
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
needs more info
Something is wrong
question
refactor
Cleaning up the cruft
wontfix
This won't be fixed
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
invalid
Something is wrong
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
question
More information is needed
wontfix
This won't be fixed
No Label
help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees MapAnon
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#253
No description provided.
Delete Branch "fix-snootgame-building"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?