Cavemanon/SnootGame
25
Fork 18
Code Issues 4 Pull Requests 1 Actions Projects Releases 10 Wiki Activity

Improve Anon playing guitar section in Ch. 8 #254

Closed
Pomi108 wants to merge 2 commits from Pomi108/SnootGame:master into master
pull from: Pomi108/SnootGame:master
merge into: Cavemanon:master
Conversation 3 Commits 2 Files Changed -
Pomi108 commented 2024-10-13 11:32:46 +00:00
Contributor
Copy Link

I've always thought it was weird how Anon's initial guitar strumming played over the music, so I changed it so that the background music no longer plays during this section. I also removed the fadeins on the strum sound effects and decreased the volume to 0.5 in order to make them sound the same as the ones that play during the player choice section.

I've always thought it was weird how Anon's initial guitar strumming played over the music, so I changed it so that the background music no longer plays during this section. I also removed the fadeins on the strum sound effects and decreased the volume to 0.5 in order to make them sound the same as the ones that play during the player choice section.
Pomi108 added 1 commit 2024-10-13 11:33:04 +00:00
improve anon playing guitar
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
02000b6bdd
Pomi108 changed title from Improve Anon playing guitar section to Improve Anon playing guitar section in Ch. 8 2024-10-13 11:34:00 +00:00
MapAnon commented 2024-10-13 15:09:41 +00:00
Member
Copy Link

I agree with the sounds not meshing well with the music looking back at that scene, but I don't think it's a big enough problem to warrant removing atmosphere for the sake of incidental sounds.

I agree with the sounds not meshing well with the music looking back at that scene, but I don't think it's a big enough problem to warrant removing atmosphere for the sake of incidental sounds.
Pomi108 commented 2024-10-13 16:06:18 +00:00
Author
Contributor
Copy Link

Hmm, maybe the background music could be changed to play at a lower volume?

Or it could play at the standard volume, but get damped while the guitar sounds play

Hmm, maybe the background music could be changed to play at a lower volume? Or it could play at the standard volume, but get damped while the guitar sounds play
Pomi108 commented 2024-10-13 18:59:18 +00:00
Author
Contributor
Copy Link

ugh, gitea seems to have bugged out again. it shows no diffs again

ugh, gitea seems to have bugged out again. it shows no diffs again
Pomi108 added 2 commits 2024-10-13 19:03:08 +00:00
Revert "improve anon playing guitar" 4eb31ae0a6 
This reverts commit 02000b6bdd9cd4dda7eea0141e64b565c6e68e54.
Reapply "improve anon playing guitar"
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is running
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details
1ef31fae47 
This reverts commit 4eb31ae0a64720554e5370368d06a8b1ddd706d1.
MapAnon closed this pull request 2024-12-03 23:17:13 +00:00
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is running
Details
ci/woodpecker/pull_request_closed/woodpecker Pipeline was successful
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
needs more info
Something is wrong
question
refactor
Cleaning up the cruft
wontfix
This won't be fixed
bug
Something is not working
Critical Priority
Absolutely urgent issues that must be delt with before others can even be considered.
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
High Priority
Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.
invalid
Something is wrong
Low Priority
Minor or easy to miss errors. Features that'd be nice, but can be done with out.
Medium Priority
Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount
Meta
for all the other fun stuff about the project thats not code
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Cereal Jatmoz Jingo Jluminate Legalo Map MapAnon MichaelYick Mod Nerd Nio nutbuster ReleaseSmith Sl1 TheNerd writerdev
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#254
No description provided.
Delete Branch "Pomi108/SnootGame:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?