WIP: Choreography update for chapter 1 #41

MichaelYick · 2021-06-22T06:12:59Z

MichaelYick commented

2021-06-22 06:12:59 +00:00

No description provided.

MichaelYick added 8 commits 2021-06-22 06:13:00 +00:00

Bowie added 1 commit 2021-06-24 18:47:55 +00:00

rework meeting Spear, Naser's heart-to-heart, add placeholder support for CTC, add support for ambient sound loop channel 541645f810

Bowie added 1 commit 2021-06-24 20:05:47 +00:00

rework concert disaster & subsequent run in with Spears 3af087ee77

Bowie added 1 commit 2021-06-24 21:32:51 +00:00

rework anon's morning routine 468f367261

Bowie added 1 commit 2021-06-26 11:42:18 +00:00

change CTC icon, add ambient sound channel, rework 'nasers a bro' scenes a22aa136cb

Bowie added 1 commit 2021-06-26 12:51:36 +00:00

merge both routes through Spear's office into one with the appropriate dialogue variation, rework Spear's office scene 6e7e9ac7d7

Bowie added 1 commit 2021-06-26 14:10:09 +00:00

rework quick route to Spear's office 3fd3895178

Bowie added 1 commit 2021-06-26 14:18:49 +00:00

minor tweaks to Spear's office scene 3aac53c8b7

Bowie added 1 commit 2021-06-26 16:32:40 +00:00

finish first pass of chapter 1 6de77d3c61

Bowie added 1 commit 2021-06-26 17:10:00 +00:00

timing tweaks d9e46a6135

Bowie added 1 commit 2021-06-26 17:15:27 +00:00

add CTC to inner monologue 799f07d0e4

Bowie added 1 commit 2021-06-26 18:35:24 +00:00

more minor timing tweaks c0b49eea9c

Bowie added 1 commit 2021-06-26 18:58:40 +00:00

fix minor continuity error f687e6a032

Bowie added 1 commit 2021-06-26 19:24:42 +00:00

change CTC icon to start off at min alpha instead of max alpha b03361b476

Bowie added 1 commit 2021-06-26 19:59:02 +00:00

fix Naser posessing naomi for a single line of dialogue 22d44dcc74

Bowie added 1 commit 2021-06-27 11:37:36 +00:00

add Spears roar to concert aftermath 6828f773d6

Bowie added 1 commit 2021-06-27 12:15:00 +00:00

yet more ch1 tweaks 66e3ab693b

Bowie added 1 commit 2021-06-27 14:36:10 +00:00

slight change to crowd noises at the failed concert 98275a6cfe

Bowie added 1 commit 2021-06-28 20:02:38 +00:00

Merge branch 'Monster-Update-6' into chapter-1-choreo f26f6a33fd

# Conflicts:
#	game/script.rpy
#	game/script/1.first-two-days-anon-meets-fang.rpy

Bowie added 1 commit 2021-06-28 20:52:57 +00:00

made trish shorter when confronting Naser fe1391a8a0

Bowie commented

2021-06-28 20:53:56 +00:00

Conflicts should now be resolved as long as nothing else lands on Monster-Update-6 first.

MichaelYick added this to the Monster-Update-6 milestone 2021-06-29 04:54:43 +00:00

MichaelYick commented

2021-06-29 06:02:12 +00:00

Okay giving this a review for now. Comments so far:

for some reason, declaring volume of audio causes the game not to boot. Commented problematic lines out and offered substitute lines until this problem can be resolved

A couple of tweaks to enhance the /soul/ of the game or other issues.
(denoted by ###, describing what was changed or a suggested change)

For new sound effects, make sure they're under compatable license. (Public Domain, CC0, CC-BY, CC-BY-SA 4.0, etc). For CC-BY and CC-BY-SA's it's legally imperitive we attribute them. This can be seen in the LICENSE file. Rather our demise be from lawlsuits from Koop rather than lawlsuits from some random internet schizo who uploaded toiletshitting3.wav to the internet.

what is blinky thingy, I don't play visual novels.

I see the use of this new-fangled "MoveTransition" thing. Since this may be a mainstay, i'll add a comment on the first instance of it to the tips page.

prevent Naomi from seeing into the future

Go for it, I doubt the writers will complain about the fix. If they do, it'll be on me.

bouncy naomi

anons are going to love this

For sound effects, aim for ogg files or convert to ogg.

For now looking great! Keep up the good work! Will push my minor changes to this pr for you to review over.

Okay giving this a review for now. Comments so far: for some reason, declaring volume of audio causes the game not to boot. Commented problematic lines out and offered substitute lines until this problem can be resolved A couple of tweaks to enhance the /soul/ of the game or other issues. (denoted by ###, describing what was changed or a suggested change) For new sound effects, make sure they're under compatable license. (Public Domain, CC0, CC-BY, CC-BY-SA 4.0, etc). For CC-BY and CC-BY-SA's it's legally imperitive we attribute them. This can be seen in the LICENSE file. Rather our demise be from lawlsuits from Koop rather than lawlsuits from some random internet schizo who uploaded toiletshitting3.wav to the internet. what is blinky thingy, I don't play visual novels. ![image]() I see the use of this new-fangled "MoveTransition" thing. Since this may be a mainstay, i'll add a comment on the first instance of it to the tips page. >prevent Naomi from seeing into the future Go for it, I doubt the writers will complain about the fix. If they do, it'll be on me. >bouncy naomi anons are going to love this For sound effects, aim for ogg files or convert to ogg. For now looking great! Keep up the good work! Will push my minor changes to this pr for you to review over.

image.png

1.8 KiB

MichaelYick added 2 commits 2021-06-29 06:05:56 +00:00

https://git.snootgame.xyz/Cavemanon/SnootGame/issues/41#issuecomment-585 e77bcbb9a3

Merge pull request 'https://git.snootgame.xyz/Cavemanon/SnootGame/issues/41#issuecomment-585 ' (#2 ) from Cavemanon/SnootGame:pr/41 into chapter-1-choreo 095299b9ba

Reviewed-on: https://git.snootgame.xyz/Bowie/SnootGame/pulls/2

Bowie commented

2021-06-29 19:49:02 +00:00

Cool, I'll have a look through the comments.

for some reason, declaring volume of audio causes the game not to boot.

This is pretty unfortunate, appears to work on wangdows.

what is blinky thingy

I realised early on when I was making text more 'speechlike' that it was sometimes quite jarring not knowing when a character had finished speaking and by extension not knowing when you should click to move on to the next segment of dialogue.
Luckily it turns out that Renpy has a built in feature to mitigate this problem in the form of 'click-to-continue indicators', where for each Character object you can define an icon that appears to prompt the player to move the dialogue forwards, for example once everything in the text window has been displayed. There was a small amount of discussion and it was suggested provisionally that we use a guitar pick - the position, size, animation and design of the indicator isn't at all final but I stuck it in anyway to see whether it would work as intended. It's super easy to tweak as well.

As for SFX, I'm out of my depth there and have been relying on the internal team to create stuff or sauce me up with something suitable. I'll keep all that in mind and take care though.

EDIT

I see the use of this new-fangled "MoveTransition" thing

I started preferring block ATL statements instead pretty quickly, since the stock easing functions you hand MoveTransition are poorly documented (as far as I could see). But yes, linear movement using 'with move' looks kind of whack IMO so I've been using easing wherever I can instead.

Cool, I'll have a look through the comments. > for some reason, declaring volume of audio causes the game not to boot. This is pretty unfortunate, appears to work on wangdows. > what is blinky thingy I realised early on when I was making text more 'speechlike' that it was sometimes quite jarring not knowing when a character had finished speaking and by extension not knowing when you should click to move on to the next segment of dialogue. Luckily it turns out that Renpy has a built in feature to mitigate this problem in the form of 'click-to-continue indicators', where for each Character object you can define an icon that appears to prompt the player to move the dialogue forwards, for example once everything in the text window has been displayed. There was a small amount of discussion and it was suggested provisionally that we use a guitar pick - the position, size, animation and design of the indicator isn't at all final but I stuck it in anyway to see whether it would work as intended. It's super easy to tweak as well. As for SFX, I'm out of my depth there and have been relying on the internal team to create stuff or sauce me up with something suitable. I'll keep all that in mind and take care though. **EDIT** > I see the use of this new-fangled "MoveTransition" thing I started preferring block ATL statements instead pretty quickly, since the stock easing functions you hand MoveTransition are poorly documented (as far as I could see). But yes, linear movement using 'with move' looks kind of whack IMO so I've been using easing wherever I can instead.

MichaelYick commented

2021-06-30 02:13:14 +00:00

appears to work on wangdows

What version of renpy are you using? I'm on Devuan GNU/Linux and my repos may just have an old version of the SDK.

blinky thingy shows when text is ended

Useful, but users might find the blinking distracting. The human eye is attracted to movement and more often than not that will be there as users keep up with the text, detracting a bit from the visuals. Maybe just make it a faint symbol rather than a blinking one.

As for SFX, I'm out of my depth there and have been relying on the internal team to create stuff or sauce me up with something suitable

I'd suggest going to soundbible or similar sites, making sure the licensing is good-to-go, and then grabbing the noise. I found most of the sounds myself, it's easier than you'd think.

MoveTransition stuff

You had a stroke mid-paragraph, but from what I am getting, yeah it makes sense you'd prefer it. The move options nomrally are sorta limiting. No fault in using it, just that it needs to be documented. If you can, update the tips section as you find out more about the function.

>appears to work on wangdows What version of renpy are you using? I'm on Devuan GNU/Linux and my repos may just have an old version of the SDK. >blinky thingy shows when text is ended Useful, but users might find the blinking distracting. The human eye is attracted to movement and more often than not that will be there as users keep up with the text, detracting a bit from the visuals. Maybe just make it a faint symbol rather than a blinking one. >As for SFX, I'm out of my depth there and have been relying on the internal team to create stuff or sauce me up with something suitable I'd suggest going to soundbible or similar sites, making sure the licensing is good-to-go, and then grabbing the noise. I found most of the sounds myself, it's easier than you'd think. >MoveTransition stuff You had a stroke mid-paragraph, but from what I am getting, yeah it makes sense you'd prefer it. The move options nomrally are sorta limiting. No fault in using it, just that it needs to be documented. If you can, update the tips section as you find out more about the function.

MichaelYick commented

2021-06-30 03:27:13 +00:00

assuming you're using the lastest SDK, it makes sense that stuff broke. Devuan's renpy version is woefully out of date.

Bowie commented

2021-06-30 18:49:46 +00:00

I'm on 7.4.6

MichaelYick commented

2021-06-30 23:16:45 +00:00

Yup, it was my renpy SDK. Uncomment the old stuff and remove the new fixes, i'll note this down for future reference.

Bowie added 1 commit 2021-07-01 17:40:26 +00:00

Naser gives fewer fucks when blocking Trish, volume control back up, added outdoor ambience, converted some SFX to .ogg format e1eee3852d

Bowie added 1 commit 2021-07-01 20:09:58 +00:00

music changes to some ch1 scenes, add another music channel for crossfade effect 075743f063

Bowie added 1 commit 2021-07-01 20:17:40 +00:00

lined up end of ch1 with start of ch2 6ae319c6ce

Bowie added 1 commit 2021-07-02 20:19:08 +00:00

SFX & music tweaks, TODOs for missing scene after Anon meets Naser & Naomi 83b680efe1

Bowie added 1 commit 2021-07-02 20:40:41 +00:00

cleanup, add more TODOs cd44add13d

Bowie added 1 commit 2021-07-02 21:01:58 +00:00

SFX uplift for pizza scene 56fe353dd8

Bowie added 1 commit 2021-07-02 21:11:04 +00:00

add ambience to reflective scene after concert bc4c4a2304

Bowie added 1 commit 2021-07-03 09:12:53 +00:00

replace bell sound e19566dfa8

Bowie added 1 commit 2021-07-03 13:02:56 +00:00

add missing scene after bench scene, SFX uplift 9290b34829

Bowie added 1 commit 2021-07-03 14:34:06 +00:00

more ch1 tweaks before looking at ch2 7832a18822

Bowie added 1 commit 2021-07-03 14:44:06 +00:00

fix line in canteen scene 0df8dd9f94

Bowie added 1 commit 2021-07-03 14:53:33 +00:00

Merge branch 'Monster-Update-6' into chapter-1-choreo f7db5fb407

# Conflicts:
#	game/script.rpy

Bowie commented

2021-07-03 14:56:12 +00:00

Re-merged with the update branch so this should be ok to land if you're happy with the content. There are some minor TODOs and music choices could always be revised but everything else is there.

I'll branch off again and start chapter 2 if this gets the green light.

EDIT
Forgot about the CTC indicator, that shouldn't take much effort to rework.

Re-merged with the update branch so this should be ok to land if you're happy with the content. There are some minor TODOs and music choices could always be revised but everything else is there. I'll branch off again and start chapter 2 if this gets the green light. **EDIT** Forgot about the CTC indicator, that shouldn't take much effort to rework.

Bowie added 1 commit 2021-07-03 16:08:48 +00:00

add missing punch to Naser's outburst c3c7b3b753

Bowie added 1 commit 2021-07-03 17:39:32 +00:00

remove unused effect 5335540d0b

Bowie commented

2021-07-03 17:51:53 +00:00

Actually hold that thought, the guys want to review the SFX.

Bowie added 1 commit 2021-07-03 19:41:07 +00:00

crunch some sounds 981b7df998

Bowie added 1 commit 2021-07-04 15:01:03 +00:00

replace classroom anxiety SFX 1c49e00b94

Bowie added 1 commit 2021-07-04 15:18:55 +00:00