Cavemanon/cavemanon-wagtail-personalisation
Archived
7
Fork 0
Code Issues Pull Requests Activity

Query rule should not be static

Browse Source
This commit is contained in:
Kaitlyn Crawford
2018-02-20 15:08:12 +02:00
parent bedbe06c65
commit 364cb1a7e6
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/wagtail_personalisation/rules.py
View File

@ -266,7 +266,6 @@ class QueryRule(AbstractBaseRule):
""" """
icon = 'fa-link' icon = 'fa-link'
static = True
parameter = models.SlugField(_("The query parameter to search for"), parameter = models.SlugField(_("The query parameter to search for"),
max_length=20) max_length=20)
@ -281,13 +280,7 @@ class QueryRule(AbstractBaseRule):
class Meta: class Meta:
verbose_name = _('Query Rule') verbose_name = _('Query Rule')
def test_user(self, request, user=None): def test_user(self, request):
if user:
# This rule currently does not support testing a user directly
# TODO: Make this test a user directly if/when the rule uses
# historical data
return False
return request.GET.get(self.parameter, '') == self.value return request.GET.get(self.parameter, '') == self.value
def description(self): def description(self):

1
tests/unit/test_factories.py
View File

@ -45,4 +45,3 @@ def test_query_rule_create():
assert query_rule.parameter == 'query' assert query_rule.parameter == 'query'
assert query_rule.value == 'value' assert query_rule.value == 'value'
assert query_rule.static