Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Make startProgress() and stopProgress() methods private [MAILPOET-2385]

Browse Source
This commit is contained in:
wxa
2019-09-30 08:01:55 +03:00
committed by Jack Kitterhing
parent 2a48d0846d
commit 0805dc365f
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Cron/Workers/SingleInstanceSimpleWorker.php
View File

@@ -48,12 +48,12 @@ abstract class SingleInstanceSimpleWorker extends SimpleWorker {
return false; return false;
} }
function startProgress(ScheduledTask $task) { private function startProgress(ScheduledTask $task) {
$task->meta = array_merge($task->getMeta(), ['in_progress' => true]); $task->meta = array_merge($task->getMeta(), ['in_progress' => true]);
$task->save(); $task->save();
} }
function stopProgress(ScheduledTask $task) { private function stopProgress(ScheduledTask $task) {
$task->meta = array_merge($task->getMeta(), ['in_progress' => null]); $task->meta = array_merge($task->getMeta(), ['in_progress' => null]);
$task->save(); $task->save();
} }

3
tests/integration/Cron/Workers/SingleInstanceSimpleWorkerTest.php
View File

@@ -21,8 +21,7 @@ class SingleInstanceSimpleWorkerTest extends \MailPoetTest {
$task = $this->createScheduledTask(); $task = $this->createScheduledTask();
expect(empty($task->getMeta()['in_progress']))->equals(true); expect(empty($task->getMeta()['in_progress']))->equals(true);
expect($this->worker->processTask($task))->equals(true); expect($this->worker->processTask($task))->equals(true);
$this->worker->startProgress($task); $task->meta = ['in_progress' => true];
expect(empty($task->getMeta()['in_progress']))->equals(false);
expect($this->worker->processTask($task))->equals(false); expect($this->worker->processTask($task))->equals(false);
} }