Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Move release commands to a namespace & improve naming

Browse Source 
[MAILPOET-1977]
This commit is contained in:
Jan Jakeš
2019-04-19 13:35:07 +02:00
committed by M. Shull
parent 3bce5ed8fa
commit 34e4203b9f
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
RoboFile.php
View File

@ -513,14 +513,14 @@ class RoboFile extends \Robo\Tasks {
->run(); ->run();
} }
function changelogUpdate($opts = ['version-name' => null]) { function releaseChangelogWrite($opts = ['version-name' => null]) {
$this->say("Updating changelog"); $this->say("Updating changelog");
$outputs = $this->getChangelogController()->update($opts['version-name']); $outputs = $this->getChangelogController()->update($opts['version-name']);
$this->say("Changelog \n{$outputs[0]} \n{$outputs[1]}\n\n"); $this->say("Changelog \n{$outputs[0]} \n{$outputs[1]}\n\n");
$this->say("IMPORTANT NOTES \n" . ($outputs[2] ?: 'none')); $this->say("IMPORTANT NOTES \n" . ($outputs[2] ?: 'none'));
} }
function changelogGet($opts = ['version-name' => null]) { function releaseChangelogGet($opts = ['version-name' => null]) {
$outputs = $this->getChangelogController()->get($opts['version-name']); $outputs = $this->getChangelogController()->get($opts['version-name']);
$this->say("Changelog \n{$outputs[0]} \n{$outputs[1]}\n"); $this->say("Changelog \n{$outputs[0]} \n{$outputs[1]}\n");
$this->say("IMPORTANT NOTES \n" . ($outputs[2] ?: 'none')); $this->say("IMPORTANT NOTES \n" . ($outputs[2] ?: 'none'));
@ -534,7 +534,7 @@ class RoboFile extends \Robo\Tasks {
->run(); ->run();
} }
public function writeReleaseVersion($version) { public function releaseVersionWrite($version) {
$version = trim($version); $version = trim($version);
$this->validateVersion($version); $this->validateVersion($version);
@ -554,7 +554,7 @@ class RoboFile extends \Robo\Tasks {
->run(); ->run();
} }
public function nextReleaseVersion($version = null) { public function releaseVersionGetNext($version = null) {
if (!$version) { if (!$version) {
$version = $this->getReleaseVersionController() $version = $this->getReleaseVersionController()
->determineNextVersion(); ->determineNextVersion();
@ -563,8 +563,8 @@ class RoboFile extends \Robo\Tasks {
return $version; return $version;
} }
public function jiraReleaseVersion($version = null, $opts = []) { public function releaseVersionAssign($version = null, $opts = []) {
$version = $this->nextReleaseVersion($version); $version = $this->releaseVersionGetNext($version);
try { try {
list($version, $output) = $this->getReleaseVersionController() list($version, $output) = $this->getReleaseVersionController()
->assignVersionToCompletedTickets($version); ->assignVersionToCompletedTickets($version);
@ -579,14 +579,14 @@ class RoboFile extends \Robo\Tasks {
} }
public function prepareRelease($version = null) { public function prepareRelease($version = null) {
$version = $this->jiraReleaseVersion($version, ['return' => true]); $version = $this->releaseVersionAssign($version, ['return' => true]);
return $this->collectionBuilder() return $this->collectionBuilder()
->addCode(function () use ($version) { ->addCode(function () use ($version) {
return $this->writeReleaseVersion($version); return $this->releaseVersionWrite($version);
}) })
->addCode(function () use ($version) { ->addCode(function () use ($version) {
return $this->changelogUpdate(['version-name' => $version]); return $this->releaseChangelogWrite(['version-name' => $version]);
}) })
->run(); ->run();
} }
@ -623,7 +623,7 @@ class RoboFile extends \Robo\Tasks {
} }
public function releasePublishJira($version = null) { public function releasePublishJira($version = null) {
$version = $this->nextReleaseVersion($version); $version = $this->releaseVersionGetNext($version);
$jira_controller = $this->createJiraController(); $jira_controller = $this->createJiraController();
$jira_version = $jira_controller->releaseVersion($version); $jira_version = $jira_controller->releaseVersion($version);
$this->say("JIRA version '$jira_version[name]' was released."); $this->say("JIRA version '$jira_version[name]' was released.");