Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix tracking settings configuration on WooCommerce setup wizard step

Browse Source 
When testing the woo wizard step i noticed that always set tracking to
'partial' even if the checkbox is checked. When debugging I found that the allowed value
is not a string but boolean. I tested this in wizard and also on the WooCommerce setup page.
I needed to update the acceptance test because it was clicking on 'no' and asserting the outcome as 'yes' was clicked.
[MAILPOET-5059]
This commit is contained in:
Rostislav Wolny
2023-02-14 10:56:09 +01:00
committed by Sam
parent 9cf70c6c3b
commit 40cdb9a766
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mailpoet/assets/js/src/wizard/steps/woocommerce_step.tsx
View File

@@ -30,7 +30,7 @@ function WizardWooCommerceStep({
if (importType === null || allowed === null) {
return false;
}
submitForm(importType, allowed === 'true');
submitForm(importType, allowed === true);
return false;
};

2
mailpoet/tests/acceptance/WelcomeWizard/WelcomeWizardCest.php
View File

@@ -51,7 +51,7 @@ class WelcomeWizardCest {
// Third step of the wizard
$i->waitForText('Power up your WooCommerce store');
$i->click('.mailpoet-form-yesno-no');
$i->click('.mailpoet-form-yesno-yes');
$i->click('.mailpoet-wizard-continue-button');
// Fourth step of the wizard