Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Merge pull request #1084 from mailpoet/editor_get_post_type_optimization

Browse Source 
Removes unused properties from the object used to display post types in editor [MAILPOET-1086]
This commit is contained in:
Tautvidas Sipavičius
2017-09-05 17:43:27 +03:00
committed by GitHub
parent 998795e0e0 e4bb3e1133
commit a02e64e805
2 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/API/JSON/v1/AutomatedLatestContent.php
View File

@ -19,8 +19,14 @@ class AutomatedLatestContent extends APIEndpoint {
}
function getPostTypes() {
$post_types = array_map(function($post_type) {
return array(
'name' => $post_type->name,
'label' => $post_type->label
);
}, get_post_types(array(), 'objects'));
return $this->successResponse(
get_post_types(array(), 'objects')
$post_types
);
}
@ -82,4 +88,4 @@ class AutomatedLatestContent extends APIEndpoint {
return $this->successResponse($rendered_posts);
}
}
}

18
tests/unit/API/JSON/v1/AutomatedLatestContentTest.php Normal file
View File

@ -0,0 +1,18 @@
<?php
namespace MailPoet\Test\API\JSON\v1;
use MailPoet\API\JSON\v1\AutomatedLatestContent;
class AutomatedLatestContentTest extends \MailPoetTest {
function testItGetsPostTypes() {
$router = new AutomatedLatestContent();
$response = $router->getPostTypes();
expect($response->data)->notEmpty();
foreach($response->data as $post_type) {
expect($post_type)->count(2);
expect($post_type['name'])->notEmpty();
expect($post_type['label'])->notEmpty();
}
}
}