Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Prevent flakiness when comparing time in NewsletterTest

Browse Source 
When comparing the sentAt and processedAt dates there might be one second difference.
This may happen also in the application, because they are updated by separate queries.

This commit fixes the flakiness by comparing timestamps with delta 1 second instead of comparing date time strings.
[MAILPOET-4710]
This commit is contained in:
Rostislav Wolny
2022-11-04 11:09:31 +01:00
committed by Rodrigo Primo
parent c6e6b13731
commit c4966a9cc1
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mailpoet/tests/integration/Cron/Workers/SendingQueue/Tasks/NewsletterTest.php
View File

@@ -247,7 +247,7 @@ class NewsletterTest extends \MailPoetTest {
$newsletter = $this->newslettersRepository->findOneById($this->newsletter->getId());
$this->assertInstanceOf(NewsletterEntity::class, $newsletter);
$sendingQueue = $this->sendingTask->queue();
$sendingQueue->processedAt = date('Y-m-d H:i:s');
$sendingQueue->processedAt = new \DateTime();
// newsletter type is 'standard'
$newsletter->setType(NewsletterEntity::TYPE_STANDARD);
@@ -260,7 +260,7 @@ class NewsletterTest extends \MailPoetTest {
expect($updatedNewsletter->getStatus())->equals(NewsletterEntity::STATUS_SENT);
$sentAt = $updatedNewsletter->getSentAt();
$this->assertInstanceOf(\DateTime::class, $sentAt);
expect($sentAt->format('Y-m-d H:i:s'))->equals($sendingQueue->processedAt);
expect($sentAt->getTimestamp())->equals($sendingQueue->processedAt->getTimestamp(), 1);
// newsletter type is 'notification history'
$newsletter->setType(NewsletterEntity::TYPE_NOTIFICATION_HISTORY);
@@ -273,7 +273,7 @@ class NewsletterTest extends \MailPoetTest {
expect($updatedNewsletter->getStatus())->equals(NewsletterEntity::STATUS_SENT);
$sentAt = $updatedNewsletter->getSentAt();
$this->assertInstanceOf(\DateTime::class, $sentAt);
expect($sentAt->format('Y-m-d H:i:s'))->equals($sendingQueue->processedAt);
expect($sentAt->getTimestamp())->equals($sendingQueue->processedAt->getTimestamp(), 1);
// all other newsletter types
$newsletter->setType(NewsletterEntity::TYPE_WELCOME);