Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove padding on mobile

Browse Source 
[MAILPOET-2924]
This commit is contained in:
Pavel Dohnal
2020-06-03 11:26:29 +02:00
committed by Veljko V
parent ba723a6383
commit edd3e7da79
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Form/Util/Styles.php
View File

@ -172,7 +172,15 @@ EOL;
// Form element styles
$formStyles = [];
if (isset($formSettings['form_padding'])) {
$formStyles[] = 'padding: ' . $formSettings['form_padding'] . 'px';
if (in_array(
$displayType,
[FormEntity::DISPLAY_TYPE_POPUP, FormEntity::DISPLAY_TYPE_FIXED_BAR, FormEntity::DISPLAY_TYPE_SLIDE_IN]
)) {
$padding = $formSettings['form_padding'];
$media .= " @media (min-width: 500px) {{$selector} {padding: {$padding}px;}} ";
} else {
$formStyles[] = 'padding: ' . $formSettings['form_padding'] . 'px';
}
}
$formElementStyles = '';
if ($formStyles) {

7
tests/unit/Form/Util/StylesTest.php
View File

@ -68,6 +68,13 @@ class StylesTest extends \MailPoetUnitTest {
expect($styles)->contains('form.mailpoet_form {padding: 22px');
}
public function testItShouldNotRenderPaddingForMobile() {
$form = Fixtures::get('simple_form_body');
$form['settings'] = ['form_padding' => '22'];
$styles = $this->styles->renderFormSettingsStyles($form, '#prefix', FormEntity::DISPLAY_TYPE_SLIDE_IN);
expect($styles)->contains('min-width: 500px) {#prefix {padding: 22px;');
}
public function testItShouldRenderAlignment() {
$form = Fixtures::get('simple_form_body');
$form['settings'] = ['alignment' => 'right'];