Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add "in the last" parameter to "mailpoet:subscriber:email-clicked-count" field

Browse Source 
[PREMIUM-253]
This commit is contained in:
Jan Jakes
2024-02-12 14:42:51 +01:00
committed by Aschepikov
parent 1c7ed9602f
commit f36b117987
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mailpoet/lib/Automation/Integrations/MailPoet/Fields/SubscriberStatisticFieldsFactory.php
View File

@@ -51,9 +51,9 @@ class SubscriberStatisticFieldsFactory {
'mailpoet:subscriber:email-clicked-count',
Field::TYPE_INTEGER,
__('Email — clicked count', 'mailpoet'),
function (SubscriberPayload $payload) {
$stats = $this->subscriberStatisticsRepository->getStatistics($payload->getSubscriber());
return $stats->getClickCount();
function (SubscriberPayload $payload, array $params = []) {
$startTime = $this->getStartTime($params);
return $this->subscriberStatisticsRepository->getStatisticsClickCount($payload->getSubscriber(), $startTime);
}
),
];

7
mailpoet/tests/integration/Automation/Integrations/MailPoet/Fields/SubscriberStatisticsFieldsFactoryTest.php
View File

@@ -113,6 +113,10 @@ class SubscriberStatisticsFieldsFactoryTest extends MailPoetTest {
(new StatisticsClicksFactory($link1, $subscriber))->create(); // click 1
(new StatisticsClicksFactory($link2, $subscriber))->create(); // click 2
// click dates are filtered by newsletter stats dates
(new StatisticsNewslettersFactory($newsletter1, $subscriber))->withSentAt(new Carbon('-1 week'))->create();
(new StatisticsNewslettersFactory($newsletter2, $subscriber))->withSentAt(new Carbon('-1 day'))->create();
// check definitions
$field = $fields['mailpoet:subscriber:email-clicked-count'];
$this->assertSame('Email — clicked count', $field->getName());
@@ -122,6 +126,9 @@ class SubscriberStatisticsFieldsFactoryTest extends MailPoetTest {
// check values
$payload = new SubscriberPayload($subscriber);
$this->assertSame(2, $field->getValue($payload));
$this->assertSame(2, $field->getValue($payload, ['in_the_last_seconds' => 3 * WEEK_IN_SECONDS]));
$this->assertSame(1, $field->getValue($payload, ['in_the_last_seconds' => 3 * DAY_IN_SECONDS]));
$this->assertSame(0, $field->getValue($payload, ['in_the_last_seconds' => 3 * HOUR_IN_SECONDS]));
}
/** @return array<string, Field> */