After the update of Gutenberg packages, builds stared failing with
an exit code 1 without any other information.
Increasing the instance helps. We are not completely sure what's causing
the issue. We suspect memory consumption during the build.
In the past, we had to increase from medium to medium+ after updating the webpack to v5
[MAILPOET-5714]
The issue is related to the underlying react-dates library used
in woocommerce/components in calendar/date-range.js
See https://github.com/woocommerce/woocommerce/blob/trunk/packages/js/components/src/calendar/date-range.js#L45-L104
I was not able to fully understand why it started to happen after the update
but I have a suspicion that it may be related to the change that causes rendering
popups at the end of the body.
The Gutenberg library already moved away from react-dates and I assume
that Woo Components will do that as well.
This commit adds a patch that adds e.stopPropagation() to the place
where the original workaround is trying to prevent losing focus.
[MAILPOET-5714]
With the previous fix I accidentally applied box-sizing: border-box;
to everything on the page.
This commit fixes it so that the rule is applied only in places
where it was applied before the upgrade.
[MAILPOET-5714]
This commit addresses an issue that padding control in the email
an editor is rendered without a slider.
This change makes the padding control render the same as in TT4 theme
[MAILPOET-5714]
When checking pages after updating dependencies, I noticed that some buttons have strange colors.
For example, buttons on the "What would you like to create?" page for new newsletters.
I found that this was related to a change in wordpress/components styles.
The original colors were identical to the default WordPress admin color scheme,
so the buttons were ok when an admin used the default scheme, and in case they use a different scheme
the buttons still look like default (blue).
But after the update, all components on MailPoet pages that don't load WP color admin variables
had a strange purple color.
This commit fixes it by including CSS for admin color schemes into mailpoet-plugin.css which is loaded on every MailPoet admin page.
Note the mixin wordpress-admin-schemes() is included in many build styles for other wordpress packages (e.g. wordpress/block-editor)
so admin color schemes worked correctly on some MailPoet pages even before this change.
[MAILPOET-5714]
The dropdown component used for setting the automation name is based
on the document actions component from edit-site package. After the update,
the appearance changed significantly, and it was broken.
This commit adds CSS to restore the original look as before the update.
[MAILPOET-5714]
The currently supported values are 'firstElement' | boolean
Based on the JS doc and my testing, we need to use true
to hide the popup on click elsewhere or by ESC.
[MAILPOET-5714]
Overriding onClick: (setIsBusy?: Dispatch<SetStateAction<boolean>>) => void;
was causing TS errors when passing controls with the type ControlWithSetIsBusy to DropdownMenu.
The OptionButton that uses isBusy logic is used only in the Hero section at automation
Homepage. The setIsBusy function that was passed to control's onClick was not used.
In all other cases where we were passing controls to DrowdownMenu, we didn't set any isBusy state.
So I think it is safe to remove it.
[MAILPOET-5714]
