Fixing the logic to load the PHPStan baseline in the previous commit,
uncovered some ignored errors in phpstan-8.1-baseline.neon that don't
exist anymore.
[MAILPOET-4626]
There was a bug in the code that is used to decide which version of
the PHPStan baseline file should be loaded depending on the PHP
version that is being used.
The if condition for PHP 8.1 was `$phpVersion == 80100` which means
that it matched only PHP 8.1.0 and not any of the 8.1 patch
versions (like 8.1.1 and 8.1.2).
This commit fixes this problem and it also changes the order of the
checks so that they follow the version numbers in ascending order.
Before the checks where unordered.
[MAILPOET-4626]
on newsletter editor page, after successfully authorized the email address the dialog disappears automatically, but the error message stays
MAILPOET-4561
These quotes were causing issues with translations where quote styles
are changed to anything other than double quotes. This was affecting
at least German and French translations.
Because the translations get applied before the search/replace,
changing to something other than standard double quotes meant that
the search string would never be found, leaving the characters
%1$s in the UI.
[MAILPOET-4185]
We need to provide correct --url parameter to WP CLI commands so that
in multisite environment the correct site is affected.
Otherwise the plugins might not be activated for site we run tests on.
[MAILPOET-4625]
In case $SKIP_PLUGINS is set to 1 we don't activate installed plugins so it makes no sense to install them as well.
In this commit we add also skipping the installation of the plugins.
[MAILPOET-4566]
./do test:woo-integration - runs test from Woo group with and activate plugins
./do test:base-integration - runs test without Woo group with and doesn't activate plugins
[MAILPOET-4566]
This fixes error on CI: Invalid datetime format: 1292 Incorrect datetime value: '0000-00-00 00:00:00' for column 'date_created' at row 1
Locally this error wasn't present but we use a different DB because of ARM architecture.
Also previously we created the lookup table using a custom SQL but now they are created by WooCommerce plugin itself.
[MAILPOET-4566]
The plugin needs to be able to run without WooCommerce active.
We want to splint tests that are related WooCommerce integration so that
we can run the others without WooCommerce installed, to be sure the plugin
is not accidentally dependent on WooCommerce.
[MAILPOET-4566]
When the command was defined as parameter other parameters used within the command were never interpreted.
This was causing that << parameters.multisite >> was always empty and we actually
never run the integration tests as multisite.
Moving the command directly under the command property fixes the issue.
The run_command parameter was never used to overwrite the default value
so we are save to move it.
[MAILPOET-4566]
When the DMARC error message is displayed, add the sentence Click here to start the authentication. This will be a link that opens the verify domain dialogue
MAILPOET-4311