Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove quotes from find/replace strings

Browse Source 
These quotes were causing issues with translations where quote styles
are changed to anything other than double quotes. This was affecting
at least German and French translations.

Because the translations get applied before the search/replace,
changing to something other than standard double quotes meant that
the search string would never be found, leaving the characters
%1$s in the UI.

[MAILPOET-4185]
This commit is contained in:
John Oleksowicz
2022-04-19 11:21:59 -05:00
committed by Veljko V
parent 81f3a0420a
commit f72d72a28a
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mailpoet/assets/js/src/newsletters/listings/welcome.jsx
View File

@@ -248,7 +248,7 @@ class NewsletterListWelcomeComponent extends Component {
} else {
sendingEvent = ReactStringReplace(
MailPoet.I18n.t('welcomeEventWPUserWithRole'),
'"%1$s"',
'%1$s',
(match, i) => (
<Tag variant="list" key={i}>
{mailpoetRoles[newsletter.options.role]}
@@ -278,7 +278,7 @@ class NewsletterListWelcomeComponent extends Component {
sendingEvent = ReactStringReplace(
MailPoet.I18n.t('welcomeEventSegment'),
'"%1$s"',
'%1$s',
(match, i) => (
<Tag variant="list" key={i}>
{segment.name}

6
mailpoet/views/newsletters.html
View File

@@ -311,11 +311,9 @@
'reEngagementEmailActivationFailed': __('Your ReEngagement Email could not be activated, please check the settings.'),
'postNotificationActivated': __('Your post notification is now active!'),
'postNotificationActivationFailed': __('Your Post Notification could not be activated, check the settings.'),
'welcomeEventSegment': __('Sent when someone subscribes to the list: "%1$s".'),
'welcomeEventSegment_new': __('Sent when someone subscribes to the list: %1$s.'),
'welcomeEventSegment': __('Sent when someone subscribes to the list: %1$s.'),
'welcomeEventWPUserAnyRole': __('Sent when a new WordPress user is added to your site.'),
'welcomeEventWPUserWithRole': __('Sent when a new WordPress user with the role "%1$s" is added to your site.'),
'welcomeEventWPUserWithRole_new': __('Sent when a new WordPress user with the role %1$s is added to your site.'),
'welcomeEventWPUserWithRole': __('Sent when a new WordPress user with the role %1$s is added to your site.'),
'sendingDelayMinutes': __('%1$d minute(s) later'),
'sendingDelayHours': __('%1$d hour(s) later'),
'sendingDelayDays': __('%1$d day(s) later'),