Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity
18,419 Commits 3 Branches 547 Tags
c0ffcbac9bdbe2310030a04790d5057c10c4b7cc
Commit Graph

18419 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rostislav Wolny
b83dac2ed9 Use setting types instead of inline types when setting tracking settings 
[MAILPOET-5059]
 2023-02-14 12:46:04 +01:00
Rostislav Wolny
ddf4c9109c Use the value of YesNo component directly as it is already boolean 
[MAILPOET-5059]
 2023-02-14 12:46:04 +01:00
Rostislav Wolny
40cdb9a766 Fix tracking settings configuration on WooCommerce setup wizard step 
When testing the woo wizard step i noticed that always set tracking to
'partial' even if the checkbox is checked. When debugging I found that the allowed value
is not a string but boolean. I tested this in wizard and also on the WooCommerce setup page.
I needed to update the acceptance test because it was clicking on 'no' and asserting the outcome as 'yes' was clicked.
[MAILPOET-5059]
 2023-02-14 12:46:04 +01:00
Rostislav Wolny
9cf70c6c3b Sync WooCommerce settings from Woo step in wizard to store 
[MAILPOET-5059]
 2023-02-14 12:46:04 +01:00
Rostislav Wolny
333b121b2a Update store when saving tracking preferences in wizard 
[MAILPOET-5059]
 2023-02-14 12:46:04 +01:00
Rodrigo Primo
1de328abaa Use settings store instead of local component state for sender data 
In [MAILPOET-4818], we started using the settings Redux store to handle
adding the MSS key in the last step of the Welcome Wizard. This
introduced a bug in the previous steps as the same Redux store is not
used. Those steps rely on the component state to track changes to their
fields. This meant that once the user completed the last step, the
changes made in the previous steps were ignored and the default values
for the settings was saved to the database.

This commit fixes this bug for the first step of the wizard by using the
same settings Redux store to track changes to the sender name and
address.

[MAILPOET-5059]
 2023-02-14 12:46:04 +01:00
Rodrigo Primo
6b4b1dfcbe Add basic acceptance test for the welcome wizard 
[MAILPOET-5051]
 2023-02-14 12:46:04 +01:00
alex-mailpoet
66dc6e67ab Remove unnecessary override 
[MAILPOET-4872]
 2023-02-13 14:13:44 -03:00
alex-mailpoet
d8d859d209 Declare properties to avoid dynamic usage in codeception 
[MAILPOET-4872]
 2023-02-13 14:13:44 -03:00
alex-mailpoet
4bd7dd4ad6 Fix codeception PHP 8.2 deprecation notices 
[MAILPOET-4872]
 2023-02-13 14:13:44 -03:00
Sam Najian
359f134881 Fix merge conflict after rebasing trunk 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
a65866d2a8 Use refreshMSSKeyStatus in preview modal to refresh key status 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
3917a559f7 Make a direct call to endpoint to update key pending status 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
24eab9aac3 Refrain from initializing settings store on send page 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
bb240d8e68 Improve call_api return typings 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
f3bf4b36e9 Introduce endpoint to refresh mss key status 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
d8729ef43c Show errors happening when refreshing mss key status 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
4072daa91f Fix failing acceptance test due to change of string 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
3ae281fc1f Add functionality to refresh mss key status in preview modal 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
86ce19085a Fix failing test by ensuring mssKey is approved 
If the mssKey is pending approval the activate button
of welcome newsletters stays disabled

[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
0aceab5a2e Add pending approval message and functionality to send page 
Show a message to user about their pending approval and
allow them to update the status in place via ajax

[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
a48b725c7d Define pending newsletter message component 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
cf5718122f Fix the issue with verifyMssKey overriding is_approved 
The verifyMssKey side effect handler was overriding the value
of is_approved when updating the state.

[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
e7e4276bf2 Fix the issue with failing to set a truthy value correctly 
is_approved was (sometimes) set to string false, which was
causing the js logic to fail

[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
551d68ff69 Convert sent.tsx to jsx 
[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Sam Najian
61fa215607 Extend the pending approval message on settings/premium 
The message is extended with a link to re-verify the key
and update the status

[MAILPOET-4633]
 2023-02-13 16:56:54 +01:00
Jan Jakes
89df50c160 Always skip unknown migrations (not only completed ones) 
[MAILPOET-5054]
 2023-02-13 16:56:01 +01:00
Jan Jakes
e9326e8c9e Handle a case when migrations table contains invalid data 
See: https://wordpress.org/support/topic/null-values-are-exported-as-empty-strings/

[MAILPOET-5054]
 2023-02-13 16:56:01 +01:00
Oluwaseun Olorunsola
956d693454 Skip redirecting to MailPoet landing page when activated from WooCommerce setup wizard 
MAILPOET-5058
 2023-02-13 16:23:59 +01:00
Rostislav Wolny
a76fb6c63a Update form template "Relax" definition to display correctly 
The popup and slide-in forms should not display email input and submit button in columns.
[MAILPOET-5047]
 2023-02-13 12:14:05 +01:00
Oluwaseun Olorunsola
d061d451a4 Remove Export from Main menu options 
MAILPOET-5045
 2023-02-13 11:58:58 +01:00
Jan Jakes
52e19d445a Update pnpm to the latest version 
[MAILPOET-5055]
 2023-02-09 09:57:30 +02:00
alex-mailpoet
c6a3e08c34 Fix soundasleep/html2text PHP 8.2 deprecation notices 
[MAILPOET-4875]
 2023-02-08 15:26:14 +01:00
alex-mailpoet
a11a462eee Fix gregwar/captcha PHP 8.2 deprecation notices 
[MAILPOET-4874]
 2023-02-08 15:26:14 +01:00
David Remer
310d689219 Ensure image reloads in safari 
Safari does not reload the image when only the hash
changes. Therefore we use the cachebust get parameter
like we do already for the audio

[MAILPOET-5032]
 2023-02-08 13:08:09 +01:00
David Remer
118cc83cc2 Remove 'Click to refresh' in title because a click does no longer refresh 
[MAILPOET-5032]
 2023-02-08 13:08:09 +01:00
David Remer
3da2144ead Extend audio type by range header 
[MAILPOET-5032]
 2023-02-08 13:08:09 +01:00
David Remer
b17a9cb4ae Add test to ensure HTTP_RANGE headers do not reload captcha 
[MAILPOET-5032]
 2023-02-08 13:08:09 +01:00
Rodrigo Primo
351c8a0bd7 Remove the s and g parameters from the shop URL 
Those parameters are not working as expected (see
https://github.com/mailpoet/mailpoet/pull/4650#issuecomment-1410881945
for more details). So we are removing them for now and they will be
added again on a separate ticket in the future
(https://mailpoet.atlassian.net/browse/MAILPOET-5046).

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
c705862e82 Use MailPoet module properties instead of the window object 
We want to stop accessing window directly in JS code (see
https://mailpoet.atlassian.net/browse/MAILPOET-2943). So this commit
uses MailPoet module properties instead of accessing
window.mailpoet_mail_function_enabled and window.subscribers_count
directly.

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
dd2f100acd Implement MSS key verification in the MSS step of the welcome wizard 
[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
88398af343 Remove unused translatable strings 
Back in 2020, commit bf13d08a22 removed the code that
used those strings but the strings themselves were never removed.

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
28bc4d6943 Display the MSS step of the wizard when there is a MSS key set 
Before we used to hide the MSS step of the welcome wizard when there was
already a key set. This commit stops this behavior and now we will
always display the MSS step as it will start allowing users to set the
MSS key in it.

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
e1e690ad14 Refactor input and button to validate key to its own components 
This commit refactors the <input> and <button> used to validate the MSS
key to its own components. After doing this, we will be able to reuse
this components outside of the settings app. In particular, we want to
be able to use it in the welcome wizard app.

It also implements one small change to the verify button that is part of
the changes related to the welcome wizard. Now the verify button is
disabled when the MSS key <input> is empty.

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
110b67bd9c Refactor key activation messages to be reused in the welcome wizard 
[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
8788e299e1 Extract updateSettings() and finishWizard to refrain from passing it down 
[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
ed81ae1ccd Simplify code by accessing subscriber count directly 
Instead of passing it down the component chain.

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
d19e297d37 Refactor code to its own function outside component 
Doing this to avoid redefining the function on each render and to
improve readability since a named function was used.

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
c4ce4fd10b Simplify imports by adding an index to common/typography/ 
Doing this based on feedback from first draft version of the PR related
to this commit.

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00
Rodrigo Primo
527ebafc5c Use React Router to navigate between different parts of the MSS step 
This replaces the first implementation that was just a temporary
implementation using the component state.

[MAILPOET-4818]
 2023-02-08 12:56:32 +01:00