Updated renconstruct.toml's syntax #6

DjBRINE1 · 2024-03-26T13:15:10Z

DjBRINE1 commented

2024-03-26 13:15:10 +00:00

First-time contributor

While trying to compile Wan for adroid on my server with RenKit, I stumbled into a bunch renconstruct related errors.
Here's the fixed file that was cross checked with an example provided in RenKit's documentation.
At least now it starts the building process.
(Which ends in an error for me because RenPy apparently needs OpenGL to even launch from cli, sadge)

While trying to compile Wan for adroid on my server with RenKit, I stumbled into a bunch renconstruct related errors. Here's the fixed file that was cross checked with an example provided in RenKit's documentation. At least now it starts the building process. (Which ends in an error for me because RenPy apparently needs OpenGL to even launch from cli, sadge)

DjBRINE1 added 4 commits 2024-03-26 13:15:11 +00:00

3d43db1f58 Updated renconstruct.toml so it could follow the syntax

0d82498063 Updated renconstruct.toml so it could follow the syntax

f51e295176 Yeah, I should've checked closer before pushing

93a95ad724 At least I am doing all this _before_ requesting the merge

MichaelYick commented

2024-03-26 13:28:54 +00:00

Renkit was rewrote into Rust by its author recently and much of the syntax for it has changed, I believe. If you're using a version of renkit not specified in the .woodpecker.yml file, you're likely to have issues when building.

I would suggest following the woodpecker.yml file's operations to properly build the game, or better yet, use their CLI program and run woodpecker-cli exec .woodpecker.yml in the source code directory. That'll create a proper build for you without any hastle (so long as you have docker installed, that is).

@MapAnon Do you think we should backport the .woodpecker.yml and renkit specs from the development repo over here? That may make building-from-source easier for users.

Renkit was rewrote into Rust by its author recently and much of the syntax for it has changed, I believe. If you're using a version of renkit not specified in the .woodpecker.yml file, you're likely to have issues when building. I would suggest following the woodpecker.yml file's operations to properly build the game, or better yet, use their [CLI program](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.4.1) and run `woodpecker-cli exec .woodpecker.yml` in the source code directory. That'll create a proper build for you without any hastle (so long as you have docker installed, that is). @MapAnon Do you think we should backport the .woodpecker.yml and renkit specs from the development repo over here? That may make building-from-source easier for users.

MapAnon commented

2024-03-26 14:31:54 +00:00

@MapAnon Do you think we should backport the .woodpecker.yml and renkit specs from the development repo over here? That may make building-from-source easier for users.

Sure, don't see a reason why not.

Thoughever, woodpecker isn't necessary to build the game locally, renkit does all the work and ideally people should just run from that instead of woodpecker overcomplicating and lengthening the process.

The issue currently is the new patching task adds an additional complication to renkit if people aren't running on debian. I believe the only thing that's necessary is just to install python and the diff patch library from pip. Then all that's needed is some batch/shell script with the renkit command to run (And auto installing the diff library). It all needs to be tested if the option of not using woodpecker is there.

Otherwise, woodpecker's only necessary for properly versioning the game, and if a user wants to do that it's out of my hands since I don't use woodpecker. Some instructions for all systems in the readme.md would be good.

> @MapAnon Do you think we should backport the .woodpecker.yml and renkit specs from the development repo over here? That may make building-from-source easier for users. Sure, don't see a reason why not. Thoughever, woodpecker isn't necessary to build the game locally, renkit does all the work and ideally people should just run from that instead of woodpecker overcomplicating and lengthening the process. The issue currently is the new patching task adds an additional complication to renkit if people aren't running on debian. I _believe_ the only thing that's necessary is just to install python and the diff patch library from pip. Then all that's needed is some batch/shell script with the renkit command to run (And auto installing the diff library). It all needs to be tested if the option of not using woodpecker is there. Otherwise, woodpecker's only necessary for properly versioning the game, and if a user wants to do that it's out of my hands since I don't use woodpecker. Some instructions for all systems in the readme.md would be good.

DjBRINE1 commented

2024-03-26 18:27:34 +00:00

First-time contributor

Renkit was rewrote into Rust by its author recently and much of the syntax for it has changed, I believe. If you're using a version of renkit not specified in the .woodpecker.yml file, you're likely to have issues when building.

My only current issue is the fact that RenPy refuses to run without OpenGL on the VDS I am using to build the project.

Why VDS? Because I currently have no access to my laptop, but I want to be able to test and make RenPy games, running them on my Android device, be it a tablet or a phone.

I will check woodpecker out soon, but I doubt that it fixes the RenPy issue.

> Renkit was rewrote into Rust by its author recently and much of the syntax for it has changed, I believe. If you're using a version of renkit not specified in the .woodpecker.yml file, you're likely to have issues when building. > My only current issue is the fact that RenPy refuses to run without OpenGL on the VDS I am using to build the project. Why VDS? Because I currently have no access to my laptop, but I want to be able to test and make RenPy games, running them on my Android device, be it a tablet or a phone. I will check woodpecker out soon, but I doubt that it fixes the RenPy issue.

DjBRINE1 commented

2024-03-26 20:26:49 +00:00

First-time contributor

I would suggest following the woodpecker.yml file's operations to properly build the game, or better yet, use their CLI program and run woodpecker-cli exec .woodpecker.yml in the source code directory. That'll create a proper build for you without any hastle (so long as you have docker installed, that is).

I had tried to use the woodpecker-cli, but it appears to do almost nothing, trowing this error message:

[bad_habit] Please set an event filter on all when branches

> I would suggest following the woodpecker.yml file's operations to properly build the game, or better yet, use their [CLI program](https://github.com/woodpecker-ci/woodpecker/releases/tag/v2.4.1) and run `woodpecker-cli exec .woodpecker.yml` in the source code directory. That'll create a proper build for you without any hastle (so long as you have docker installed, that is). > I had tried to use the woodpecker-cli, but it appears to do almost nothing, trowing this error message: ```[bad_habit] Please set an event filter on all when branches [bad_habit] Please set an event filter on all when branches

MapAnon commented

2024-04-21 18:51:05 +00:00

This is now obselete with wani version 1.3.7, which upgrades to a new renkit version with a properly formatted config file.

MapAnon closed this pull request

2024-04-21 18:51:05 +00:00