Fixes #183 | Certain CGs are not marked as seen on the gallery #187

GManon · 2022-10-17T05:53:44Z

GManon commented

2022-10-17 05:53:44 +00:00

Turns out that to use renpy.mark_image_seen(name) you need to use ren'py 7.4.7 (Yes, literally the next version). But as per #184 this shouldn't be a problem.

Also, CG a12 technically didn't exist, it was just the background of the fence from the shooting scene, so I just took a screenshot of that moment (Using renpy's screenshot function) and then just compressed it to a ~75% quality JPEG (Like all other CGs). Hopefully all is correct.

Turns out that to use `renpy.mark_image_seen(name)` you need to use ren'py 7.4.7 (Yes, literally the next version). But as per #184 this *shouldn't* be a problem. Also, CG a12 technically didn't exist, it was just the background of the fence from the shooting scene, so I just took a screenshot of that moment (Using renpy's screenshot function) and then just compressed it to a ~75% quality JPEG (Like all other CGs). Hopefully all is correct.

GManon added 4 commits 2022-10-17 05:53:47 +00:00

61bbdf1aff Test

ad2e305591 UnTest

62f389d72e Integrates fix.

3455af0e6e Whoops

MichaelYick commented

2022-10-17 06:30:33 +00:00

This changes one of the cgs proper and I don't feel like unarchiving my development assets to check this one out, can someone verify that a12.jpg is never used in game?

Also this next patch should get its own branch rather than being merged into the patch 7 branch (made an issue at #188).

I'd do all this but im trying not to get too involved with anything due to time constraints. thanks.

This changes one of the cgs proper and I don't feel like unarchiving my development assets to check this one out, can someone verify that `a12.jpg` is never used in game? Also this next patch should get its own branch rather than being merged into the patch 7 branch (made an issue at #188). I'd do all this but im trying not to get too involved with anything due to time constraints. thanks.

GManon added 1 commit 2022-10-17 06:30:51 +00:00

faf57deb40 Testing

GManon commented

2022-10-17 06:32:38 +00:00

The actual scene uses shooterroof.jpg from /images/backgrounds/ which is exactly the same as a12.jpg so a12.jpg would be a dupe.

GManon added 1 commit 2022-10-17 06:35:19 +00:00

12aa16e337 unTesting

MapAnon closed this pull request

2022-10-17 16:33:37 +00:00

MapAnon reopened this pull request

2022-10-17 16:34:15 +00:00

MapAnon commented

2022-10-17 16:35:08 +00:00

Wtf, how'd I accidently close this?
Anyways, yeah it was a dupe. For some reason it is, even though I remember it being the same cg as the past patches and leaving it there intentionally.

Wtf, how'd I accidently close this? Anyways, yeah it was a dupe. For some reason it is, even though I remember it being the same cg as the past patches and leaving it there intentionally.

GManon referenced this pull request

2022-11-02 22:43:11 +00:00

Fixes #183 | Certain CGs are not marked as seen on the gallery #196

GManon closed this pull request

2022-11-02 22:43:23 +00:00

GManon deleted branch gallery_fix

2022-11-02 22:43:35 +00:00