Patch 8 - Translation Menu(s) & misc. fixes #193

Merged
MapAnon merged 30 commits from nutbuster/SnootGame:Patch88 into Patch8 2022-11-16 05:55:05 +00:00
Member

There's some python2 -> python3, dealing with division into integer/float specific fixes for the phone in Chapter 4 and the Bonus flash prompt image.
Add randomized positions to point-rewarding choices.

Todo:

  • Rename Patch7 to Patch8, then for release tag the final commit in that branch as Patch_8.
  • Mouseover fix when idling in Chapter 4 Phone.
  • Come up with a good name for the patch.
  • Redo gallery to show/hide instead see if that works.
  • Merge with spanish translation and rename 'test' to whatever the string it needs to be.
There's some python2 -> python3, dealing with division into integer/float specific fixes for the phone in Chapter 4 and the Bonus flash prompt image. Add randomized positions to point-rewarding choices. Todo: * Rename Patch7 to Patch8, then for release tag the final commit in that branch as Patch_8. * Mouseover fix when idling in Chapter 4 Phone. * Come up with a good name for the patch. * Redo gallery to show/hide instead see if that works. * Merge with spanish translation and rename 'test' to whatever the string it needs to be.
188 KiB
152 KiB
nutbuster added 9 commits 2022-10-29 06:14:06 +00:00
nutbuster changed target branch from Patch7 to Patch8 2022-10-29 06:22:35 +00:00
nutbuster added 1 commit 2022-11-01 21:51:59 +00:00
nutbuster added 1 commit 2022-11-02 01:11:14 +00:00
Contributor

The translation string should be "es". Hopefully the menu randomization doesn't break the translations.

The translation string should be "es". Hopefully the menu randomization doesn't break the translations.
Contributor

Also, the spanish translation is in neutral spanish, having a Spain flag might give a wrong idea. Maybe change it to the mexican one?

Also, the spanish translation is in neutral spanish, having a Spain flag might give a wrong idea. Maybe change it to the mexican one?
nutbuster added 1 commit 2022-11-02 21:13:29 +00:00
nutbuster added 2 commits 2022-11-02 21:17:51 +00:00
Author
Member

Also, the spanish translation is in neutral spanish, having a Spain flag might give a wrong idea. Maybe change it to the mexican one?

I see, changed the flag.

> Also, the spanish translation is in neutral spanish, having a Spain flag might give a wrong idea. Maybe change it to the mexican one? I see, changed the flag.
18 KiB
nutbuster added 6 commits 2022-11-09 05:46:17 +00:00
nutbuster force-pushed Patch88 from e10dcf09cc to be09b403b8 2022-11-09 05:51:02 +00:00 Compare
nutbuster added 4 commits 2022-11-11 02:27:33 +00:00
nutbuster force-pushed Patch88 from 9cdcd7345a to d733fd1293 2022-11-11 02:29:57 +00:00 Compare
nutbuster changed title from WIP: Patch 8 - Translation Menu(s) & misc. fixes to Patch 8 - Translation Menu(s) & misc. fixes 2022-11-11 02:30:51 +00:00
nutbuster force-pushed Patch88 from d733fd1293 to 54f5c7b857 2022-11-11 02:44:55 +00:00 Compare
Contributor

Be sure to mark the hard coded credits as translatable _('string').

Be sure to mark the hard coded credits as translatable `_('string')`.
Member

I still sincerely don't believe we need the choice randomization, as the notion of "top choice is the correct choice" is dispelled if the choices are placed manually without consistency anyway, no clunky choice position randomization on startup that's not so great to read needed, and all it will do is be a nuisance when speeding through the game. I recommend we just revert back to how it was before.

I still sincerely don't believe we need the choice randomization, as the notion of "top choice is the correct choice" is dispelled if the choices are placed manually without consistency anyway, no clunky choice position randomization on startup that's not so great to read needed, and all it will do is be a nuisance when speeding through the game. I recommend we just revert back to how it was before.
nutbuster added 1 commit 2022-11-12 10:47:01 +00:00
nutbuster added 1 commit 2022-11-12 10:50:37 +00:00
Author
Member

Add the list in #189, appended with (Spanish) to make it more clearer

Add the list in #189, appended with `(Spanish)` to make it more clearer
Member

This would make the credits tiringly long if there were anymore translations to exist, can we shorten it down with less categories? Like:

Spanish Translation

name
name
name

Other language Translation

name
name
name
This would make the credits tiringly long if there were anymore translations to exist, can we shorten it down with less categories? Like: ``` Spanish Translation name name name Other language Translation name name name ```
nutbuster added 1 commit 2022-11-15 03:43:53 +00:00
Author
Member

Currently looks like this.

Currently looks like this.
60 KiB
Contributor

Could you also mark the Backup Anons and 'Only Person In The Team With A\nPortfolio/Experience Anon' as translatable?

Could you also mark the `Backup Anons` and `'Only Person In The Team With A\nPortfolio/Experience Anon'` as translatable?
nutbuster added 1 commit 2022-11-15 21:58:18 +00:00
Member

I've done some tweaks beyond this, including some fixes. I'll merge this into patch 8 first before creating my pr

I've done some tweaks beyond this, including some fixes. I'll merge this into patch 8 first before creating my pr
MapAnon merged commit 59c43c4de6 into Patch8 2022-11-16 05:55:05 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#193
No description provided.